diff options
| author | Thomas Lamprecht <t.lamprecht@proxmox.com> | 2025-06-17 14:39:55 +0200 |
|---|---|---|
| committer | Thomas Lamprecht <t.lamprecht@proxmox.com> | 2025-06-17 14:40:40 +0200 |
| commit | 886ece2b00af7b65e21208ff2b7dbf5dbe8a514c (patch) | |
| tree | 371b0395eb1019c03f1c453f2f61587ae8418b05 | |
| parent | 2b810bd7ff91d8f91e6aa6e4da2c1fdf48c1fa38 (diff) | |
tree-wide: avoid "return" statement followed by "sort"
As returning the result from sort directly is undefined if called in a
scalar context. Reported by perlcritic.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
| -rw-r--r-- | src/PVE/Network/SDN/Controllers.pm | 3 | ||||
| -rw-r--r-- | src/PVE/Network/SDN/Subnets.pm | 3 | ||||
| -rw-r--r-- | src/PVE/Network/SDN/Vnets.pm | 3 | ||||
| -rw-r--r-- | src/PVE/Network/SDN/Zones.pm | 3 |
4 files changed, 8 insertions, 4 deletions
diff --git a/src/PVE/Network/SDN/Controllers.pm b/src/PVE/Network/SDN/Controllers.pm index 6024f22..2ffd75e 100644 --- a/src/PVE/Network/SDN/Controllers.pm +++ b/src/PVE/Network/SDN/Controllers.pm @@ -57,7 +57,8 @@ sub lock_sdn_controllers_config { sub sdn_controllers_ids { my ($cfg) = @_; - return sort keys %{ $cfg->{ids} }; + my @sorted_ids = sort keys $cfg->{ids}->%*; + return @sorted_ids; } sub complete_sdn_controller { diff --git a/src/PVE/Network/SDN/Subnets.pm b/src/PVE/Network/SDN/Subnets.pm index 1bcb47a..1f27fac 100644 --- a/src/PVE/Network/SDN/Subnets.pm +++ b/src/PVE/Network/SDN/Subnets.pm @@ -79,7 +79,8 @@ sub write_config { sub sdn_subnets_ids { my ($cfg) = @_; - return sort keys %{ $cfg->{ids} }; + my @sorted_ids = sort keys $cfg->{ids}->%*; + return @sorted_ids; } sub complete_sdn_subnet { diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm index c16e7e5..c327a4b 100644 --- a/src/PVE/Network/SDN/Vnets.pm +++ b/src/PVE/Network/SDN/Vnets.pm @@ -46,7 +46,8 @@ sub write_config { sub sdn_vnets_ids { my ($cfg) = @_; - return sort keys %{ $cfg->{ids} }; + my @sorted_ids = sort keys $cfg->{ids}->%*; + return @sorted_ids; } sub complete_sdn_vnet { diff --git a/src/PVE/Network/SDN/Zones.pm b/src/PVE/Network/SDN/Zones.pm index 01c168c..007d746 100644 --- a/src/PVE/Network/SDN/Zones.pm +++ b/src/PVE/Network/SDN/Zones.pm @@ -67,7 +67,8 @@ sub write_config { sub sdn_zones_ids { my ($cfg) = @_; - return sort keys %{ $cfg->{ids} }; + my @sorted_ids = sort keys $cfg->{ids}->%*; + return @sorted_ids; } sub complete_sdn_zone { |