2 files changed, 125 insertions, 5 deletions

diff --git a/tests/lib/script1.lua b/tests/lib/script1.lua
index e9ebc29bd9..6361c960a7 100644
--- a/tests/lib/script1.lua
+++ b/tests/lib/script1.lua
@@ -1 +1,54 @@
-a = a + b
+
+-- Positive testing
+
+function foo(a, b)
+  a = a + 1
+  b = b + 1
+  return {
+    a = a,
+    b = b,
+  }
+end
+
+function bar(a, b)
+  a = a + 1
+  b = b + 1
+  c = 303
+  return {
+    b = b,
+    c = c,
+  }
+end
+
+function fact(n)
+  -- outer function must return a table
+  -- inner functions can be used to recurse or as helpers
+  function helper(m)
+    if m == 0 then
+      return 1
+    else
+      return m * helper(m - 1)
+    end
+  end
+  return {
+    ans = helper(n)
+  }
+end
+
+-- Negative testing
+
+function bad_return1()
+end
+
+function bad_return2()
+  return 123
+end
+
+function bad_return3()
+  return {}
+end
+
+function bad_return4()
+  error("Something bad!")
+end
+
diff --git a/tests/lib/test_frrscript.c b/tests/lib/test_frrscript.c
index bd75cc5552..7b23045978 100644
--- a/tests/lib/test_frrscript.c
+++ b/tests/lib/test_frrscript.c
@@ -20,18 +20,85 @@
 #include <zebra.h>
 
 #include "lib/frrscript.h"
+#include "lib/frrlua.h"
 
 int main(int argc, char **argv)
 {
 	frrscript_init("./lib");
+	struct frrscript *fs = frrscript_new("script1");
+	int result;
+
+	/* Positive testing */
 
-	struct frrscript *fs = frrscript_load("script1", NULL);
 	long long a = 100, b = 200;
-	int result = frrscript_call(fs, ("a", &a), ("b", &b));
 
+	result = frrscript_load(fs, "foo", NULL);
+	assert(result == 0);
+	result = frrscript_call(fs, "foo", ("a", &a), ("b", &b));
+	assert(result == 0);
+	assert(a == 101);
+	assert(b == 201);
+
+	a = 100, b = 200;
+
+	result = frrscript_load(fs, "bar", NULL);
+	assert(result == 0);
+	result = frrscript_call(fs, "bar", ("a", &a), ("b", &b));
+	assert(result == 0);
+	long long *cptr = frrscript_get_result(fs, "bar", "c", lua_tointegerp);
+
+	/* a should not occur in the returned table in script */
+	assert(a == 100);
+	assert(b == 201);
+	assert(*cptr == 303);
+	XFREE(MTYPE_SCRIPT_RES, cptr);
+
+	long long n = 5;
+
+	result = frrscript_load(fs, "fact", NULL);
 	assert(result == 0);
-	assert(a == 300);
-	assert(b == 200);
+	result = frrscript_call(fs, "fact", ("n", &n));
+	assert(result == 0);
+	long long *ansptr =
+		frrscript_get_result(fs, "fact", "ans", lua_tointegerp);
+	assert(*ansptr == 120);
+	XFREE(MTYPE_SCRIPT_RES, ansptr);
+
+	/* Negative testing */
+
+	/* Function does not exist in script file*/
+	result = frrscript_load(fs, "does_not_exist", NULL);
+	assert(result == 1);
+
+	/* Function was not (successfully) loaded */
+	result = frrscript_call(fs, "does_not_exist", ("a", &a), ("b", &b));
+	assert(result == 1);
+
+	/* Get result from a function that was not loaded */
+	long long *llptr =
+		frrscript_get_result(fs, "does_not_exist", "c", lua_tointegerp);
+	assert(llptr == NULL);
+
+	/* Function returns void */
+	result = frrscript_call(fs, "bad_return1");
+	assert(result == 1);
+
+	/* Function returns number */
+	result = frrscript_call(fs, "bad_return2");
+	assert(result == 1);
+
+	/* Get non-existent result from a function */
+	result = frrscript_call(fs, "bad_return3");
+	assert(result == 1);
+	long long *cllptr =
+		frrscript_get_result(fs, "bad_return3", "c", lua_tointegerp);
+	assert(cllptr == NULL);
+
+	/* Function throws exception */
+	result = frrscript_call(fs, "bad_return4");
+	assert(result == 1);
+
+	frrscript_delete(fs);
 
 	return 0;
 }