summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
Diffstat (limited to 'lib')
-rw-r--r--lib/buffer.c1
-rw-r--r--lib/command_match.c6
-rw-r--r--lib/grammar_sandbox.c4
-rw-r--r--lib/linklist.c4
-rw-r--r--lib/termtable.c8
5 files changed, 11 insertions, 12 deletions
diff --git a/lib/buffer.c b/lib/buffer.c
index 1799c6b94f..446bad85e9 100644
--- a/lib/buffer.c
+++ b/lib/buffer.c
@@ -445,7 +445,6 @@ in one shot. */
/* Free printed buffer data. */
while (written > 0) {
- struct buffer_data *d;
if (!(d = b->head)) {
flog_err(
LIB_ERR_DEVELOPMENT,
diff --git a/lib/command_match.c b/lib/command_match.c
index c165305d78..a1ae3ac6b9 100644
--- a/lib/command_match.c
+++ b/lib/command_match.c
@@ -195,7 +195,7 @@ static enum matcher_rv command_match_r(struct graph_node *start, vector vline,
enum matcher_rv status = MATCHER_NO_MATCH;
// get the minimum match level that can count as a full match
- struct cmd_token *token = start->data;
+ struct cmd_token *copy, *token = start->data;
enum match_type minmatch = min_match_level(token->type);
/* check history/stack of tokens
@@ -326,8 +326,8 @@ static enum matcher_rv command_match_r(struct graph_node *start, vector vline,
}
if (*currbest) {
// copy token, set arg and prepend to currbest
- struct cmd_token *token = start->data;
- struct cmd_token *copy = cmd_token_dup(token);
+ token = start->data;
+ copy = cmd_token_dup(token);
copy->arg = XSTRDUP(MTYPE_CMD_ARG, input_token);
listnode_add_before(*currbest, (*currbest)->head, copy);
} else if (n + 1 == vector_active(vline) && status == MATCHER_NO_MATCH)
diff --git a/lib/grammar_sandbox.c b/lib/grammar_sandbox.c
index ef03e85217..0d6200b006 100644
--- a/lib/grammar_sandbox.c
+++ b/lib/grammar_sandbox.c
@@ -315,7 +315,7 @@ static void cmd_graph_permute(struct list *out, struct graph_node **stack,
struct graph_node *gn = stack[stackpos];
struct cmd_token *tok = gn->data;
char *appendp = cmd + strlen(cmd);
- size_t i, j;
+ size_t j;
if (tok->type < SPECIAL_TKN) {
sprintf(appendp, "%s ", tok->text);
@@ -332,7 +332,7 @@ static void cmd_graph_permute(struct list *out, struct graph_node **stack,
if (++stackpos == CMD_ARGC_MAX)
return;
- for (i = 0; i < vector_active(gn->to); i++) {
+ for (size_t i = 0; i < vector_active(gn->to); i++) {
struct graph_node *gnext = vector_slot(gn->to, i);
for (j = 0; j < stackpos; j++)
if (stack[j] == gnext)
diff --git a/lib/linklist.c b/lib/linklist.c
index effd384e46..bee9d05a2c 100644
--- a/lib/linklist.c
+++ b/lib/linklist.c
@@ -318,8 +318,8 @@ void list_sort(struct list *list, int (*cmp)(const void **, const void **))
qsort(items, n, sizeof(void *), realcmp);
- for (unsigned int i = 0; i < n; ++i)
- listnode_add(list, items[i]);
+ for (unsigned int j = 0; j < n; ++j)
+ listnode_add(list, items[j]);
XFREE(MTYPE_TMP, items);
}
diff --git a/lib/termtable.c b/lib/termtable.c
index ba85962cc9..7bdb1ff873 100644
--- a/lib/termtable.c
+++ b/lib/termtable.c
@@ -395,7 +395,7 @@ char *ttable_dump(struct ttable *tt, const char *newline)
memcpy(&buf[pos], left, lsize);
pos += lsize;
- for (size_t i = 0; i < width - lsize - rsize; i++)
+ for (size_t l = 0; l < width - lsize - rsize; l++)
buf[pos++] = row[0].style.border.top;
pos -= width - lsize - rsize;
@@ -421,7 +421,7 @@ char *ttable_dump(struct ttable *tt, const char *newline)
buf[pos++] = row[j].style.border.left;
/* print left padding */
- for (int i = 0; i < row[j].style.lpad; i++)
+ for (int k = 0; k < row[j].style.lpad; k++)
buf[pos++] = ' ';
/* calculate padding for sprintf */
@@ -443,7 +443,7 @@ char *ttable_dump(struct ttable *tt, const char *newline)
pos += sprintf(&buf[pos], fmt, abspad, row[j].text);
/* print right padding */
- for (int i = 0; i < row[j].style.rpad; i++)
+ for (int k = 0; k < row[j].style.rpad; k++)
buf[pos++] = ' ';
/* if right border && not last col print right border */
@@ -483,7 +483,7 @@ char *ttable_dump(struct ttable *tt, const char *newline)
memcpy(&buf[pos], left, lsize);
pos += lsize;
- for (size_t i = 0; i < width - lsize - rsize; i++)
+ for (size_t l = 0; l < width - lsize - rsize; l++)
buf[pos++] = tt->style.border.bottom;
memcpy(&buf[pos], right, rsize);