diff options
| author | Quentin Young <qlyoung@cumulusnetworks.com> | 2017-08-25 13:39:13 -0400 |
|---|---|---|
| committer | Quentin Young <qlyoung@cumulusnetworks.com> | 2017-08-25 15:41:27 -0400 |
| commit | 8295b504cbd6df715b779287ff9d2374ae306421 (patch) | |
| tree | 6040542906d943e1b2a8ab04c17266fe11378683 /zebra/interface.c | |
| parent | e1bd637370df9708af91c699b2510a788625bc5a (diff) | |
lib: fix rare bug in ambiguous command resolution
In certain situations, the CLI matcher would not handle ambiguous
commands properly. If it found an ambiguous result in a lower subgraph,
the ambiguous result would not correctly propagate up to previous frames
in the resolution DFS as ambiguous; instead it would propagate up as a
non-match, which could subsequently be overridden by a partial match.
Example CLI space:
show ip route summary
show ip route supernet-only
show ipv6 route summary
Entering `show ip route su` would result in an ambiguous resolution for
the `show ip route` subgraph but would propagate up to the `show ip`
subgraph as a no-match, allowing `ip` to partial-match `ipv6` and
execute that command.
In this example entering `show ip route summary` would disambiguate the
`show ip` subgraph. So this bug would only appear when entering input
that caused ambiguities in at least two parallel subgraphs.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Diffstat (limited to 'zebra/interface.c')
0 files changed, 0 insertions, 0 deletions
