diff options
| author | Mark Stapp <mjs.ietf@gmail.com> | 2021-08-12 16:45:38 -0400 |
|---|---|---|
| committer | Mark Stapp <mjs.ietf@gmail.com> | 2021-08-13 16:06:07 -0400 |
| commit | e9f79fff5711cf307e73436bc91a8a84bf165868 (patch) | |
| tree | 25faa8828501c971e5349268c9739b73b6717c36 /zebra/if_netlink.c | |
| parent | c123e9df54e55c61b1666ec3b55b267c86865d49 (diff) | |
zebra: interface name must be a valid string
Validate incoming netlink interface name strings.
Signed-off-by: Mark Stapp <mjs.ietf@gmail.com>
Diffstat (limited to 'zebra/if_netlink.c')
| -rw-r--r-- | zebra/if_netlink.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c index a51e0b82cb..2a9fff2666 100644 --- a/zebra/if_netlink.c +++ b/zebra/if_netlink.c @@ -1527,6 +1527,14 @@ int netlink_link_change(struct nlmsghdr *h, ns_id_t ns_id, int startup) return -1; name = (char *)RTA_DATA(tb[IFLA_IFNAME]); + /* Must be valid string. */ + len = RTA_PAYLOAD(tb[IFLA_IFNAME]); + if (len < 2 || name[len - 1] != '\0') { + if (IS_ZEBRA_DEBUG_KERNEL) + zlog_debug("%s: invalid intf name", __func__); + return -1; + } + if (tb[IFLA_LINKINFO]) { netlink_parse_rtattr_nested(linkinfo, IFLA_INFO_MAX, tb[IFLA_LINKINFO]); |