diff options
| author | anlan_cs <vic.lan@pica8.com> | 2022-04-26 00:14:34 -0400 |
|---|---|---|
| committer | anlan_cs <vic.lan@pica8.com> | 2022-05-07 22:20:15 -0400 |
| commit | 17151ae94bd9ddc2eab6a9b1c5fcfea3e53defe3 (patch) | |
| tree | e6ba9632deb71cc3a68496321246260d3495914a /tests/lib/test_xref.py | |
| parent | 50f1f2e724f8614ada1a1a02dd28f1ff3af06e08 (diff) | |
bgpd: clear misleading mismatched check
Two changes for `delete_global_type2_routes()`:
1) Remove check of `bgp_dest_has_bgp_path_info_data(rddest)`.
It is unnecessary(`dest->info` should not be NULL) and misleading.
`if (rddest && bgp_dest_has_bgp_path_info_data(rddest))`
Use (locked) node with this check, but unlock with `if (rddest)`,
The mismatched condition is misleading, there seems to be a
mistake to extra unlock.
Just make it clear, immediately exit with `(!rddest)`.
2) Remove checking returned value for it, and use `void` as return type.
It is unnecessary and wrong. Even the check failed, it should continue
to delete other types of routes.
Just remove the check and go through.
Signed-off-by: anlan_cs <vic.lan@pica8.com>
Diffstat (limited to 'tests/lib/test_xref.py')
0 files changed, 0 insertions, 0 deletions
