diff options
| author | Carmine Scarpitta <cscarpit@cisco.com> | 2024-01-04 11:10:20 +0100 |
|---|---|---|
| committer | Carmine Scarpitta <cscarpit@cisco.com> | 2024-01-04 11:13:31 +0100 |
| commit | a061ba2348e208dc08c993e72c1e6d7d0ae0d04a (patch) | |
| tree | ccef7970608e5f9ba54978df2c92b67fc8fcf399 /python/xref2vtysh.py | |
| parent | 2aef6958f8703b484fef3462180abca9c51eed35 (diff) | |
zebra: `ctx` has to be non NULL at this point
Fix the following coverity issue:
*** CID 1575079: Null pointer dereferences (REVERSE_INULL)
/zebra/zebra_dplane.c: 5950 in dplane_srv6_encap_srcaddr_set()
5944 if (ret == AOK)
5945 result = ZEBRA_DPLANE_REQUEST_QUEUED;
5946 else {
5947 atomic_fetch_add_explicit(&zdplane_info
5948 .dg_srv6_encap_srcaddr_set_errors,
5949 1, memory_order_relaxed);
CID 1575079: Null pointer dereferences (REVERSE_INULL)
Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
5950 if (ctx)
5951 dplane_ctx_free(&ctx);
5952 }
5953 return result;
5954 }
5955
Remove the pointer check for `ctx`. At this point in the
function it has to be non null since we deref'ed it.
Additionally the alloc function that creates it cannot
fail.
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Diffstat (limited to 'python/xref2vtysh.py')
0 files changed, 0 insertions, 0 deletions
