diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2017-02-10 13:46:52 -0500 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2017-02-24 10:03:40 -0500 |
| commit | f8e7d7992fe201052e3969bdd4aab217ffd4d505 (patch) | |
| tree | 897aa1fd39414d2dc7f9a73b0b8a3c21060df5a4 /pimd/pim_assert.c | |
| parent | 70ce34ae66184d4b456f45e6544c5fc0c350f2e5 (diff) | |
pimd: Assume buffer size passed in is of sufficient size
For:
pim_msg_build_header
pim_msg_addr_encode_ipv4_ucast
pim_msg_addr_encode_ipv4_group
pim_msg_addr_encode_ipv4_source
Assume that the buffer size passed in is of sufficient size
already. This is assured already because buffer sizes
are checked for minimum lengths for the entire packet
ahead of time. So we are double checking.
Additionally at scale we will be calling these functions
a very very large number of times.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'pimd/pim_assert.c')
| -rw-r--r-- | pimd/pim_assert.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/pimd/pim_assert.c b/pimd/pim_assert.c index d6f372cc44..f2bfb846dd 100644 --- a/pimd/pim_assert.c +++ b/pimd/pim_assert.c @@ -379,9 +379,7 @@ int pim_assert_build_msg(uint8_t *pim_msg, int buf_size, /* Encode group */ remain = buf_pastend - pim_msg_curr; - pim_msg_curr = pim_msg_addr_encode_ipv4_group(pim_msg_curr, - remain, - group_addr); + pim_msg_curr = pim_msg_addr_encode_ipv4_group(pim_msg_curr, group_addr); if (!pim_msg_curr) { char group_str[INET_ADDRSTRLEN]; pim_inet4_dump("<grp?>", group_addr, group_str, sizeof(group_str)); @@ -392,9 +390,7 @@ int pim_assert_build_msg(uint8_t *pim_msg, int buf_size, /* Encode source */ remain = buf_pastend - pim_msg_curr; - pim_msg_curr = pim_msg_addr_encode_ipv4_ucast(pim_msg_curr, - remain, - source_addr); + pim_msg_curr = pim_msg_addr_encode_ipv4_ucast(pim_msg_curr, source_addr); if (!pim_msg_curr) { char source_str[INET_ADDRSTRLEN]; pim_inet4_dump("<src?>", source_addr, source_str, sizeof(source_str)); |