ospfd: ospfd core if hello packet exceeds link MTU

Ospfd cored because of an assert when we try to write more than the MTU
size to the ospf packet buffer stream. The problem is - we allocate only MTU
sized buffer. The expectation is that Hello packets are never large
enough to approach MTU. Instead of crashing, this fix discards hello and
logs an error. One should not have so many neighbors behind an
interface.

Ticket: CM-22380
Signed-off-by: Nitin Soni <nsoni@cumulusnetworks.com>
Reviewed-by: CCR-8204

1 files changed, 9 insertions, 0 deletions

diff --git a/ospfd/ospf_errors.c b/ospfd/ospf_errors.c
index 566fc29202..b912a80692 100644
--- a/ospfd/ospf_errors.c
+++ b/ospfd/ospf_errors.c
@@ -170,6 +170,15 @@ static struct log_ref ferr_ospf_err[] = {
 		.suggestion = "Gather log files and open an issue",
 	},
 	{
+		.code = EC_OSPF_LARGE_HELLO,
+		.title = "OSPF Encountered a Large Hello",
+		.description = "OSPF attempted to send a Hello larger than MTU "
+					   "but did not",
+		.suggestion = "Too many neighbors configured on a single interface."
+					  " Suggestion is to decrease the number of neighbors on"
+					  " a single interface/subnet"
+	},
+	{
 		.code = END_FERR,
 	}
 };