summaryrefslogtreecommitdiff
path: root/ospf6d/ospf6_abr.c
diff options
context:
space:
mode:
authorDonatas Abraitis <donatas.abraitis@gmail.com>2022-01-11 12:24:41 +0200
committerDonatas Abraitis <donatas.abraitis@gmail.com>2022-01-11 17:07:19 +0200
commited284e2338111ff367087bc87f5ad9c67dd9e6cc (patch)
treea8773640d6b15b2cc62792d0a70d950612c97b16 /ospf6d/ospf6_abr.c
parent0064d4736d8e0b9815a9dd6c57ad44de51aed970 (diff)
bgpd: Make sure we are playing with non-NULL for bgp shutdown message
``` *** CID 1510738: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty.c: 4243 in bgp_shutdown_msg_magic() 4237 if (msgstr && strlen(msgstr) > BGP_ADMIN_SHUTDOWN_MSG_LEN) { 4238 vty_out(vty, "%% Shutdown message size exceeded %d\n", 4239 BGP_ADMIN_SHUTDOWN_MSG_LEN); 4240 return CMD_WARNING_CONFIG_FAILED; 4241 } 4242 >>> CID 1510738: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "msgstr" to "bgp_shutdown_enable", which dereferences it. 4243 bgp_shutdown_enable(bgp, msgstr); 4244 XFREE(MTYPE_TMP, msgstr); 4245 4246 return CMD_SUCCESS; 4247 } 4248 ``` ``` *** CID 1510737: Null pointer dereferences (REVERSE_INULL) /bgpd/bgpd.c: 4344 in bgp_shutdown_enable() 4338 /* continue, if peer is already in administrative shutdown. */ 4339 if (CHECK_FLAG(peer->flags, PEER_FLAG_SHUTDOWN)) 4340 continue; 4341 4342 /* send a RFC 4486 notification message if necessary */ 4343 if (BGP_IS_VALID_STATE_FOR_NOTIF(peer->status)) { >>> CID 1510737: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "msg" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4344 if (msg) 4345 bgp_notify_send_with_data( 4346 peer, BGP_NOTIFY_CEASE, 4347 BGP_NOTIFY_CEASE_ADMIN_SHUTDOWN, data, 4348 datalen + 1); 4349 else ``` Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Diffstat (limited to 'ospf6d/ospf6_abr.c')
0 files changed, 0 insertions, 0 deletions