summaryrefslogtreecommitdiff
path: root/lib/workqueue.c
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@nvidia.com>2022-12-14 14:05:11 -0500
committerDonald Sharp <sharpd@nvidia.com>2022-12-15 11:15:33 -0500
commit074c80b705faa21f1347383ec6310ea17a00ffc2 (patch)
tree463096dbfbd589278346b83ecd0297bda6c412d6 /lib/workqueue.c
parent9a5602b8ed58000f343ebdf548d495b02febcc81 (diff)
lib, tests, zebra: Remove unused workqueue error function
The wq->spec.errorfunc is never used in the code. It's been in the code base since 2005 and I also do not remember ever seeing it being called. No workqueue process function ever returns error. Since it's not used let's just remove it from the code base. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'lib/workqueue.c')
-rw-r--r--lib/workqueue.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/lib/workqueue.c b/lib/workqueue.c
index c703de90b3..a5338ba78b 100644
--- a/lib/workqueue.c
+++ b/lib/workqueue.c
@@ -272,9 +272,6 @@ void work_queue_run(struct thread *thread)
/* dont run items which are past their allowed retries */
if (item->ran > wq->spec.max_retries) {
- /* run error handler, if any */
- if (wq->spec.errorfunc)
- wq->spec.errorfunc(wq, item);
work_queue_item_remove(wq, item);
continue;
}
@@ -317,10 +314,6 @@ void work_queue_run(struct thread *thread)
case WQ_RETRY_NOW:
/* a RETRY_NOW that gets here has exceeded max_tries, same as
* ERROR */
- case WQ_ERROR: {
- if (wq->spec.errorfunc)
- wq->spec.errorfunc(wq, item);
- }
/* fallthru */
case WQ_SUCCESS:
default: {