lib: assert for VTY_PASSFD expectations

Coverity is complaining that vty->state could be VTY_PASSFD here.  It
can't, it really shouldn't, and if it actually is then something went
seriously wrong somewhere earlier so assert()ing out is the best thing
to do.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

1 files changed, 6 insertions, 1 deletions

diff --git a/lib/vty.c b/lib/vty.c
index 8f8effa9cc..15cc340eb0 100644
--- a/lib/vty.c
+++ b/lib/vty.c
@@ -2386,9 +2386,14 @@ static void vtysh_read(struct event *thread)
 					 * => skip vty_event(VTYSH_READ, vty)!
 					 */
 					return;
-				} else
+				} else {
+					assertf(vty->status != VTY_PASSFD,
+						"%p address=%s passfd=%d", vty,
+						vty->address, vty->pass_fd);
+
 					/* normalize other invalid values */
 					vty->pass_fd = -1;
+				}
 
 				/* hack for asynchronous "write integrated"
 				 * - other commands in "buf" will be ditched