diff options
| author | Carmine Scarpitta <cscarpit@cisco.com> | 2024-08-18 12:57:34 +0200 |
|---|---|---|
| committer | Carmine Scarpitta <cscarpit@cisco.com> | 2024-08-18 13:03:04 +0200 |
| commit | 075899dee063a690219c0d3e7c2d4d05136cac08 (patch) | |
| tree | 853391e7fa4cad9695408decbd8b8b20b26352c6 /lib/srv6.h | |
| parent | fa50fde9541348e80bb2b4835f72db86362fa38e (diff) | |
lib: Fix compilation warning
Don't store unnecessary `len` returned by snprintf and snprintfrr function.
Fixes the following compilation warnings:
```
error 15-Aug-2024 13:54:10 In file included from lib/bfd.c:16:
error 15-Aug-2024 13:54:10 In file included from ./lib/zclient.h:22:
error 15-Aug-2024 13:54:10 In file included from ./lib/nexthop.h:14:
error 15-Aug-2024 13:54:10 ./lib/srv6.h:338:3: warning: Value stored to 'len' is never read [deadcode.DeadStores]
error 15-Aug-2024 13:54:10 len += snprintf(str + len, size - len, " USP");
error 15-Aug-2024 13:54:10 ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error 15-Aug-2024 13:54:10 ./lib/srv6.h:343:3: warning: Value stored to 'len' is never read [deadcode.DeadStores]
error 15-Aug-2024 13:54:10 len += snprintfrr(str + len, size - len, " nh6 %pI6", &ctx->nh6);
error 15-Aug-2024 13:54:10 ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error 15-Aug-2024 13:54:10 ./lib/srv6.h:347:3: warning: Value stored to 'len' is never read [deadcode.DeadStores]
error 15-Aug-2024 13:54:10 len += snprintfrr(str + len, size - len, " nh4 %pI4", &ctx->nh4);
error 15-Aug-2024 13:54:10 ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error 15-Aug-2024 13:54:10 ./lib/srv6.h:354:3: warning: Value stored to 'len' is never read [deadcode.DeadStores]
error 15-Aug-2024 13:54:10 len += snprintf(str + len, size - len, " vrf_id %u",
error 15-Aug-2024 13:54:10 ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error 15-Aug-2024 13:54:10 ./lib/srv6.h:367:3: warning: Value stored to 'len' is never read [deadcode.DeadStores]
error 15-Aug-2024 13:54:10 len += snprintf(str + len, size - len, " unknown(%s)", __func__);
error 15-Aug-2024 13:54:10 ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Diffstat (limited to 'lib/srv6.h')
| -rw-r--r-- | lib/srv6.h | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/lib/srv6.h b/lib/srv6.h index 03ada7fcfc..f25c5cfcaa 100644 --- a/lib/srv6.h +++ b/lib/srv6.h @@ -335,24 +335,23 @@ static inline const char *srv6_sid_ctx2str(char *str, size_t size, break; case ZEBRA_SEG6_LOCAL_ACTION_END: - len += snprintf(str + len, size - len, " USP"); + snprintf(str + len, size - len, " USP"); break; case ZEBRA_SEG6_LOCAL_ACTION_END_X: case ZEBRA_SEG6_LOCAL_ACTION_END_DX6: - len += snprintfrr(str + len, size - len, " nh6 %pI6", &ctx->nh6); + snprintfrr(str + len, size - len, " nh6 %pI6", &ctx->nh6); break; case ZEBRA_SEG6_LOCAL_ACTION_END_DX4: - len += snprintfrr(str + len, size - len, " nh4 %pI4", &ctx->nh4); + snprintfrr(str + len, size - len, " nh4 %pI4", &ctx->nh4); break; case ZEBRA_SEG6_LOCAL_ACTION_END_T: case ZEBRA_SEG6_LOCAL_ACTION_END_DT6: case ZEBRA_SEG6_LOCAL_ACTION_END_DT4: case ZEBRA_SEG6_LOCAL_ACTION_END_DT46: - len += snprintf(str + len, size - len, " vrf_id %u", - ctx->vrf_id); + snprintf(str + len, size - len, " vrf_id %u", ctx->vrf_id); break; case ZEBRA_SEG6_LOCAL_ACTION_END_DX2: @@ -364,7 +363,7 @@ static inline const char *srv6_sid_ctx2str(char *str, size_t size, case ZEBRA_SEG6_LOCAL_ACTION_END_AM: case ZEBRA_SEG6_LOCAL_ACTION_END_BPF: default: - len += snprintf(str + len, size - len, " unknown(%s)", __func__); + snprintf(str + len, size - len, " unknown(%s)", __func__); } return str; |