summaryrefslogtreecommitdiff
path: root/lib/printf
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@nvidia.com>2023-05-21 19:59:41 -0400
committerDonald Sharp <sharpd@nvidia.com>2023-05-22 10:52:54 -0400
commitd9dfbab71c8f508c9d90cd90228a18bb60ea43b9 (patch)
treeed15cfdc6e38bcd6455dc808ae8fa5167da7e24e /lib/printf
parentd7c9666e060ecbd31f5fa9b384c2a56118bbb279 (diff)
lib: va_end must be called
According to the man page a va_start must be followed by a va_end before the end of the function. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'lib/printf')
-rw-r--r--lib/printf/glue.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/lib/printf/glue.c b/lib/printf/glue.c
index 25e2ff37a3..f799378af3 100644
--- a/lib/printf/glue.c
+++ b/lib/printf/glue.c
@@ -273,6 +273,7 @@ static ssize_t printfrr_va(struct fbuf *buf, struct printfrr_eargs *ea,
{
const struct va_format *vaf = ptr;
va_list ap;
+ ssize_t s;
if (!vaf || !vaf->fmt || !vaf->va)
return bputs(buf, "NULL");
@@ -285,6 +286,9 @@ static ssize_t printfrr_va(struct fbuf *buf, struct printfrr_eargs *ea,
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wformat-nonliteral"
/* can't format check this */
- return vbprintfrr(buf, vaf->fmt, ap);
+ s = vbprintfrr(buf, vaf->fmt, ap);
#pragma GCC diagnostic pop
+ va_end(ap);
+
+ return s;
}