diff options
| author | Donald Sharp <sharpd@nvidia.com> | 2021-04-30 14:55:40 -0400 |
|---|---|---|
| committer | Donald Sharp <sharpd@nvidia.com> | 2023-08-18 09:29:04 -0400 |
| commit | 1f32eb30d96ae4c92ed8d03fe3aea95d962b59b1 (patch) | |
| tree | f6b05f291bb296f28e8edade5c4200565b072bcb /lib/filter_cli.c | |
| parent | bd6a00e8f7ab48e6ab20673474c6eb1e879cb5c4 (diff) | |
bgpd: Start abstraction of `struct peer_connection`
BGP tracks connections based upon the peer. But the problem
with this is that the doppelganger structure for it is being
created. This has introduced a bunch of fragileness in that
the peer exists independently of the connections to it.
The whole point of the doppelganger structure was to allow
BGP to both accept and initiate tcp connections and then
when we get one to a `good` state we collapse into the
appropriate one. The problem with this is that having
2 peer structures for this creates a situation where
we have to make sure we are configing the `right` one
and also make sure that we collapse the two independent
peer structures into 1 acting peer. This makes no sense
let's abstract out the peer into having 2 connection
one for incoming connections and one for outgoing connections
then we can easily collapse down without having to do crazy
stuff. In addition people adding new features don't need
to have to go touch a million places in the code.
This is the start of this abstraction. In this commit
we'll just pull out the fd and input/output buffers
into a connection data structure. Future commits
will abstract further.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Diffstat (limited to 'lib/filter_cli.c')
0 files changed, 0 insertions, 0 deletions
