diff options
| author | Denil Vira <denil@cumulusnetworks.com> | 2015-07-23 08:47:21 -0700 |
|---|---|---|
| committer | Denil Vira <denil@cumulusnetworks.com> | 2015-07-23 08:47:21 -0700 |
| commit | 683de05f8708a43aabde961329b56b83cd856e31 (patch) | |
| tree | 62aafe9358921b39df19cfda0343fb05e9a866e0 /lib/filter.c | |
| parent | 43fdf718a25be053d6e36c8d0aecfaddc2a155cf (diff) | |
Fix bugs reported by coverity scan
1. Fix useless call in bgpd/bgp_mplsvpn.c
Coverity scan ID : 1302528. Calling "decode_label(pnt)" is only useful
for its return value, which is
ignored. Removed the call.
2. Fix logically dead code in lib/stream.c
Coverity Scan ID 1302488. Test for size==0 makes no sense, since assert
immediately before it
would not let this code happen.
3. Fix Free Pointer dereference in lib/filter.c
Coverity Scan ID 23056. access is accessed after free in
access_list_delete
Diffstat (limited to 'lib/filter.c')
| -rw-r--r-- | lib/filter.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/filter.c b/lib/filter.c index ae50e6cbe0..0eeb8f1872 100644 --- a/lib/filter.c +++ b/lib/filter.c @@ -496,13 +496,13 @@ access_list_filter_delete (struct access_list *access, struct filter *filter) filter_free (filter); route_map_notify_dependencies(access->name, RMAP_EVENT_FILTER_DELETED); - /* If access_list becomes empty delete it from access_master. */ - if (access_list_empty (access)) - access_list_delete (access); - /* Run hook function. */ if (master->delete_hook) (*master->delete_hook) (access); + + /* If access_list becomes empty delete it from access_master. */ + if (access_list_empty (access)) + access_list_delete (access); } /* |