diff options
| author | Quentin Young <qlyoung@cumulusnetworks.com> | 2019-02-26 20:26:54 +0000 |
|---|---|---|
| committer | Quentin Young <qlyoung@cumulusnetworks.com> | 2019-02-26 20:50:17 +0000 |
| commit | eb266ecb847b70bcf9901da5ed59a39d3e07fd8f (patch) | |
| tree | 07a355a6ab20a762db0264f87caa5c5082232a5b | |
| parent | aab9a0a0cb3f75d37bd81588c65d4232def1c8d5 (diff) | |
nhrpd: strncpy -> strlcpy
strncpy is a byte copy function not a string copy function
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
| -rw-r--r-- | nhrpd/linux.c | 2 | ||||
| -rw-r--r-- | nhrpd/vici.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/nhrpd/linux.c b/nhrpd/linux.c index 85e941e7ba..bb5ce0fec6 100644 --- a/nhrpd/linux.c +++ b/nhrpd/linux.c @@ -110,7 +110,7 @@ static int linux_configure_arp(const char *iface, int on) { struct ifreq ifr; - strncpy(ifr.ifr_name, iface, IFNAMSIZ - 1); + strlcpy(ifr.ifr_name, iface, sizeof(ifr.ifr_name)); if (ioctl(nhrp_socket_fd, SIOCGIFFLAGS, &ifr)) return -1; diff --git a/nhrpd/vici.c b/nhrpd/vici.c index 3de4609a2b..fab99588c8 100644 --- a/nhrpd/vici.c +++ b/nhrpd/vici.c @@ -550,7 +550,7 @@ int sock_open_unix(const char *path) memset(&addr, 0, sizeof(struct sockaddr_un)); addr.sun_family = AF_UNIX; - strncpy(addr.sun_path, path, sizeof(addr.sun_path) - 1); + strlcpy(addr.sun_path, path, sizeof(addr.sun_path)); ret = connect(fd, (struct sockaddr *)&addr, sizeof(addr.sun_family) + strlen(addr.sun_path)); |