diff options
| author | Paul Jakma <paul@opensourcerouting.org> | 2014-10-09 16:05:15 +0100 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2016-05-29 20:47:42 -0400 |
| commit | 93559b99b0215e57476ca10d623cfbb4058a1db2 (patch) | |
| tree | a9c3ee6f0c7cdbf8f82912b86996f04dd1febcbe | |
| parent | a3da12a80c21edf9db000c6458c351148adae8ae (diff) | |
ospfd: Tweak previous iface RR write patch to avoid free/malloc & redundant log
* linklist.{c,h}: (listnode_move_to_tail) new unction to move a
listnode to tail of list.
* ospf_packet.c: (ospf_write) remove debug that seemed to be mostly covered
by existing debug.
Use listnode_move_to_tail to just move the list node to the end of the
tail, rather than freeing the one to hand and allocing a new one.
| -rw-r--r-- | lib/linklist.c | 7 | ||||
| -rw-r--r-- | lib/linklist.h | 1 |
2 files changed, 8 insertions, 0 deletions
diff --git a/lib/linklist.c b/lib/linklist.c index 370b2fa615..4b16f07dd1 100644 --- a/lib/linklist.c +++ b/lib/linklist.c @@ -159,6 +159,13 @@ listnode_add_after (struct list *list, struct listnode *pp, void *val) list->count++; } +/* Move given listnode to tail of the list */ +void +listnode_move_to_tail (struct list *l, struct listnode *n) +{ + LISTNODE_DETACH(l,n); + LISTNODE_ATTACH(l,n); +} /* Delete specific date pointer from the list. */ void diff --git a/lib/linklist.h b/lib/linklist.h index 88f4a03912..6209c8b9d6 100644 --- a/lib/linklist.h +++ b/lib/linklist.h @@ -68,6 +68,7 @@ extern void list_free (struct list *); extern void listnode_add (struct list *, void *); extern void listnode_add_sort (struct list *, void *); extern void listnode_add_after (struct list *, struct listnode *, void *); +extern void listnode_move_to_tail (struct list *, struct listnode *); extern void listnode_delete (struct list *, void *); extern struct listnode *listnode_lookup (struct list *, void *); extern void *listnode_head (struct list *); |