summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDonald Sharp <sharpd@cumulusnetworks.com>2019-11-01 10:10:10 -0400
committerDonald Sharp <sharpd@cumulusnetworks.com>2019-11-01 10:11:13 -0400
commit889a75be0d99cb62609cd1ebba28328d452282d6 (patch)
treed7fa242e0b43faed63659848bfaa5c91cc48a397
parentf149ebd9a764ce786eda6242d3b395bf07a3415c (diff)
pimd: Do not spew a million warnings
We have a zlog_warn that is unguarded ( and really is a debug message ) as that there is nothing the end user can do and nothing to note here other than a debug message to track refcounts. Change to an appropriate debug and zlog_debug it instead. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
-rw-r--r--pimd/pim_ifchannel.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/pimd/pim_ifchannel.c b/pimd/pim_ifchannel.c
index 66e64cefa0..4ca38f10d1 100644
--- a/pimd/pim_ifchannel.c
+++ b/pimd/pim_ifchannel.c
@@ -191,11 +191,13 @@ void pim_ifchannel_delete(struct pim_ifchannel *ch)
pim_upstream_del(pim_ifp->pim, ch->upstream,
__PRETTY_FUNCTION__);
- else
- zlog_warn("%s: Avoiding deletion of upstream with ref_count %d "
- "from ifchannel(%s): %s", __PRETTY_FUNCTION__,
- ch->upstream->ref_count, ch->interface->name,
- ch->sg_str);
+ else {
+ if (PIM_DEBUG_PIM_TRACE)
+ zlog_debug("%s: Avoiding deletion of upstream with ref_count %d "
+ "from ifchannel(%s): %s", __PRETTY_FUNCTION__,
+ ch->upstream->ref_count, ch->interface->name,
+ ch->sg_str);
+ }
ch->upstream = NULL;