diff options
| author | Philippe Guibert <philippe.guibert@6wind.com> | 2024-04-05 13:52:27 +0200 |
|---|---|---|
| committer | Mergify <37929162+mergify[bot]@users.noreply.github.com> | 2024-11-11 08:27:19 +0000 |
| commit | 862a15da9b176b324aa85c15f0eb8b4f10ebbf1b (patch) | |
| tree | 7695205e79d08ef2ba7e4db4e1d5d982a4837468 | |
| parent | 30129152c1eaca9aae8a9db1dfe0c72dccb02e67 (diff) | |
bgpd: remove useless control checks about TCP connection
When attempting to get the src and destination addresses of a given
connection, the API may return the NULL pointer, but further code
in bgp_zebra_nexthop_set() already does a check about the given
pointer.
Relaxing the error code for all the returned adressing.
Fixes: 1ff9a340588a ("bgpd: bgpd-fsm-fix.patch")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
(cherry picked from commit ba7130309954fbe8d58854339ca43259149e603a)
| -rw-r--r-- | bgpd/bgp_network.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c index dbb34b048f..b409cbe706 100644 --- a/bgpd/bgp_network.c +++ b/bgpd/bgp_network.c @@ -875,11 +875,7 @@ int bgp_getsockname(struct peer *peer) } peer->su_local = sockunion_getsockname(peer->connection->fd); - if (!peer->su_local) - return -1; peer->su_remote = sockunion_getpeername(peer->connection->fd); - if (!peer->su_remote) - return -1; if (!bgp_zebra_nexthop_set(peer->su_local, peer->su_remote, &peer->nexthop, peer)) { |