summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDonald Sharp <donaldsharp72@gmail.com>2025-02-19 07:22:03 -0500
committerGitHub <noreply@github.com>2025-02-19 07:22:03 -0500
commit66434fc2eea13c83b60f46212e85d33d03ec9c3d (patch)
tree118227f87f977fbcf6327ad209fabec1077b99bf
parent23fc4ce666b7e71df1256709c8646bc26327f439 (diff)
parent44fe3981ee388f7c60ab2635309bce34774116e1 (diff)
Merge pull request #18108 from opensourcerouting/fix/zebra_no_vni_validation
zebra: Do not flush an existing vni configuration trying to remove wrong vni
-rw-r--r--zebra/zebra_cli.c28
1 files changed, 24 insertions, 4 deletions
diff --git a/zebra/zebra_cli.c b/zebra/zebra_cli.c
index bb79928326..8b2eab3f5d 100644
--- a/zebra/zebra_cli.c
+++ b/zebra/zebra_cli.c
@@ -2355,12 +2355,32 @@ DEFPY_YANG (vni_mapping,
"VNI-ID\n"
"prefix-routes-only\n")
{
- if (!no)
+ const struct lyd_node *dnode;
+ const char *vrf;
+
+ if (!no) {
nb_cli_enqueue_change(vty, "./frr-zebra:zebra/l3vni-id", NB_OP_MODIFY,
vni_str);
- else
- nb_cli_enqueue_change(vty, "./frr-zebra:zebra/l3vni-id", NB_OP_DESTROY,
- NULL);
+ } else {
+ if (vty->node == CONFIG_NODE) {
+ if (yang_dnode_existsf(vty->candidate_config->dnode,
+ "/frr-vrf:lib/vrf[name='%s']/frr-zebra:zebra[l3vni-id='%lu']",
+ VRF_DEFAULT_NAME, vni))
+ nb_cli_enqueue_change(vty, "./frr-zebra:zebra/l3vni-id",
+ NB_OP_DESTROY, NULL);
+ } else {
+ dnode = yang_dnode_get(vty->candidate_config->dnode, VTY_CURR_XPATH);
+ if (dnode) {
+ vrf = yang_dnode_get_string(dnode, "name");
+
+ if (yang_dnode_existsf(vty->candidate_config->dnode,
+ "/frr-vrf:lib/vrf[name='%s']/frr-zebra:zebra[l3vni-id='%lu']",
+ vrf, vni))
+ nb_cli_enqueue_change(vty, "./frr-zebra:zebra/l3vni-id",
+ NB_OP_DESTROY, NULL);
+ }
+ }
+ }
if (filter)
nb_cli_enqueue_change(vty, "./frr-zebra:zebra/prefix-only",