summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDonald Sharp <donaldsharp72@gmail.com>2023-10-12 15:58:08 -0400
committerGitHub <noreply@github.com>2023-10-12 15:58:08 -0400
commit202a0f7c217979668fed8bb602f1e18dab61693c (patch)
tree92ff4ee7a7063297cdc3206222040db7f4d9bb83
parented262d0fb159b5caf510ac442985d581cfe9e3b2 (diff)
parent4e365c5c86abb49349f4851f5c6fb05a5cc2cb3c (diff)
Merge pull request #14578 from opensourcerouting/fix/coverity_1566808
bgpd: Remove redundant check for bgp against NULL
-rw-r--r--bgpd/bgp_mplsvpn.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/bgpd/bgp_mplsvpn.c b/bgpd/bgp_mplsvpn.c
index 138b182718..c3e870ee9d 100644
--- a/bgpd/bgp_mplsvpn.c
+++ b/bgpd/bgp_mplsvpn.c
@@ -1225,8 +1225,9 @@ leak_update(struct bgp *to_bgp, struct bgp_dest *bn,
new->extra->vrfleak->parent = bgp_path_info_lock(parent);
bgp_dest_lock_node(
(struct bgp_dest *)parent->net);
- if (bgp_orig)
- new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);
+
+ new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);
+
if (nexthop_orig)
new->extra->vrfleak->nexthop_orig = *nexthop_orig;