[MISC] Add missing CLI suite test (#1607)

* [MISC] Add missing CLI suite test

* Add missing test for `authelia version` command in CLI suite.
* Standardise logger calls and swap CSP switch order

1 files changed, 5 insertions, 3 deletions

diff --git a/internal/server/error_handler.go b/internal/server/error_handler.go
index bc1254f30..0d7c2c18a 100644
--- a/internal/server/error_handler.go
+++ b/internal/server/error_handler.go
@@ -10,17 +10,19 @@ import (
 
 // Replacement for the default error handler in fasthttp.
 func autheliaErrorHandler(ctx *fasthttp.RequestCtx, err error) {
+	logger := logging.Logger()
+
 	if _, ok := err.(*fasthttp.ErrSmallBuffer); ok {
 		// Note: Getting X-Forwarded-For or Request URI is impossible for ths error.
-		logging.Logger().Tracef("Request was too large to handle from client %s. Response Code %d.", ctx.RemoteIP().String(), fasthttp.StatusRequestHeaderFieldsTooLarge)
+		logger.Tracef("Request was too large to handle from client %s. Response Code %d.", ctx.RemoteIP().String(), fasthttp.StatusRequestHeaderFieldsTooLarge)
 		ctx.Error("Request header too large", fasthttp.StatusRequestHeaderFieldsTooLarge)
 	} else if netErr, ok := err.(*net.OpError); ok && netErr.Timeout() {
 		// TODO: Add X-Forwarded-For Check here.
-		logging.Logger().Tracef("Request timeout occurred while handling from client %s: %s. Response Code %d.", ctx.RemoteIP().String(), ctx.RequestURI(), fasthttp.StatusRequestTimeout)
+		logger.Tracef("Request timeout occurred while handling from client %s: %s. Response Code %d.", ctx.RemoteIP().String(), ctx.RequestURI(), fasthttp.StatusRequestTimeout)
 		ctx.Error("Request timeout", fasthttp.StatusRequestTimeout)
 	} else {
 		// TODO: Add X-Forwarded-For Check here.
-		logging.Logger().Tracef("An unknown error occurred while handling a request from client %s: %s. Response Code %d.", ctx.RemoteIP().String(), ctx.RequestURI(), fasthttp.StatusBadRequest)
+		logger.Tracef("An unknown error occurred while handling a request from client %s: %s. Response Code %d.", ctx.RemoteIP().String(), ctx.RequestURI(), fasthttp.StatusBadRequest)
 		ctx.Error("Error when parsing request", fasthttp.StatusBadRequest)
 	}
 }