diff options
| author | Amir Zarrinkafsh <nightah@me.com> | 2020-04-22 13:33:14 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-22 13:33:14 +1000 |
| commit | 54694c4fca6c43e292fa55ffd03cb01c0e485f62 (patch) | |
| tree | 3a4c985cb77328735c9246fc63e28f6746482586 /internal/handlers/handler_verify_test.go | |
| parent | fca190dedc597a524db7eb61321891e88e411b39 (diff) | |
[MISC] Ignore errcheck recommendations for legacy code (#893)
* [MISC] Ignore errcheck recommendations for legacy code
Some of this is likely intended to stay how it is, some could use refactoring, for now we will mark is and ignore it from the linter to be potentially addressed in the future.
* [MISC] Ensure files are gofmt-ed
Diffstat (limited to 'internal/handlers/handler_verify_test.go')
| -rw-r--r-- | internal/handlers/handler_verify_test.go | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/internal/handlers/handler_verify_test.go b/internal/handlers/handler_verify_test.go index 3c86258cf..1e391eb3f 100644 --- a/internal/handlers/handler_verify_test.go +++ b/internal/handlers/handler_verify_test.go @@ -447,7 +447,7 @@ func TestShouldVerifyAuthorizationsUsingSessionCookie(t *testing.T) { userSession := mock.Ctx.GetSession() userSession.Username = testCase.Username userSession.AuthenticationLevel = testCase.AuthenticationLevel - mock.Ctx.SaveSession(userSession) + mock.Ctx.SaveSession(userSession) //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. mock.Ctx.Request.Header.Set("X-Original-URL", testCase.URL) @@ -481,7 +481,7 @@ func TestShouldDestroySessionWhenInactiveForTooLong(t *testing.T) { userSession.Username = "john" userSession.AuthenticationLevel = authentication.TwoFactor userSession.LastActivity = clock.Now().Add(-1 * time.Hour).Unix() - mock.Ctx.SaveSession(userSession) + mock.Ctx.SaveSession(userSession) //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. mock.Ctx.Request.Header.Set("X-Original-URL", "https://two-factor.example.com") @@ -509,7 +509,7 @@ func TestShouldDestroySessionWhenInactiveForTooLongUsingDurationNotation(t *test userSession.Username = "john" userSession.AuthenticationLevel = authentication.TwoFactor userSession.LastActivity = clock.Now().Add(-1 * time.Hour).Unix() - mock.Ctx.SaveSession(userSession) + mock.Ctx.SaveSession(userSession) //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. mock.Ctx.Request.Header.Set("X-Original-URL", "https://two-factor.example.com") @@ -535,7 +535,7 @@ func TestShouldKeepSessionWhenUserCheckedRememberMeAndIsInactiveForTooLong(t *te userSession.AuthenticationLevel = authentication.TwoFactor userSession.LastActivity = clock.Now().Add(-1 * time.Hour).Unix() userSession.KeepMeLoggedIn = true - mock.Ctx.SaveSession(userSession) + mock.Ctx.SaveSession(userSession) //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. mock.Ctx.Request.Header.Set("X-Original-URL", "https://two-factor.example.com") @@ -560,7 +560,7 @@ func TestShouldKeepSessionWhenInactivityTimeoutHasNotBeenExceeded(t *testing.T) userSession.Username = "john" userSession.AuthenticationLevel = authentication.TwoFactor userSession.LastActivity = clock.Now().Add(-1 * time.Second).Unix() - mock.Ctx.SaveSession(userSession) + mock.Ctx.SaveSession(userSession) //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. mock.Ctx.Request.Header.Set("X-Original-URL", "https://two-factor.example.com") @@ -579,7 +579,7 @@ func TestShouldURLEncodeRedirectionURLParameter(t *testing.T) { userSession := mock.Ctx.GetSession() userSession.Username = "john" userSession.AuthenticationLevel = authentication.NotAuthenticated - mock.Ctx.SaveSession(userSession) + mock.Ctx.SaveSession(userSession) //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. mock.Ctx.Request.Header.Set("X-Original-URL", "https://two-factor.example.com") mock.Ctx.Request.SetHost("mydomain.com") |