diff options
| author | James Elliott <james-d-elliott@users.noreply.github.com> | 2020-03-01 11:51:11 +1100 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-01 11:51:11 +1100 | 
| commit | 898f2a807e9a0ef33179d4e3f43c4560b5ec21a9 (patch) | |
| tree | 8b1d9bdea548402cab8618b9dd6b0595914730df /internal/handlers/handler_sign_duo_test.go | |
| parent | b5a9e0f0470c229882e3a8bb33478c85b6e40442 (diff) | |
[MISC] Add Detailed DUO Push Logging (#664)
* [MISC] Add Detailed DUO Push Logging
- Added trace logging for all response data from the DUO API
- Added warning messages on auth failures
- Added debug logging when DUO auth begins
- Updated mocks/unit tests to use the AutheliaCtx as required
Diffstat (limited to 'internal/handlers/handler_sign_duo_test.go')
| -rw-r--r-- | internal/handlers/handler_sign_duo_test.go | 16 | 
1 files changed, 8 insertions, 8 deletions
diff --git a/internal/handlers/handler_sign_duo_test.go b/internal/handlers/handler_sign_duo_test.go index e0d8202cd..2d0629333 100644 --- a/internal/handlers/handler_sign_duo_test.go +++ b/internal/handlers/handler_sign_duo_test.go @@ -44,7 +44,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldCallDuoAPIAndAllowAccess() {  	response := duo.Response{}  	response.Response.Result = "allow" -	duoMock.EXPECT().Call(gomock.Eq(values)).Return(&response, nil) +	duoMock.EXPECT().Call(gomock.Eq(values), s.mock.Ctx).Return(&response, nil)  	s.mock.Ctx.Request.SetBodyString("{\"targetURL\": \"https://target.example.com\"}") @@ -66,7 +66,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldCallDuoAPIAndDenyAccess() {  	response := duo.Response{}  	response.Response.Result = "deny" -	duoMock.EXPECT().Call(gomock.Eq(values)).Return(&response, nil) +	duoMock.EXPECT().Call(gomock.Eq(values), s.mock.Ctx).Return(&response, nil)  	s.mock.Ctx.Request.SetBodyString("{\"targetURL\": \"https://target.example.com\"}") @@ -85,7 +85,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldCallDuoAPIAndFail() {  	values.Set("device", "auto")  	values.Set("pushinfo", "target%20url=https://target.example.com") -	duoMock.EXPECT().Call(gomock.Eq(values)).Return(nil, fmt.Errorf("Connnection error")) +	duoMock.EXPECT().Call(gomock.Eq(values), s.mock.Ctx).Return(nil, fmt.Errorf("Connnection error"))  	s.mock.Ctx.Request.SetBodyString("{\"targetURL\": \"https://target.example.com\"}") @@ -100,7 +100,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldRedirectUserToDefaultURL() {  	response := duo.Response{}  	response.Response.Result = "allow" -	duoMock.EXPECT().Call(gomock.Any()).Return(&response, nil) +	duoMock.EXPECT().Call(gomock.Any(), s.mock.Ctx).Return(&response, nil)  	s.mock.Ctx.Configuration.DefaultRedirectionURL = "http://redirection.local" @@ -120,7 +120,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldNotReturnRedirectURL() {  	response := duo.Response{}  	response.Response.Result = "allow" -	duoMock.EXPECT().Call(gomock.Any()).Return(&response, nil) +	duoMock.EXPECT().Call(gomock.Any(), s.mock.Ctx).Return(&response, nil)  	bodyBytes, err := json.Marshal(signDuoRequestBody{})  	s.Require().NoError(err) @@ -136,7 +136,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldRedirectUserToSafeTargetURL() {  	response := duo.Response{}  	response.Response.Result = "allow" -	duoMock.EXPECT().Call(gomock.Any()).Return(&response, nil) +	duoMock.EXPECT().Call(gomock.Any(), s.mock.Ctx).Return(&response, nil)  	bodyBytes, err := json.Marshal(signDuoRequestBody{  		TargetURL: "https://mydomain.local", @@ -156,7 +156,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldNotRedirectToUnsafeURL() {  	response := duo.Response{}  	response.Response.Result = "allow" -	duoMock.EXPECT().Call(gomock.Any()).Return(&response, nil) +	duoMock.EXPECT().Call(gomock.Any(), s.mock.Ctx).Return(&response, nil)  	bodyBytes, err := json.Marshal(signDuoRequestBody{  		TargetURL: "http://mydomain.local", @@ -174,7 +174,7 @@ func (s *SecondFactorDuoPostSuite) TestShouldRegenerateSessionForPreventingSessi  	response := duo.Response{}  	response.Response.Result = "allow" -	duoMock.EXPECT().Call(gomock.Any()).Return(&response, nil) +	duoMock.EXPECT().Call(gomock.Any(), s.mock.Ctx).Return(&response, nil)  	bodyBytes, err := json.Marshal(signDuoRequestBody{  		TargetURL: "http://mydomain.local",  | 
