diff options
| author | James Elliott <james-d-elliott@users.noreply.github.com> | 2020-04-04 10:11:33 +1100 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-04 10:11:33 +1100 | 
| commit | 626f5d29492cf7ece02fae393c50d924df32f280 (patch) | |
| tree | 63ae3b582aa24e6a01bf9cf33313475c6818fafd /internal/handlers/handler_configuration_test.go | |
| parent | 4fcaff7c4b79e946c4662d6794bfb1e8ac9a4097 (diff) | |
[FEATURE] Remember Me Configuration (#813)
* [FEATURE] Remember Me Configuration
* allow users to specify the duration of remember me using remember_me_duration in session config
* setting the duration to 0 disables remember me
* only render the remember me element if remember me is enabled
* prevent malicious users from faking remember me functionality in the backend
* add string to duration helper called ParseDurationString to parse a string into a duration
* added tests to the helper function
* use the SessionProvider to store the time.Duration instead of parsing it over and over again
* add sec doc, adjust month/min, consistency
* renamed internal/utils/constants.go to internal/utils/const.go to be consistent
* added security measure docs
* adjusted default remember me duration to be 1 month instead of 1 year
* utilize default remember me duration in the autheliaCtx mock
* adjust order of keys in session configuration examples
* add notes on session security measures secret only being redis 
* add TODO items for duration notation for both Expiration and Inactivity (will be removed soon)
* fix error text for Inactivity in the validator 
* add session validator tests
* deref check bodyJSON.KeepMeLoggedIn and derive the value based on conf and user input and store it (DRY)
* remove unnecessary regex for the simplified ParseDurationString utility
* ParseDurationString only accepts decimals without leading zeros now
* comprehensively test all unit types
* remove unnecessary type unions in web
* add test to check sanity of time duration consts, this is just so they can't be accidentally changed
* simplify deref check and assignment
* fix reset password padding/margins
* adjust some doc wording
* adjust the handler configuration suite test
* actually run the handler configuration suite test (whoops)
* reduce the number of regex's used by ParseDurationString to 1, thanks to Clement
* adjust some error wording
Diffstat (limited to 'internal/handlers/handler_configuration_test.go')
| -rw-r--r-- | internal/handlers/handler_configuration_test.go | 25 | 
1 files changed, 25 insertions, 0 deletions
diff --git a/internal/handlers/handler_configuration_test.go b/internal/handlers/handler_configuration_test.go index a01e42f61..a5189241c 100644 --- a/internal/handlers/handler_configuration_test.go +++ b/internal/handlers/handler_configuration_test.go @@ -1,8 +1,11 @@  package handlers  import ( +	"github.com/authelia/authelia/internal/configuration/schema"  	"github.com/authelia/authelia/internal/mocks" +	"github.com/authelia/authelia/internal/session"  	"github.com/stretchr/testify/suite" +	"testing"  )  type ConfigurationSuite struct { @@ -22,11 +25,33 @@ func (s *ConfigurationSuite) TearDownTest() {  func (s *ConfigurationSuite) TestShouldReturnConfiguredGATrackingID() {  	GATrackingID := "ABC"  	s.mock.Ctx.Configuration.GoogleAnalyticsTrackingID = GATrackingID +	s.mock.Ctx.Configuration.Session.RememberMeDuration = schema.DefaultSessionConfiguration.RememberMeDuration  	expectedBody := ConfigurationBody{  		GoogleAnalyticsTrackingID: GATrackingID, +		RememberMeEnabled:         true,  	}  	ConfigurationGet(s.mock.Ctx)  	s.mock.Assert200OK(s.T(), expectedBody)  } + +func (s *ConfigurationSuite) TestShouldDisableRememberMe() { +	GATrackingID := "ABC" +	s.mock.Ctx.Configuration.GoogleAnalyticsTrackingID = GATrackingID +	s.mock.Ctx.Configuration.Session.RememberMeDuration = "0" +	s.mock.Ctx.Providers.SessionProvider = session.NewProvider( +		s.mock.Ctx.Configuration.Session) +	expectedBody := ConfigurationBody{ +		GoogleAnalyticsTrackingID: GATrackingID, +		RememberMeEnabled:         false, +	} + +	ConfigurationGet(s.mock.Ctx) +	s.mock.Assert200OK(s.T(), expectedBody) +} + +func TestRunHandlerConfigurationSuite(t *testing.T) { +	s := new(ConfigurationSuite) +	suite.Run(t, s) +}  | 
