diff options
| author | Clement Michaud <clement.michaud34@gmail.com> | 2019-12-08 23:21:55 +0100 |
|---|---|---|
| committer | Clément Michaud <clement.michaud34@gmail.com> | 2019-12-09 13:03:12 +0100 |
| commit | 26798cdf3ab2b5a404419d07095f040a88b89b71 (patch) | |
| tree | c866c858a6a636ec6bf5a3747d38a4a5812d2e8b /internal/configuration/validator/authentication_test.go | |
| parent | 31776d2d946623893dedb2b634b32938eda5a5bb (diff) | |
Add a check for enclosing parenthesis in LDAP users and groups filters.
Diffstat (limited to 'internal/configuration/validator/authentication_test.go')
| -rw-r--r-- | internal/configuration/validator/authentication_test.go | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/internal/configuration/validator/authentication_test.go b/internal/configuration/validator/authentication_test.go index 0b9b40b65..c0a97e518 100644 --- a/internal/configuration/validator/authentication_test.go +++ b/internal/configuration/validator/authentication_test.go @@ -120,6 +120,20 @@ func (suite *LdapAuthenticationBackendSuite) TestShouldSetDefaultMailAttribute() assert.Equal(suite.T(), "mail", suite.configuration.Ldap.MailAttribute) } +func (suite *LdapAuthenticationBackendSuite) TestShouldRaiseWhenUsersFilterDoesNotContainEnclosingParenthesis() { + suite.configuration.Ldap.UsersFilter = "cn={0}" + ValidateAuthenticationBackend(&suite.configuration, suite.validator) + assert.Len(suite.T(), suite.validator.Errors(), 1) + assert.EqualError(suite.T(), suite.validator.Errors()[0], "The users filter should contain enclosing parenthesis. For instance cn={0} should be (cn={0})") +} + +func (suite *LdapAuthenticationBackendSuite) TestShouldRaiseWhenGroupsFilterDoesNotContainEnclosingParenthesis() { + suite.configuration.Ldap.UsersFilter = "cn={0}" + ValidateAuthenticationBackend(&suite.configuration, suite.validator) + assert.Len(suite.T(), suite.validator.Errors(), 1) + assert.EqualError(suite.T(), suite.validator.Errors()[0], "The users filter should contain enclosing parenthesis. For instance cn={0} should be (cn={0})") +} + func (suite *LdapAuthenticationBackendSuite) TestShouldAdaptLDAPURL() { assert.Equal(suite.T(), "", validateLdapURL("127.0.0.1", suite.validator)) require.Len(suite.T(), suite.validator.Errors(), 1) |