diff options
| author | Amir Zarrinkafsh <nightah@me.com> | 2020-04-22 13:33:14 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-22 13:33:14 +1000 |
| commit | 54694c4fca6c43e292fa55ffd03cb01c0e485f62 (patch) | |
| tree | 3a4c985cb77328735c9246fc63e28f6746482586 /internal/authentication/ldap_user_provider_test.go | |
| parent | fca190dedc597a524db7eb61321891e88e411b39 (diff) | |
[MISC] Ignore errcheck recommendations for legacy code (#893)
* [MISC] Ignore errcheck recommendations for legacy code
Some of this is likely intended to stay how it is, some could use refactoring, for now we will mark is and ignore it from the linter to be potentially addressed in the future.
* [MISC] Ensure files are gofmt-ed
Diffstat (limited to 'internal/authentication/ldap_user_provider_test.go')
| -rw-r--r-- | internal/authentication/ldap_user_provider_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/internal/authentication/ldap_user_provider_test.go b/internal/authentication/ldap_user_provider_test.go index fb5841d99..3c5032ec3 100644 --- a/internal/authentication/ldap_user_provider_test.go +++ b/internal/authentication/ldap_user_provider_test.go @@ -149,7 +149,7 @@ func TestShouldEscapeUserInput(t *testing.T) { Search(NewSearchRequestMatcher("(|(uid=john\\=abc)(mail=john\\=abc))")). Return(&ldap.SearchResult{}, nil) - ldapClient.getUserProfile(mockConn, "john=abc") + ldapClient.getUserProfile(mockConn, "john=abc") //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. } func TestShouldCombineUsernameFilterAndUsersFilter(t *testing.T) { @@ -174,7 +174,7 @@ func TestShouldCombineUsernameFilterAndUsersFilter(t *testing.T) { Search(NewSearchRequestMatcher("(&(uid=john)(&(objectCategory=person)(objectClass=user)))")). Return(&ldap.SearchResult{}, nil) - ldapClient.getUserProfile(mockConn, "john") + ldapClient.getUserProfile(mockConn, "john") //nolint:errcheck // TODO: Legacy code, consider refactoring time permitting. } func createSearchResultWithAttributes(attributes ...*ldap.EntryAttribute) *ldap.SearchResult { |