[CI] Add gocritic linter (#977)

* [CI] Add gocritic linter

* Implement gocritic recommendations
The outstanding recommendations are due to be addressed in #959 and #971 respectively.

* Fix implementation tests

* Fix remaining linting issues.

* Fix tests.

Co-authored-by: Clément Michaud <clement.michaud34@gmail.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/internal/authentication/file_user_provider.go b/internal/authentication/file_user_provider.go
index bbfa9da90..90b2083d6 100644
--- a/internal/authentication/file_user_provider.go
+++ b/internal/authentication/file_user_provider.go
@@ -149,11 +149,13 @@ func (p *FileUserProvider) UpdatePassword(username string, newPassword string) e
 	}
 
 	var algorithm CryptAlgo
-	if p.configuration.Password.Algorithm == "argon2id" {
+
+	switch p.configuration.Password.Algorithm {
+	case argon2id:
 		algorithm = HashingAlgorithmArgon2id
-	} else if p.configuration.Password.Algorithm == sha512 {
+	case sha512:
 		algorithm = HashingAlgorithmSHA512
-	} else {
+	default:
 		return errors.New("Invalid algorithm in configuration. It should be `argon2id` or `sha512`")
 	}