From ea13baa9af4cff1c2dbc096a757b4c0a94afaa56 Mon Sep 17 00:00:00 2001 From: Gabriel Goller Date: Thu, 11 Sep 2025 17:33:54 +0200 Subject: frr: print task warning when frr reload fails Instead of just printing a normal warning, use log_warn, which adds a warning to the whole task. This means the whole task ends with a "warning" status which is visible nicely in the task list. Previously we just printed a warning, which made the task end with "OK" even if the reload failed. frr-reload.py only fails if it's not installed (where a warning status is ok) or the configuration is not valid (where a warning status is also ok). Having frr-reload.py uninstalled for some reason and always relying on `systemctl restart frr` to reload the sdn config is kinda weird and you probably deserve to get a warning on each sdn apply task. Signed-off-by: Gabriel Goller Link: https://lore.proxmox.com/20250911153359.278834-1-g.goller@proxmox.com --- src/PVE/Network/SDN/Frr.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm index b548e7b..b607b32 100644 --- a/src/PVE/Network/SDN/Frr.pm +++ b/src/PVE/Network/SDN/Frr.pm @@ -70,7 +70,7 @@ sub apply { eval { reload() }; return if !$@; - warn "reloading frr configuration failed: $@"; + log_warn("reloading frr configuration failed: $@"); warn "trying to restart frr instead"; } -- cgit v1.2.3