From 7d67b9ff28d09de58c632f80ef7d330e45e698f6 Mon Sep 17 00:00:00 2001 From: Igor Ryzhov Date: Wed, 11 Oct 2023 00:15:32 +0300 Subject: build: add -Wimplicit-fallthrough Also: - replace all /* fallthrough */ comments with portable fallthrough; pseudo keyword to accomodate both gcc and clang - add missing break; statements as required by older versions of gcc - cleanup some code to remove unnecessary fallthrough Signed-off-by: Igor Ryzhov --- zebra/zebra_rib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'zebra/zebra_rib.c') diff --git a/zebra/zebra_rib.c b/zebra/zebra_rib.c index c05d69a2dd..79f6ad484c 100644 --- a/zebra/zebra_rib.c +++ b/zebra/zebra_rib.c @@ -4082,7 +4082,6 @@ static void _route_entry_dump_nh(const struct route_entry *re, ifp ? ifp->name : "Unknown"); break; case NEXTHOP_TYPE_IPV4: - /* fallthrough */ case NEXTHOP_TYPE_IPV4_IFINDEX: inet_ntop(AF_INET, &nexthop->gate, nhname, INET6_ADDRSTRLEN); break; @@ -5043,7 +5042,7 @@ struct route_table *rib_tables_iter_next(rib_tables_iter_t *iter) iter->vrf_id = VRF_DEFAULT; iter->afi_safi_ix = -1; - /* Fall through */ + fallthrough; case RIB_TABLES_ITER_S_ITERATING: iter->afi_safi_ix++; -- cgit v1.2.3