From 07679ad98ab97a4b783f7ae54f88d4d70a5729de Mon Sep 17 00:00:00 2001 From: Igor Ryzhov Date: Sun, 8 Aug 2021 22:38:50 +0300 Subject: *: explicitly print "exit" at the end of every node config There is a possibility that the same line can be matched as a command in some node and its parent node. In this case, when reading the config, this line is always executed as a command of the child node. For example, with the following config: ``` router ospf network 193.168.0.0/16 area 0 ! mpls ldp discovery hello interval 111 ! ``` Line `mpls ldp` is processed as command `mpls ldp-sync` inside the `router ospf` node. This leads to a complete loss of `mpls ldp` node configuration. To eliminate this issue and all possible similar issues, let's print an explicit "exit" at the end of every node config. This commit also changes indentation for a couple of existing exit commands so that all existing commands are on the same level as their corresponding node-entering commands. Fixes #9206. Signed-off-by: Igor Ryzhov --- lib/routemap_cli.c | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/routemap_cli.c') diff --git a/lib/routemap_cli.c b/lib/routemap_cli.c index 77455d991a..8747c37f16 100644 --- a/lib/routemap_cli.c +++ b/lib/routemap_cli.c @@ -125,6 +125,7 @@ void route_map_instance_show(struct vty *vty, struct lyd_node *dnode, void route_map_instance_show_end(struct vty *vty, struct lyd_node *dnode) { + vty_out(vty, "exit\n"); vty_out(vty, "!\n"); } -- cgit v1.2.3