summaryrefslogtreecommitdiff
path: root/zebra
AgeCommit message (Collapse)Author
2020-03-06zebra: nhg->nexthop is not NULLDonald Sharp
We have already asserted on nhg->nexthop an if statement to flog_err makes no sense. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-03-06*: Finish off the __PRETTY_FUNCTION__ to __func__Donald Sharp
FINISH IT Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-03-05Merge pull request #5916 from mjstapp/fix_gmtimeQuentin Young
*: use gmtime_r exclusively
2020-03-05Merge pull request #5918 from ton31337/fix/__func__everywhereQuentin Young
__func__ everywhere
2020-03-05*: use gmtime_r, localtime_r exclusivelyMark Stapp
Stop using gmtime() or localtime() everywhere. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-03-05*: Replace __PRETTY_FUNCTION__/__FUNCTION__ to __func__Donatas Abraitis
Just keep the code cool. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-03-05Merge pull request #5856 from pguibert6WIND/nhrp_override_fixMark Stapp
zebra: when FIB_OVERRIDE flag is set, update nexthop-tracking clients properly
2020-03-05Merge pull request #5914 from mjstapp/fix_sa_show_allDonald Sharp
zebra: clean up an SA warning in show_ip_route_all
2020-03-05zebra: when override flag is set, do not forget to update nhtPhilippe Guibert
this flag can be used when one routing daemon wants to force his route to be injected prioritary with other routes, including selected routes. for that, do not forget to update the new_selected pointer in the zebra nexthop tracking algorithm. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2020-03-05zebra: clean up an SA warning in show_ip_route_allMark Stapp
SA reports a redundant NULL check; remove it. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-03-04Merge pull request #5850 from Spantik/gr_fixQuentin Young
Zebra: Zebra gr dynamic client handling
2020-03-04Merge pull request #5907 from ton31337/fix/replace_sizeof_coccinelleQuentin Young
Bool related stuff
2020-03-04zebra: fix typo in debug log messageRuben Kerkhof
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
2020-03-04*: Use short version of bool expressionsDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-03-03Merge pull request #5886 from sworleys/Trust-Kernel-Direct-RoutesMark Stapp
zebra: trust directly connected kernel/system routes
2020-03-03Merge pull request #5873 from mjstapp/zebra_lsp_dtorDonald Sharp
zebra: add a free api for LSPs
2020-03-03Merge pull request #5890 from mjstapp/zapi_allow_label_numRuss White
zebra: allow multiple labels in LSP zapi message
2020-03-02zebra: allow multiple labels in LSP zapi messageMark Stapp
The handlers for a couple of the main LSP-oriented zapi messages explicitly limited themselves to a single out-label. Allow multiple labels if the sender ... sends them. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-03-02zebra: trust directly connected kernel/system routesStephen Worley
We made the decision to explicitly trust kernel and system routes of every other type with 058c16b7e239f1c50a1d4b4376a6aff6b8dad959. So, we should trust directly connected routes the same way, assuming the interface exists. Old Behavior: K 2.2.2.1/32 [0/0] is directly connected, unknown inactive, 00:00:39 New Behavior: K>* 2.2.2.1/32 [0/0] is directly connected, test1, 00:00:03 As a bonus, this fixes the issues we were seeing with not removing directly connected routes of certain interface types when those interfaces go down/are deleted. Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2020-03-02Merge pull request #5780 from chiragshah6/evpn_dev1Sri Mohana Singamsetty
zebra:remote vtep delete handling
2020-03-02zebra: add a free api for LSPsMark Stapp
consolidate some LSP cleanup code into a common free function. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-28Merge pull request #5874 from donaldsharp/hash_backet2Mark Stapp
*: change hash_backet to hash_bucket
2020-02-28*: change hash_backet to hash_bucketDonald Sharp
It's been a year search and destroy. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-28zebra: fix nexthop_group conversion in fpm codeMark Stapp
Recent commit that embedded the nhg_hash_entry's group missed a couple of fpm modules. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-28Merge pull request #5859 from donaldsharp/clang_latestMark Stapp
Clean up clang latest SA warnings
2020-02-27Merge pull request #5857 from mjstapp/embed_nhg_in_nheStephen Worley
zebra,lib: Embed lib nexthop-group in zebra hash entry
2020-02-27zebra: Embed lib nexthop-group in zebra hash entryMark Stapp
Embed nexthop-group, which is just a pointer, in the zebra nexthop-hash-entry object, rather than mallocing one. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-27Revert "*: change hash_backet to hash_bucket"Jafar Al-Gharaibeh
This reverts commit 3895c42a2eb534a70ef25412547e798c1c1ef5a1. LabN CI update needs to be coordinated before merging this Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2020-02-27zebra: Cleanup set but unused variablesDonald Sharp
There existed some variables set but never used. Clean this up. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-26*: change hash_backet to hash_bucketDonald Sharp
It's been a year search and destroy. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-25Merge pull request #5771 from pguibert6WIND/show_route_table_protocolDonald Sharp
vty: add command to get route with table, vrf and protocol
2020-02-21Zebra: Zebra gr dynamic client handling.Santosh P K
When a client connects to zebra with GR capabilities and then restarts, it might disconnect again even before hello is sent leading zebra cores. GR should be supported only for dynamic neighbor who are capable of restarting. Signed-off-by: Santosh P K <sapk@vmware.com>
2020-02-19zebra: remove null check before XFREE in GR codeQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-19zebra: reduce scope of XCALLOC for gr processingQuentin Young
Somewhat gnarly code flow here that might be leaking memory - can't tell if it's a test artifact or not, but in any case this reduces the situations in which we need to alloc a block. And we don't need to check XCALLOC for success... And we don't need to null check before XFREE... Or set XFREE'd pointers to NULL... Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-19Merge pull request #5837 from ↵Donatas Abraitis
qlyoung/fix-zapi-pbr-unsupported-ip-family-log-message-newline zebra: remove \n in zapi pbr family log msg
2020-02-19zebra: remove \n in zapi pbr family log msgQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-19Merge pull request #5830 from mjstapp/fix_rtadv_stubsDonald Sharp
zebra: fix missing rtadv stub functions
2020-02-19Merge pull request #5809 from donaldsharp/vrf_nameDonatas Abraitis
Print out vrf name as well as id
2020-02-18zebra: fix missing rtadv stub functionsMark Stapp
Add in a few missing stub route-advert functions; these are needed to build frr with v6 route adverts disabled. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-18Merge pull request #5823 from donaldsharp/irdp_whatMark Stapp
Irdp build and log fixes
2020-02-18Merge pull request #5651 from AnuradhaKaruppiah/evpn-pim-fixesPhilippe Guibert
EVPN-PIM: complete anycast (MLAG) VTEP support
2020-02-18Merge pull request #5813 from mjstapp/zapi_labels_use_nhDonald Sharp
*: encode zapi labels message using nexthops
2020-02-18zebra: Fix checksum calculation to not include old checksumDonald Sharp
As part of checksum calculation for a received packet we were comparing the checksum returned from in_cksum. Typically when we calculate the checksum the value stored in the checksum must be all 0's. Store the received checksum and then set the checksum to 0 and then compare. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-18zebra: Fix zlog_debug -> flog_err for error situations in IRDPDonald Sharp
In several places we would send debug messages for failure situations that really should be errors. Signed-off-by: Donald Sharpd <sharpd@cumulusnetworks.com>
2020-02-18zebra: SO_BROADCAST needs a uint32_t instead of a uint8_tDonald Sharp
Using SO_BROADCAST, in the linux kernel, requires a uint32_t to be passed in for all SOL_SOCKET calls. Modify code to use it. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-14*: encode zapi labels message using nexthopsMark Stapp
Use the zapi_nexthop struct with the mpls_labels zapi messages instead of the special-purpose (and more limited) nexthop struct that was being used. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-14zebra: mlag debug was not being persistedAnuradha Karuppiah
Added the mlag keyword to the config level also (in addition to the view level). Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
2020-02-14zebra: add all ipv6 global addresses to RA messagesDon Slice
RFC 4861 states that ipv6 RA messages sent out an interface should contain all global ipv6 addresses on that interface. This fix adds that capability. To override the default flags and timer settings for a particular prefix, the existing "ipv6 nd prefix ..." command should be used via vtysh under the appropriate interface. Ticket: CM-20363 Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
2020-02-14zebra: Add vrf name to debug outputDonald Sharp
The vrf id is insufficient of a discriminator in people's head Give them what they need. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-13*: Remove break after returnDonatas Abraitis
Just a deadcode. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>