summaryrefslogtreecommitdiff
path: root/tests
AgeCommit message (Collapse)Author
2021-07-01Merge pull request #8871 from opensourcerouting/msdp-peer-reworkDonald Sharp
pimd: rework MSDP peer and add tests
2021-06-30Merge pull request #8943 from idryzhov/build-warnQuentin Young
tests: fix build warning
2021-06-29Merge pull request #8887 from LabNConsulting/chopps/fix-test-retriesQuentin Young
2021-06-29tests: fix build warningIgor Ryzhov
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-28tests: Include evpn in bgp-default-afi-safi.pyTrey Aspelund
Expands "bgp default" tests to include l2vpn evpn in addition to ipv4/ipv6 unicast. Signed-off-by: Trey Aspelund <taspelund@nvidia.com>
2021-06-28tests: rename bgp_default_ipv4_ipv6 to _afi_safiTrey Aspelund
Replaces the ipv4/ipv6-specific naming with generic afi/safi reference. Signed-off-by: Trey Aspelund <taspelund@nvidia.com>
2021-06-25topotests: bump MSDP mesh group test wait timeRafael Zalamena
On a loaded machine running FRR with ASAN I've got the following result: INFO: waiting MSDP connection from peer 10.254.254.3 on router r1 INFO: 'router_json_cmp' polling started (interval 1 secs, maximum 30 tries) INFO: 'router_json_cmp' succeeded after 22.53 seconds Which is very close to the limit, so lets bump the value 4x to avoid a test false positive. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-25topotests: topology to test MSDP peersRafael Zalamena
Test the following items: - Multicast route installation - MSDP peering/SA/RPF Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-25tests: apply KISS to retry fixtureChristian Hopps
This python fixture was way too complex for what is needed. Eliminate gratuitous options/over-engineering: - Change from non-deterministic `wait` and `attempts` to a single `retry_timeout` value. This is both more deterministic, as well as what the user should actually be thinking about. - Use a fixed 2 second pause between executing the wrapped function rather than a bunch of arbitrary choices of 2, 3 and 4 seconds spread all over the test code. - Get rid of the multiple variables for determining what "Positive" and "Negative" results are. Instead just implement what all the user code already wants, i.e., boolean False or a str (errormsg) means "Negative" result otherwise it's a "Positive" result. - As part of the above the inversion logic is much more comprehensible in the fixture code (and more correct to boot). Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-25tests: fix pylint cleanup damageChristian Hopps
Pylint cleanup in commit 914faab594 removed a crucial function parameter that inverted the logic of verify function calls. Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-24tests: Fix generate support bundle issue for test_route_map_topo1Kuldeep Kashyap
1. There was a false condition, which was causing support bundle to be generated. Issue is fixed. Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2021-06-24Merge pull request #8912 from gpnaveen/ospf_asbr_summaryRuss White
tests: Adding ospfv2 summarisation test cases.
2021-06-23tests: Adding ospfv2 summarisation test cases.nguggarigoud
Total cases 6. Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
2021-06-23Merge pull request #8860 from ton31337/fix/aspath_prepend_default-originateDonald Sharp
bgpd: Allow aspath prepending for default-originate with route-maps
2021-06-23Merge pull request #8901 from ton31337/feature/bgp_default_route_originate_matchDonald Sharp
tests: Add an additional conditional BGP default route advertisement
2021-06-23Merge pull request #6695 from adharkar/frr-master-gateway_ipPatrick Ruddy
EVPN route type-5 gateway IP overlay Index
2021-06-22Merge pull request #8725 from pjdruddy/ospfv3_fair_socketRuss White
OSPFv3 socket rework
2021-06-22tests: Add an additional conditional BGP default route advertisementDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-22tests: Check if as-path prepends work with route-maps and default-originateDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2021-06-19Merge pull request #8868 from ranjanyash54/redistribute_fixDonald Sharp
ospf6d: redistribute command minor fixes
2021-06-18tests: use correct metric type and value for OSPFv3 redistributed routesIgor Ryzhov
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-18Merge pull request #8843 from idryzhov/isis-dyn-hostname-cacheDonald Sharp
isisd: per-instance dynamic hostname cache
2021-06-18tests: Modify topotests to include write-multiplier configPat Ruddy
Modify both the default and vrf ospf6 topologies to include a test where write-multiplier is configured to a non-default value and the ospf6 neighbors are reset then checked. Run black on both test files. Signed-off-by: Pat Ruddy <pat@voltanet.io>
2021-06-16Merge pull request #8856 from LabNConsulting/chopps/topo-valgrindQuentin Young
2021-06-16tests: add valgrind memleaks run options and detectionChristian Hopps
Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-15tests: Adding ospfv3 basic functionality test casesnguggarigoud
1. Adding APIs to configure and verify ospfv3. 2. Adding ospfv3 base functionality testcase. Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
2021-06-15Merge pull request #8814 from kuldeepkash/topojson_frameworkMartin Winter
tests: Fixing common pylint error for topojson
2021-06-11isisd: per-instance dynamic hostname cacheIgor Ryzhov
Currently, the dynamic hostname cache is global. It is incorrect because neighbors in different VRFs may have the same system ID and different hostnames. This also fixes a memory leak - when the instance is deleted, the cache must be cleaned up and the cleanup thread must be cancelled. Fixes #8832. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-10Merge pull request #8561 from opensourcerouting/msdp-refactor-v2Donald Sharp
pimd: rework MSDP mesh groups
2021-06-10Merge pull request #8733 from idryzhov/ipv6-ospf6-areaRafael Zalamena
ospf6d: fix interface area configuration
2021-06-10Merge pull request #8754 from louis-oui/bgp-summary-filterDonatas Abraitis
bgpd: improve show bgp summary display
2021-06-09topotests: new test topology for MSDPRafael Zalamena
Add basic topology test for MSDP meshed groups. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-09topotests: support adding hostsRafael Zalamena
Add API to topogen so we can build topology with simple hosts instead of routers. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-06-08tests: replace "interface IFNAME area" with "ipv6 ospf6 area"Igor Ryzhov
Only one test is modified yet, to have both new and deprecated commands tested by the CI. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-08tests: fix ospf6_topo1_vrfIgor Ryzhov
ospf6d (and all other daemons except zebra) doesn't correctly process `interface X vrf Y`, because it doesn't know existing VRFs at the time of configuration file reading. Therefore it doesn't apply configuration provided in the interface node. Fix the problem by removing `vrf Y` part, having just an interface name is enough. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-06-08Merge pull request #7096 from gpnaveen/ospf_asbr_summarisationOlivier Dugeon
tests : Adding 2 ospf asbr summary testcases.
2021-06-08Merge pull request #8727 from opensourcerouting/ospfv3-nssaRuss White
ospf6d: implement NSSA area support
2021-06-08Merge pull request #8713 from LabNConsulting/chopps/grpc-unit-testQuentin Young
2021-06-08bgpd: add terse display option on show bgp summaryLouis Scalbert
Add a terse option to show bgp summary to shorten output. Do not show the following information about the BGP instances: the number of RIB entries, the table version and the used memory. The "terse" option can be used in combination with the "remote-as", "neighbor", "failed" and "established" filters, and with the "wide" option as well. Before patch: ubuntu# show bgp summary remote-as 123456 IPv4 Unicast Summary (VRF default): BGP router identifier X.X.X.X, local AS number XXX vrf-id 0 BGP table version 0 RIB entries 3, using 552 bytes of memory Peers 5, using 3635 KiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt Desc 10.200.200.2 4 123456 81432 4 0 56092 0 00:00:13 572106 0 N/A Displayed neighbors 1 Total number of neighbors 4 IPv6 Unicast Summary (VRF default): BGP router identifier X.X.X.X, local AS number XXX vrf-id 0 BGP table version 0 RIB entries 3, using 552 bytes of memory Peers 5, using 3635 KiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt Desc % No matching neighbor Total number of neighbors 5 After patch: ubuntu# show bgp summary remote-as 123456 terse IPv4 Unicast Summary (VRF default): BGP router identifier X.X.X.X, local AS number XXX vrf-id 0 Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt Desc 10.200.200.2 4 123456 81432 4 0 56092 0 00:00:13 572106 0 N/A Displayed neighbors 1 Total number of neighbors 4 IPv6 Unicast Summary (VRF default): BGP router identifier X.X.X.X, local AS number XXX vrf-id 1 % No matching neighbor Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2021-06-08bgpd: add counter of displayed show bgp summary when filteringLouis Scalbert
When filtering sessions on show bgp summary with failed, established, neighbor and remote-as options, add a counter of displayed neighbors in addition to the total number of neighbor : "Displayed neighbors X" ubuntu# show bgp summary failed remote-as external IPv4 Unicast Summary (VRF default): Neighbor EstdCnt DropCnt ResetTime Reason 10.200.200.2 0 0 never Waiting for NHT 172.16.29.2 0 0 never Waiting for NHT 10.22.1.2 0 0 never Waiting for NHT Displayed neighbors 3 Total number of neighbors 5 Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2021-06-08bgpd: display pretty VRF/view name on no such neighborLouis Scalbert
Display on which VRF/view the neighbor was not found. Useful when selecting "vrf all". Before patch: No such neighbor in this view/vrf After patch: No such neighbor in VRF default Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2021-06-07tests: Fixing common pylint error for topojsonKuldeep Kashyap
Issue: There was an error reported by Pylint regarding "expected" keyword: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg) Fix: We have defined expected keyword in all topojson APIs. Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2021-06-07tests: Topotest for BGP EVPN Overlay Index Gateway IP featureAmeya Dharkar
Following functionality is covered: +--------+ BGP +--------+ BGP +--------+ +--------+ SN1 | | IPv4/v6 | | EVPN | | | | ======+ Host1 +---------+ PE1 +------+ PE2 +------+ Host2 + | | | | | | | | +--------+ +--------+ +--------+ +--------+ Host1 is connected to PE1 and host2 is connected to PE2 Host1 and PE1 have IPv4/v6 BGP sessions. PE1 and PE2 gave EVPN session. Host1 advertises IPv4/v6 prefixes to PE1. PE1 advertises these prefixes to PE2 as EVPN type-5 routes. Gateway IP for these EVPN type-5 routes is host1 IP. Host1 MAC/IP is advertised by PE1 as EVPN type-2 route Following testcases are covered: TC_1: Check BGP and zebra states for above topology at PE1 and PE2. TC_2: Stop advertising prefixes from host1. It should withdraw type-5 routes. Check states at PE1 and PE2 Advertise the prefixes again. Check states. TC_3: Shut down VxLAN interface at PE1. This should withdraw type-2 routes. Check states at PE1 and PE2. Enable VxLAN interface again. Check states. Signed-off-by: Ameya Dharkar <adharkar@vmware.com>
2021-06-07tests: timing large config operationsChristian Hopps
To start we use 10k static route config. This test goes along with recent batching changes it will fail w/o them (b/c some operations w/o batching take 100 times as long). This test should be added to over time for other large config items (e.g., acl, policy, etc) Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-07Merge pull request #8756 from volta-networks/ospfd_sr_blocksOlivier Dugeon
ospfd, doc: combined SRGB/SRLB command
2021-06-06tests: add grpc unit testChristian Hopps
Test uses staticd which required some C++ header protections. Additionally, the test also runs in the ubuntu20 docker container as grpc is supported there by the packaging system. Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-04Merge pull request #5865 from slankdev/slankdev-zebra-srv6-managerMark Stapp
zebra: srv6 manager
2021-06-04ospfd, doc, tests: combined SRGB/SRLB commandEmanuele Di Pascale
similarly to what was done for IS-IS in commit 01d43141, combine the SRGB and SRLB commands for OSPF-SR, so that we can replace overlapping ranges in one sweep change. Also allow the range configuration to be stored before SR is enabled. There is no reason why we should not - in fact that constraint meant that we were always requesting the default label ranges regardless of what we actually wanted to use. Finally, update the topotests now that we do not need to refresh the SRGB/SRLB/MSD after disabling SR. Note that the prefix-sid still needs to be re-added. Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2021-06-04bgpd: modify VRF/view display in show bgp summaryLouis Scalbert
Modify VRF/view display in show bgp summary: - to be more concise - to display on which VRF/view no neighbor was found Before patch: ubuntu# show bgp vrf all summary Instance default: IPv4 Unicast Summary: BGP router identifier XX.XX.XX.XX, local AS number XXXX vrf-id 0 (...) IPv6 Unicast Summary: Instance private: IPv4 Unicast Summary: ubuntu# show bgp vrf all ipv4 multicast summary % No BGP neighbors found % No BGP neighbors found After patch: ubuntu# show bgp vrf all summary IPv4 Unicast Summary (VRF default): BGP router identifier XX.XX.XX.XX, local AS number XXXX vrf-id 0 (...) IPv6 Unicast Summary (VRF default): (...) IPv4 Unicast Summary (VRF private): (...) ubuntu# show bgp vrf all ipv4 multicast summary % No BGP neighbors found in VRF default % No BGP neighbors found in VRF private Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2021-06-04topotests: remove uneccessary vtysh cmd requestLouis Scalbert
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>