summaryrefslogtreecommitdiff
path: root/tests/topotests
AgeCommit message (Collapse)Author
2025-03-28tests: Use label 0x800000 instead of 0x000000 for BMP testsmergify/bp/stable/10.3/pr-18502Donatas Abraitis
Related-to: 94e2aadf7187d7d695babce21033b5bc8e454f25 ("bgpd: Set the label for MP_UNREACH_NLRI 0x800000 instead of 0x000000") Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org> (cherry picked from commit e69459c7144568381c05bbaf962adecd914975d5)
2025-03-27Revert "tests: Add test case to verify SRv6 SID modify"Donatas Abraitis
This reverts commit 8f1313392f70ff2e7e8f924e238564879d5e3aeb.
2025-03-24tests: Add test case to verify SRv6 SID modifyCarmine Scarpitta
This commit adds a test case that modifies a SID and verifies that the RIB is as expected. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit 23403e01a3ece0b206bc8acf36c08b4bb538cb79)
2025-03-23bgpd: fix evpn attributes being dropped on inputmergify/bp/stable/10.3/pr-18378Tuetuopay
All assignments of the EVPN attributes (ESI and Gateway IP) are gated behind the peer being set up for inbound soft-reconfiguration. There are no actual reasons for this limitation, so let's perform the EVPN attribute assignment no matter what when soft reconfiguration is not enabled. Fixes: 6e076ba5231 ("bgpd: Fix for ain->attr corruption during path update") Signed-off-by: Tuetuopay <tuetuopay@me.com> (cherry picked from commit 7320659f78cbe86dd983d5101831120fc14583d7)
2025-03-23tests: add route-map evpn set gateway-ip topotestTuetuopay
This test does not actually look at the route since the gateway-ip is not exposed in vtysh output. However, this ensures such a route-map does not crash bgpd. Signed-off-by: Tuetuopay <tuetuopay@me.com> (cherry picked from commit 05a74323b9d440590074f22be11c34a605da69ad)
2025-03-09tests: Have zebra startup look for the zserv.api socketDonald Sharp
Ensure that the zserv.api socket is actually up and running before moving onto other daemons after zebra. Signed-off-by: Donald Sharp <sharpd@nvidia.com> (cherry picked from commit 009f42dd5bd02eb5ee0bd9852704357c6bc7aaa1)
2025-03-09tests: Allow mgmtd and zebra to fully come up before other daemonsDonald Sharp
Currently the topotest infrastructure is starting up daemons in mgmtd,zebra, staticd then everything else. The problem that is happening, under heavy load, is that zebra may not be fully started and when a daemon attempts to connect to it, it will not be able to connect. Some of the daemons do not have great retry mechanisms at all. In addition our normal systemctl startup scripts actually wait a small amount of time for zebra to be ready before moving onto the other daemons. Let's make topotests startup a tiny bit more nuanced and have mgmtd fully up before starting up zebra. Signed-off-by: Donald Sharp <sharpd@nvidia.com> (cherry picked from commit dd609bc069857a38ff3577b76d0b9ef708b8d2aa)
2025-03-06tests: add support for 514 unnumbered/v4/v6 BGP sessionsSoumya Roy
Signed-off-by: Soumya Roy <souroy@nvidia.com> (cherry picked from commit 10ff0d5e4cf08dacf2bf82b2350dac403633e380)
2025-03-06tests: add support for bringimg up 514 BGP neighborsSoumya Roy
Signed-off-by: Soumya Roy <souroy@nvidia.com> (cherry picked from commit fd80124ccab4afed32c09437986ad1347440fc81)
2025-03-06zebra: Bring up 514 BGP neighbor sessionsSoumya Roy
Issue: When 514 inerfaces/neighbors are configured, it creates socket error, "Cannot allocate memory", when back to back V6 RA messages are tried to be sent over the socket. This prevents interface, to know its peer's link local address. Socket error comes when 1) try to join ICMPv6 all router multicast group, back to back for all interfaces 2)send back to back RA for all interfaces Fix: 1)For ICMPv6 join case, we check if the interface has already joined all router group, if not try to join. On failure, retry joining after random amount of time determined 1 ms to ICMPV6_JOIN_TIMER_EXP_MS(100 ms) 2) For RA issue case, batch sending of RA mesages using wheel timer Testing: Monitor BGP session running sh bgp summary command Before fix: r1# sh bgp summary IPv4 Unicast Summary: BGP router identifier 192.168.1.1, local AS number 1001 VRF default vrf-id 0 BGP table version 0 RIB entries 0, using 0 bytes of memory Peers 515, using 12 MiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt Desc r1-eth0 4 1002 89 90 0 0 0 00:07:10 0 0 N/A r1-eth1 4 1002 89 90 0 0 0 00:07:10 0 0 N/A r1-eth2 4 1002 89 90 0 0 0 00:07:10 0 0 N/A r1-eth3 4 1002 89 90 0 0 0 00:07:10 0 0 N/A r1-eth4 4 1002 89 90 0 0 0 00:07:10 0 0 N/A r1-eth5 4 1002 89 90 0 0 0 00:07:10 0 0 N/A …..<snip>... r1-eth252 4 1002 31 29 0 0 0 00:02:08 0 0 N/A r1-eth253 4 1002 31 29 0 0 0 00:02:08 0 0 N/A r1-eth254 4 1002 31 29 0 0 0 00:02:08 0 0 N/A r1-eth255 4 1002 31 29 0 0 0 00:02:08 0 0 N/A r1-eth256 4 0 0 0 0 0 0 never Idle 0 N/A r1-eth257 4 0 0 0 0 0 0 never Idle 0 N/A r1-eth258 4 0 0 0 0 0 0 never Idle 0 N/A r1-eth259 4 0 0 0 0 0 0 never Idle 0 N/A r1-eth260 4 0 0 0 0 0 0 never Idle 0 N/A ……..<snip>….. r1-eth511 4 0 0 0 0 0 0 never Idle 0 N/A r1-eth512 4 0 0 0 0 0 0 never Idle 0 N/A r1-eth513 4 0 0 0 0 0 0 never Idle 0 N/A r1-eth514 4 0 0 0 0 0 0 never Idle 0 N/A After fix: r1# show bgp summary IPv4 Unicast Summary: BGP router identifier 192.168.1.1, local AS number 1001 VRF default vrf-id 0 BGP table version 0 RIB entries 0, using 0 bytes of memory Peers 515, using 12 MiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt Desc r1-eth0 4 1002 87 87 0 0 0 00:07:04 0 0 N/A r1-eth1 4 1002 87 87 0 0 0 00:07:04 0 0 N/A r1-eth2 4 1002 87 87 0 0 0 00:07:04 0 0 N/A r1-eth3 4 1002 64 67 0 0 0 00:05:09 0 0 N/A r1-eth4 4 1002 87 87 0 0 0 00:07:04 0 0 N/A r1-eth5 4 1002 87 87 0 0 0 00:07:04 0 0 N/A r1-eth6 4 1002 67 70 0 0 0 00:05:22 0 0 N/A r1-eth7 4 1002 87 87 0 0 0 00:07:04 0 0 N/A r1-eth8 4 1002 87 87 0 0 0 00:07:04 0 0 N/A .... r1-eth499 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth500 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth501 4 1002 19 22 0 0 0 00:01:21 0 0 N/A r1-eth502 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth503 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth504 4 1002 20 23 0 0 0 00:01:30 0 0 N/A r1-eth505 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth506 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth507 4 1002 22 25 0 0 0 00:01:39 0 0 N/A r1-eth508 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth509 4 1002 17 20 0 0 0 00:01:13 0 0 N/A r1-eth510 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth511 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth512 4 1002 19 22 0 0 0 00:01:22 0 0 N/A r1-eth513 4 1002 43 43 0 0 0 00:03:22 0 0 N/A r1-eth514 4 1002 43 43 0 0 0 00:03:22 0 0 N/A Signed-off-by: Soumya Roy <souroy@nvidia.com> (cherry picked from commit 6a75d33b5cb9f5a87d71d169e24c1ae15e1bd896)
2025-03-03tests: Add test case to verify that SIDs can be re-addedCarmine Scarpitta
Add a test case to verify that staticd is able to re-install all SIDs after disabling and re-enabling SRv6. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit 0e0eca6c5f287c936570a3be50dde120ade1b9b8)
2025-03-03tests: Add test case to verify `no srv6` commandCarmine Scarpitta
Add a test case to verify that staticd removes all SIDs when the `no srv6` command is executed. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit 58373a61d559036990b875bbf0afdc9e92174975)
2025-02-28tests: Add test case to verify that SIDs can be re-addedCarmine Scarpitta
Add a test case to verify that staticd is able to re-install all SIDs after deleting and re-adding them. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit 641f0c6deb483c78a5cf2d69ec5335e5d4e498a5)
2025-02-28tests: Add test case to verify `no static-sids` commandCarmine Scarpitta
Add a test case to verify that staticd removes all SIDs when the `no static-sids` command is executed. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit 303be67e6ab185954b05c16c499a6b258311d897)
2025-02-27tests: check as number in show runLouis Scalbert
Creates the default VRF instance after the other VRF instances. The default VRF instance is created in hidden state. Check that AS number in show run is correctly written. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com> (cherry picked from commit 077a2b0dfc71443b41d5feceb52023c259436956) Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-02-27tests: add bgp_l3vpn_hidden topotestLouis Scalbert
Test that leaving the hidden BGP instance state is working. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com> (cherry picked from commit 118afe4690d5563887c1b2095d18e23cc77a21a2) Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-02-26Merge pull request #18255 from Jafaral/no-bgp-hiddenDonald Sharp
Revert "bgpd: fix default instance when leaving the hidden state (backport 10.3)" #18162
2025-02-25Revert "tests: add bgp_l3vpn_hidden topotest"Jafar Al-Gharaibeh
This reverts commit bb79a6562ffd520329246920597f83ca32e9a468. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2025-02-25Revert "tests: check as number in show run"Jafar Al-Gharaibeh
This reverts commit 85c5598bb95aa2eb17e8f617965affa7de627c69. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
2025-02-24pim: Fix autorp group joinsNathan Bahr
Group joining got broken when moving the autorp socket to open/close as needed. This fixes it so autorp group joining is properly handled as part of opening the socket. Signed-off-by: Nathan Bahr <nbahr@atcorp.com> (cherry picked from commit d840560b74e3a6117aa1e4b1203dcdd8fb254ef6)
2025-02-14tests: check as number in show runLouis Scalbert
Creates the default VRF instance after the other VRF instances. The default VRF instance is created in hidden state. Check that AS number in show run is correctly written. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-02-14tests: add bgp_l3vpn_hidden topotestLouis Scalbert
Test that leaving the hidden BGP instance state is working. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2025-02-13tests: Extend SRv6 static SIDs topotest to verify SID structureCarmine Scarpitta
The `static_srv6_sids` topotest verifies that staticd correctly programs the SIDs in the zebra RIB. Currently, the topotest only validates the programmed behavior and SID attributes. This commit extends the topotest to also validate the SID structure. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit a6d02fe2fb38b8e0c2e1c25fd863f6f96c2c40a6)
2025-02-04tests: Check if the peer stays Idle if router-id is not setDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org> (cherry picked from commit 48560b5c9b8084e903ebf0ef5987b4e581459608)
2025-02-04Merge pull request #17336 from forrestchu/sbfdRuss White
implement SBFD
2025-02-04Merge pull request #17989 from cscarpitta/fix/fix_staticd_no_sidDonatas Abraitis
staticd: Fix wrong xpath in `no sid X:X::X:X/M`
2025-02-03tests: Add test case to verify SID re-addCarmine Scarpitta
Add a new test case that re-add the deleted SIDs and verifies that all SIDs are added back to the RIB. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-02-03tests: Add test case to verify SID deleteCarmine Scarpitta
Add a new test case that deletes a SID and verifies that only this SID has been removed from the RIB. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-02-03Merge pull request #17913 from Sokolmish/bgp-sid-releaseCarmine Scarpitta
bgpd: Release SID on router deletion
2025-01-30tests: Add testcase for static End/uN validationCarmine Scarpitta
This commit adds a testcase to validate static End/uN allocation. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
2025-01-30topotests: Router deletion in SRv6 sid reachabilityMikhail Sokolovskiy
Signed-off-by: Mikhail Sokolovskiy <sokolmish@gmail.com>
2025-01-29Merge pull request #17935 from mjstapp/fix_nhg_hash_equalDonald Sharp
zebra: include resolving nexthops in nhg hash
2025-01-28tests: Add a test that shows the v6 recursive nexthop problemDonald Sharp
Currently FRR does not handle v6 recurisive resolution properly when the route being recursed through changes and the most significant bits of the route are not changed. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2025-01-28Merge pull request #17941 from opensourcerouting/fix-dst-srcRuss White
static: fix botched staticd YANG conversion for dst-src
2025-01-28Merge pull request #17802 from askorichenko/test-fix-table-mapRuss White
bgpd: fix table-map option
2025-01-28Merge pull request #17906 from ↵Russ White
LabNConsulting/aceelindem/ospf-prune-dup-next-hops ospfd: Prune duplicate next-hop when installing into zebra route table.
2025-01-28Merge pull request #17848 from pguibert6WIND/isis_srv6_topo1_pingRuss White
Isis srv6 topo1 ping
2025-01-28Merge pull request #17736 from opensourcerouting/table-directRuss White
bgpd,lib,zebra: permit table-direct on VRFs
2025-01-28topotests: test v6 & dst-src in static_simpleDavid Lamparter
The "static_simple" test has code for testing IPv6 routes, but it wasn't even being run (duh.) Enable it, and also test IPv6 dst-src routes. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2025-01-28staticd: fix botched staticd YANG for dst-srcDavid Lamparter
The staticd YANG conversion completely f*cked up dst-src routes. Stupidly enough, the correct thing is much simpler as seen by the amount of deletes in this commit. This does, unfortunately, involve a rather annoying YANG edge case with what should reasonably be an optional leaf as part of a list key, which is not possible. It uses `::/0` as unconditional filler instead, since that is semantically correct. The `test_yang_mgmt` topotest needed to be adjusted after this to add `src-prefix='::/0'`. Fixes: 88fa5104a04a ("staticd : Configuration northbound implementation") Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2025-01-28bgpd: fix table-map optionAlexander Skorichenko
Schedule zebra to withdraw routes filtered out by a table-map. Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>
2025-01-27Merge pull request #17905 from pguibert6WIND/advertised_routes_incorrect_jsonDonatas Abraitis
Advertised routes incorrect json
2025-01-27Merge pull request #17919 from pguibert6WIND/bgp_suppressed_attributeDonatas Abraitis
Bgp suppressed attribute
2025-01-27topotests: bgp_vpnv4_noretain, check presence of locpref in adj-rib-outPhilippe Guibert
Add a test that check that the detailed command of show bgp advertised neighbors 10.125.0.2 displays the locpref value. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2025-01-27topotests: bgp_aggregate_address_topo1, add test for suppressed keywordPhilippe Guibert
Add a test that checks that the BGP route to 192.168.0.1 has all the necessary json outputs. This route is chosen because it is a suppressed route. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2025-01-25Revert "bgpd: Handle Addpath capability using dynamic capabilities"Donatas Abraitis
This reverts commit 05cf9d03b345393b8d63ffe9345c42debd8362b6. TL;DR; Handling BGP AddPath capability is not trivial (possible) dynamically. When the sender is AddPath-capable and sends NLRIs encoded with AddPath ID, and at the same time the receiver sends AddPath capability "disable-addpath-rx" (flag update) via dynamic capabilities, both peers are out of sync about the AddPath state. The receiver thinks already he's not AddPath-capable anymore, hence it tries to parse NLRIs as non-AddPath, while they are actually encoded as AddPath. AddPath capability itself does not provide (in RFC) any mechanism on backward compatible way to handle NLRIs if they come mixed (AddPath + non-AddPath). This explains why we have failures in our CI periodically. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2025-01-24Merge pull request #17911 from askorichenko/test-fix-bgp-peer-soloDonatas Abraitis
bgpd: Fix bgp peer solo option
2025-01-23topotests: test direct-table on different VRFsRafael Zalamena
Test new zebra feature that allows table-direct to work on any VRF with BGP. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2025-01-23tests: OSPF topotest for next-hop pruningAcee Lindem
OSPF topotest to test OSPF next-hop pruning on installation into zebra routing table. Also fix multicast_pim_dr_nondr_test topotest which had a duplicate OSPF route in the results. Signed-off-by: Acee Lindem <acee@lindem.com> X
2025-01-23bgpd: Fix bgp peer solo optionAlexander Skorichenko
Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>