summaryrefslogtreecommitdiff
path: root/python/clidef.py
AgeCommit message (Collapse)Author
2023-02-21Merge pull request #12248 from pguibert6WIND/bgpasdotRuss White
lib, bgp: add initial support for asdot format
2023-02-10lib, bgp: add initial support for asdot formatPhilippe Guibert
AS number can be defined as an unsigned long number, or two uint16 values separated by a period (.). The possible valus are: - usual 32 bit values : [1;2^32 -1] - <1.65535>.<0.65535> for dot notation - <0.65535>.<0.65535> for dot+ notation. The 0.0 value is forbidden when configuring BGP instances or peer configurations. A new ASN type is added for parsing in the vty. The following commands use that new identifier: - router bgp .. - bgp confederation .. - neighbor <> remote-as <> - neighbor <> local-as <> - clear ip bgp <> - route-map / set as-path <> An asn library is available in lib/ and provides some services: - convert an as string into an as number. - parse an as path list string and extract a number. - convert an as number into a string. Also, the bgp tests forge an as_zero_path, and to do that, an API to relax the possibility to have a 0 as value is specifically called from the tests. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2023-02-09*: auto-convert to SPDX License IDsDavid Lamparter
Done with a combination of regex'ing and banging my head against a wall. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2022-02-28python: improve clippy/clidef macro processingDavid Lamparter
Process macros from the current file, and warn if something is redefined (to a different value). Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2022-01-13python: pass conditionals through clippy for DEFPYDavid Lamparter
Track what conditionals apply when a DEFPY is encountered, and stack them around the autogenerated clippy wrapper. Otherwise conditional DEFPYs result in undefined function warnings. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-10-05isisd: fix redistribute CLIIgor Ryzhov
Currently, it is possible to configure IPv6 protocols for IPv4 redistribution and vice versa in CLI. The YANG model doesn't allow this so the user receives the following error: ``` nfware(config-router)# redistribute ipv4 ospf6 level-1 % Failed to edit configuration. YANG error(s): Invalid enumeration value "ospf6". Invalid enumeration value "ospf6". Invalid enumeration value "ospf6". YANG path: Schema location /frr-isisd:isis/instance/redistribute/ipv4/protocol. ``` Let's make CLI more user-friendly and allow only supported protocols in redistribution commands. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-10-07*: reformat python fileswhitespace
We are now using black. Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2019-08-30bgpd/bmp: BMP implementationDavid Lamparter
This implements BMP. There's no fine-grained history here, the non-BMP preparations are already split out from here so all that remains is BMP proper. Signed-off-by: David Lamparter <equinox@diac24.net>
2019-07-03clippy: find headers relative to source treeDavid Lamparter
The current directory is in the build tree while running clippy; find ourselves so we can access headers from the source tree. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2019-06-12lib/clippy: expand some macrosDavid Lamparter
At least the "easy" cases of macros work. Signed-off-by: David Lamparter <equinox@diac24.net>
2019-06-12lib/clippy: assert() for non-optional argsDavid Lamparter
This is mostly to help static analysis; since we know from the command string which args are optional and which aren't, we can add assert() statements on them. Fixes: #3270 Signed-off-by: David Lamparter <equinox@diac24.net>
2019-06-12lib/clippy: error out on unsupported bitsDavid Lamparter
clippy can't process #ifdef or similar bits inside of an argument list (e.g. within the braces of a DEFUN or DEFPY statement.) Improve error reporting to catch these cases instead of generating broken C code. Fixes: #3840 Signed-off-by: David Lamparter <equinox@diac24.net>
2019-01-21python: make DEFPY provide the text token of fixed parametersRenato Westphal
In the CLI code, each cmd_token has both a "text" field, containing the full token text (e.g. "unicast"), and an "arg" field, containing the original text entered by the user (which might be an abbreviation, like "uni" instead of "unicast"). To avoid the need to handle abbreviations, the recommended pattern for DEFUN commands is to use the "text" value of fixed parameters and the "arg" value of everything else. Using DEFPY, however, the CLI parameters are automagically turned into C variables which are initialized under the hood (so that they're conveniently ready for use). The problem is that this initialization was always using the "arg" value of the parameters, which was leading to problems like these: debian# show ipv6 route isi Unknown route type debian# debian# conf t debian(config)# router isis 1 debian(config-router)# redistribute ipv4 st level-1 % Configuration failed. Invalid value "st" in "protocol" element. YANG path: /frr-isisd:isis/instance[area-tag='1']/redistribute/ipv4[protocol='st']/protocol To fix these problems (and probably others too), make DEFPY commands auto-detect the type of the input parameters and use either the "arg" or "text" value from the cmd_tokens accordingly. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-12-01Revert "isisd lib ospfd pbrd python: fix empty init"David Lamparter
This reverts commit 48944eb65e1d1ced03d46121d923d9d613a480d5. We're using GNU C, not ISO C - and this commit triggers new (real) warnings about {0} instead of bogus ones about {}. Signed-off-by: David Lamparter <equinox@diac24.net>
2018-11-21isisd lib ospfd pbrd python: fix empty initF. Aragon
ISO C forbids empty initializer braces. Empty initializers have been replaced with {0} Signed-off-by: F. Aragon <paco@voltanet.io>
2018-09-08*: fix some solaris warningsDavid Lamparter
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-08-30build: trigger fewer unneccessary clippy rebuildsDavid Lamparter
Make sure we include the clippy binary file in our timestamp mangling so `make` will correctly determine when clippy files don't need to be rebuilt. Signed-off-by: David Lamparter <equinox@diac24.net>
2018-04-10lib, python: DEFPY_ATTR, DEFPY_HIDDENQuentin Young
Add support for element attributes in DEFPY macros. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-10-24zebra: unify the ipv4/ipv6 'show ip route' commands - part 1/2Renato Westphal
Note: I had to remove one assert in clidef.py in order to fix a build error when using a preprocessor string (FRR_IP_REDIST_STR_ZEBRA) inside a DEFPY command. This should be revisited later. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-08-25clippy: disable unneeded autogenerated codeDavid Lamparter
Coverity is generating a lot of warnings about unused stuff being around. Disabling these bits is most easily done by just putting a few preprocessor directives into the template. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-24python/clippy: make output file writing less weirdDavid Lamparter
This should stomp out any parallel build issues in this regard. Fixes: #971 Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-08-14lib, python: add M:A:C support for clippyQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-07-13*: ditch vty_outln(), part 1 of 2David Lamparter
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-06-29*: rebase vty_outln() -> masterQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-06-14python: clidef.pyDavid Lamparter
Adds "DEFPY()" which invokes an additional layer of preprocessing, so that we get pre-parsed and named function arguments for the CLI. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>