summaryrefslogtreecommitdiff
path: root/pimd
AgeCommit message (Collapse)Author
2022-10-05Merge pull request #12017 from patrasar/pimv6_helloDonald Sharp
pimd, pim6d: send secondary address in PIM hello packet
2022-10-05Merge pull request #12013 from SaiGomathiN/11895Donatas Abraitis
pim6d: Adding new Debug CLI for MLD
2022-09-30pimd, pim6d: send secondary address in PIM hello packetSarita Patra
Fixed as per rfc7761 section 4.3.1. """ Sending Hello Messages The Address List option advertises all the secondary addresses associated with the source interface of the router originating the message. The option MUST be included in all Hello messages if there are secondary addresses associated with the source interface and MAY be omitted if no secondary addresses exist. """ Issue: #12015 Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-09-29Merge pull request #12035 from donaldsharp/pim6_write_non_integratedDonatas Abraitis
pimd: Allow v6 to do non-integrated configuration
2022-09-28pimd: Remove some unused defines in pimd.hDonald Sharp
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-28pimd: Assign a vty port value for v6Donald Sharp
Let's use 2620 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27pimd: Allow v6 to do non-integrated configurationDonald Sharp
Proof: eva# conf eva(config)# no service integrated-vtysh-config eva(config)# end eva# wr mem Note: this version of vtysh never writes vtysh.conf Building Configuration... Configuration saved to /etc/frr/zebra.conf Configuration saved to /etc/frr/ripd.conf Configuration saved to /etc/frr/ripngd.conf Configuration saved to /etc/frr/ospfd.conf Configuration saved to /etc/frr/ospf6d.conf Configuration saved to /etc/frr/bgpd.conf Configuration saved to /etc/frr/isisd.conf Configuration saved to /etc/frr/pimd.conf Configuration saved to /etc/frr/nhrpd.conf Configuration saved to /etc/frr/eigrpd.conf Configuration saved to /etc/frr/babeld.conf Configuration saved to /etc/frr/sharpd.conf Configuration saved to /etc/frr/fabricd.conf Configuration saved to /etc/frr/pbrd.conf Configuration saved to /etc/frr/staticd.conf Configuration saved to /etc/frr/bfdd.conf Configuration saved to /etc/frr/vrrpd.conf Configuration saved to /etc/frr/pim6d.conf eva# Fixes: #12011 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2022-09-27pimd: IGMP Querier election is not correct in LAN scenarioMobashshera Rasool
When more than 2 routers are present in LAN and the querier goes down, the other routers will wait for other querier present timer to expire to elect a new querier. This issue will be seen when the router having next lower ip address expires the other querier present timer first and it starts sending the query message. Now on the other non-querier routers it will receive this query and reset its other querier present timer but the querier is still the old one and since it is lowest ip, it never gets updated to the newly elected querier. Reset the other querier timer only if query is received from the previously elected querier or a better new querier This will make sure that non-querier elects the new querier whose ip address is higher than the old querier when the old querier goes down via other querier querier timer expiry Issue: #12027 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-09-26pim6d: Adding last member query count field in "show ipv6 mld interface ↵Abhishek N R
[ifname] json" command. Fixes: #12004 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-26pimd,pim6d: Change the show running commands based on address familySai Gomathi N
Change the show running commands for igmp and mld debug commands based on the address family. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25pim6d: Add 'debug mld trace detail'Sai Gomathi N
Implementing debug mld trace detail for MLD activity. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25pim6d: Add 'debug mld trace'Sai Gomathi N
Implementing mld trace for MLD protocol activity. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25pim6d: Add 'debug mld packets'Sai Gomathi N
Implementing mld packets debug to information about packet generation for sending and about packet handling from a received packet. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25pim6d: Add 'debug mld events'Sai Gomathi N
Implementing debug mld events command for debugging MLD system events. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-25pim6d: Add 'debug mld'Sai Gomathi N
Implementing debug mld command for MLD protocol activity. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-21Merge pull request #11802 from AbhishekNR/ttable_pim_stateDonatas Abraitis
pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim state" command output.
2022-09-21Merge pull request #11918 from patrasar/show_ipv6_mld_interface_fixDonatas Abraitis
pim6d: "show ipv6 mld interface" command
2022-09-20Merge pull request #11958 from AbhishekNR/ttable_showDonatas Abraitis
pimd, pim6d: Using ttable for displaying show command outputs
2022-09-19Merge pull request #11872 from AbhishekNR/const_igmp_gmDonatas Abraitis
pimd, pim6d: Changing IGMP to GM in few macro's.
2022-09-19Merge pull request #11953 from AbhishekNR/issue_11925Donatas Abraitis
pim6d: (*,G) mroutes not learnt after pim6d daemon restart
2022-09-19Merge pull request #11917 from patrasar/pimv6_clear_mroute_fixDonald Sharp
pim6d: fix clear ipv6 mroute crash
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim local-membership" ↵Abhishek N R
command output Before: frr# sh ipv6 pim local-membership Interface Address Source Group Membership ens224 fe80::250:56ff:feb7:9091 * ff08::1 NOINFO After: frr# sh ipv6 pim local-membership Interface Address Source Group Membership ens224 fe80::250:56ff:feb7:9091 * ff08::1 NOINFO Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim neighbor" command ↵Abhishek N R
output. Before: frr# show ipv6 pim neighbor Interface Neighbor Uptime Holdtime DR Pri ens192 fe80::250:56ff:feb7:38de 00:10:47 00:01:28 1 ens224 fe80::250:56ff:feb7:4bad 00:10:47 00:01:28 1 After: frr# sh ipv6 pim neighbor Interface Neighbor Uptime Holdtime DR Pri ens192 fe80::250:56ff:feb7:38de 00:00:12 00:01:32 1 ens224 fe80::250:56ff:feb7:4bad 00:00:12 00:01:32 1 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim join" command outputAbhishek N R
Before: frr# sh ipv6 pim join Interface Address Source Group State Uptime Expire Prune ens224 fe80::250:56ff:feb7:9091 * ff08::1 JOIN 00:16:31 03:28 --:-- After: frr# show ipv6 pim join Interface Address Source Group State Uptime Expire Prune ens224 fe80::250:56ff:feb7:9091 * ff08::1 JOIN 00:00:51 03:27 --:-- Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-18pimd, pim6d: Changing IGMP to GM in few macro's.Abhishek N R
Changing IGMP_DEFAULT_ROBUSTNESS_VARIABLE to GM_DEFAULT_ROBUSTNESS_VARIABLE, IGMP_GENERAL_QUERY_INTERVAL to GM_GENERAL_QUERY_INTERVAL, IGMP_QUERY_MAX_RESPONSE_TIME_DSEC to GM_QUERY_MAX_RESPONSE_TIME_DSEC and IGMP_SPECIFIC_QUERY_MAX_RESPONSE_TIME_DSEC to GM_SPECIFIC_QUERY_MAX_RESPONSE_TIME_DSEC to accomodate both igmp and mld. And moved it to common file. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-17Merge pull request #11955 from mobash-rasool/fixes3Donatas Abraitis
pim6d: Fixing coverity issues for pim6_mld.c
2022-09-16Merge pull request #11900 from patrasar/pimv6_lmqtDonatas Abraitis
pim6d: Update last_member_query_interval and last_member_query_count
2022-09-16pim6d: Fixing coverity issues for pim6_mld.cMobashshera Rasool
CID 1519843 (#2 of 2): Uninitialized scalar variable (UNINIT) 43. uninit_use_in_call: Using uninitialized value pkt_src->sin6_addr when calling gm_rx_process Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-09-16pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim state" command ↵Abhishek N R
output. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-16pim6d: (*,G) mroutes not learnt after pim6d daemon restartAbhishek N R
After restart pim dr address was zero due to which pim (*,G) join could not get propagated towards RP. While trying to find primary address ll_highest will be zero initially, since we have not received address from zebra yet. So we can get the best address at this point and use it as primary address whenever ll_highest is zero. Fixes: #11925 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-15pim6d: fix clear ipv6 mroute crashSarita Patra
Root Cause: "clear ipv6 mroute" was not deleting the subscribers of gm_if structure. Fix: The command "clear ipv6 mroute" deletes grp_pends, gsq_pends, sgs, subscribers, expires of gm_if data structure. Deleted the common code in gm_ifp_teardown() and called gm_group_delete(). Issue: #11724 Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-09-14pimd: Fix memleak in bfd profileMobashshera Rasool
In function pim_if_delete, pim_ifp->bfd_config.profile needs to be freed. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-09-13pimd, pim6d: Changing IGMP to GM in debug macros.Abhishek N R
Changed PIM_DEBUG_IGMP_TRACE to PIM_DEBUG_GM_TRACE and PIM_DEBUG_IGMP_TRACE_DETAIL to PIM_DEBUG_GM_TRACE_DETAIL. Hence, these macros can be used for both v6 and v4. Issue: #11895 Co-authored-by: Sai Gomathi N <nsaigomathi@vmware.com> Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-13pim6d: fix "show ipv6 mld interface" commandSarita Patra
Issue: ===== frr# show ipv6 mld interface All VRFs Fix: === frr# show ipv6 mld interface MLD interface information Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-09-08Merge pull request #11896 from AbhishekNR/issue_11891Donatas Abraitis
pim6d: Adding additional details for "show ipv6 mld interface [ifname] json" command.
2022-09-06pimd: Fixing alignmentSai Gomathi N
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-06pimd, pim6d: Changing IGMP to GM in debug macrosSai Gomathi N
Changing PIM_DO_DEBUG_IGMP_EVENTS to PIM_DO_DEBUG_GM_EVENTS PIM_DO_DEBUG_IGMP_PACKETS to PIM_DO_DEBUG_GM_PACKETS PIM_DO_DEBUG_IGMP_TRACE to PIM_DO_DEBUG_GM_TRACE PIM_DO_DEBUG_IGMP_TRACE_DETAIL to PIM_DO_DEBUG_GM_TRACE_DETAIL PIM_DONT_DEBUG_IGMP_EVENTS to PIM_DONT_DEBUG_GM_EVENTS PIM_DONT_DEBUG_IGMP_PACKETS to PIM_DONT_DEBUG_GM_PACKETS PIM_DONT_DEBUG_IGMP_TRACE to PIM_DONT_DEBUG_GM_TRACE PIM_DONT_DEBUG_IGMP_TRACE_DETAIL to PIM_DONT_DEBUG_GM_TRACE_DETAIL PIM_MASK_IGMP_EVENTS to PIM_MASK_GM_EVENTS PIM_MASK_IGMP_PACKETS to PIM_MASK_GM_PACKETS PIM_MASK_IGMP_TRACE to PIM_MASK_GM_TRACE PIM_MASK_IGMP_TRACE_DETAIL to PIM_MASK_GM_TRACE_DETAIL to be used for both IGMP and MLD debugs. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-05pim6d: Adding additional details for "show ipv6 mld interface [ifname] json" ↵Abhishek N R
command. Added Robustness value, Query interval, Query response timer and Last member query interval field in json output. Issue: #11891 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-04pimd,pim6d: Modifying IGMP to GM in PIM_DEBUG_IGMP_PACKETS to ↵Sai Gomathi N
PIM_DEBUG_GM_PACKETS Changing the macros to common so that it can be used for pimv6 debugs as well to be used for both IGMP and MLD debugs. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-04pimd,pim6d: Modifying IGMP to GM in PIM_DEBUG_IGMP_EVENTS to PIM_DEBUG_GM_EVENTSSai Gomathi N
Changing the macros to common so that it can be used for pimv6 debugs as well to be used for both IGMP and MLD debugs. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-09-04pim6d: Update last_member_query_interval and last_member_query_countSarita Patra
When there is update in the configuration of last_member_query_interval and last_member_query_count, call gm_ifp_update(). This will update cur_query_intv_trig and cur_lmqc of gm_ifp structure. Issue: #11901 Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-09-02pimd: Removal of unused function pim_neighbor_find_prefixMobashshera Rasool
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-08-30pim6d: Fix the Code for MLD in the show pim state commandMobashshera Rasool
show ip pim state should show IGMP Report while show ipv6 pim state should show MLD Report. Output After Fix: frr# do sh ip pim state Codes: J -> Pim Join, I -> IGMP Report, S -> Source, * -> Inherited from (*,G), V -> VxLAN, M -> Muted Active Source Group RPT IIF OIL frr# do sh ipv6 pim state Codes: J -> Pim Join, I -> MLD Report, S -> Source, * -> Inherited from (*,G), V -> VxLAN, M -> Muted Active Source Group RPT IIF OIL frr# Issue: #11249 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-08-29pimd, pim6d: deleting the memory malloced for json.Abhishek N R
Problem Statement: ================= 2022-08-18 04:57:32,376 - ERROR: Found memory leak in daemon pimd 2022-08-18 04:57:32,377 - ERROR: ==12100== 18,978 (144 direct, 18,834 indirect) bytes in 2 blocks are definitely lost in loss record 45 of 45 2022-08-18 04:57:32,377 - ERROR: ==12100== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x532F51F: json_object_new_object (in /lib/x86_64-linux-gnu/libjson-c.so.3.0.1) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x128B5C: pim_show_interfaces (pim_cmd_common.c:3395) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x15A86B: show_ip_pim_interface_magic (pim_cmd.c:3127) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x15A86B: show_ip_pim_interface (pim_cmd_clippy.c:324) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E672B2: cmd_execute_command_real.isra.2 (command.c:1005) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E696FE: cmd_execute_command (command.c:1064) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E698F1: cmd_execute (command.c:1227) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EBC814: vty_command (vty.c:530) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EBC9EF: vty_execute (vty.c:1295) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EBF1F7: vtysh_read (vty.c:2142) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EB739B: thread_call (thread.c:1692) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-08-18 04:57:32,377 - ERROR: ==12100== Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-29Merge pull request #11581 from AbhishekNR/mld_hardcode_valueDonatas Abraitis
pim6d: Completing mld config commands.
2022-08-29Merge pull request #11857 from mobash-rasool/fixes2Donatas Abraitis
pim6d: mroute stuck in register state, multicast traffic getting drops
2022-08-28pim6d: Completing "ipv6 mld last-member-query-interval" commandAbhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-28pim6d: Completing "ipv6 mld last-member-query-count" command.Abhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-28pim6d: Completing "ipv6 mld query-max-response-time" command.Abhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-26Merge pull request #11718 from SaiGomathiN/mldgroupsDonatas Abraitis
pim6d: Implementing "show ipv6 mld groups" CLI
generated by cgit v1.2.3 (git 2.39.1) at 2025-12-09 14:28:30 +0000