summaryrefslogtreecommitdiff
path: root/pimd/pim_cmd_common.c
AgeCommit message (Collapse)Author
2022-10-21pimd, pim6d: Don't configure link-local, Multicast, Unspecified address as RPSarita Patra
Problem: ======= frr(config)# do show ipv6 pim interface Interface State Address PIM Nbrs PIM DR FHR IfChannels ens192 up fe80::250:56ff:feb7:3619 0 local 0 1 Configure ens192 interface link-local address as RP. frr(config)# ipv6 pim rp fe80::250:56ff:feb7:3619 No Path to RP address specified: fe80::250:56ff:feb7:3619 frr(config)# do show ipv6 pim rp-info RP address group/prefix-list OIF I am RP Source Group-Type fe80::250:56ff:feb7:3619 ff00::/8 Unknown yes Static ASM Fix: === RP should not be link-local, multicast and unspecified address. Signed-off-by: Sarita Patra <saritap@vmware.com> (cherry picked from commit aae2af98ca62b17b2bd63e432d65938d7202b9bd)
2022-09-21Merge pull request #11802 from AbhishekNR/ttable_pim_stateDonatas Abraitis
pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim state" command output.
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim local-membership" ↵Abhishek N R
command output Before: frr# sh ipv6 pim local-membership Interface Address Source Group Membership ens224 fe80::250:56ff:feb7:9091 * ff08::1 NOINFO After: frr# sh ipv6 pim local-membership Interface Address Source Group Membership ens224 fe80::250:56ff:feb7:9091 * ff08::1 NOINFO Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim neighbor" command ↵Abhishek N R
output. Before: frr# show ipv6 pim neighbor Interface Neighbor Uptime Holdtime DR Pri ens192 fe80::250:56ff:feb7:38de 00:10:47 00:01:28 1 ens224 fe80::250:56ff:feb7:4bad 00:10:47 00:01:28 1 After: frr# sh ipv6 pim neighbor Interface Neighbor Uptime Holdtime DR Pri ens192 fe80::250:56ff:feb7:38de 00:00:12 00:01:32 1 ens224 fe80::250:56ff:feb7:4bad 00:00:12 00:01:32 1 Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-19pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim join" command outputAbhishek N R
Before: frr# sh ipv6 pim join Interface Address Source Group State Uptime Expire Prune ens224 fe80::250:56ff:feb7:9091 * ff08::1 JOIN 00:16:31 03:28 --:-- After: frr# show ipv6 pim join Interface Address Source Group State Uptime Expire Prune ens224 fe80::250:56ff:feb7:9091 * ff08::1 JOIN 00:00:51 03:27 --:-- Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-09-16pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim state" command ↵Abhishek N R
output. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-30pim6d: Fix the Code for MLD in the show pim state commandMobashshera Rasool
show ip pim state should show IGMP Report while show ipv6 pim state should show MLD Report. Output After Fix: frr# do sh ip pim state Codes: J -> Pim Join, I -> IGMP Report, S -> Source, * -> Inherited from (*,G), V -> VxLAN, M -> Muted Active Source Group RPT IIF OIL frr# do sh ipv6 pim state Codes: J -> Pim Join, I -> MLD Report, S -> Source, * -> Inherited from (*,G), V -> VxLAN, M -> Muted Active Source Group RPT IIF OIL frr# Issue: #11249 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-08-29pimd, pim6d: deleting the memory malloced for json.Abhishek N R
Problem Statement: ================= 2022-08-18 04:57:32,376 - ERROR: Found memory leak in daemon pimd 2022-08-18 04:57:32,377 - ERROR: ==12100== 18,978 (144 direct, 18,834 indirect) bytes in 2 blocks are definitely lost in loss record 45 of 45 2022-08-18 04:57:32,377 - ERROR: ==12100== at 0x4C31FAC: calloc (vg_replace_malloc.c:762) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x532F51F: json_object_new_object (in /lib/x86_64-linux-gnu/libjson-c.so.3.0.1) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x128B5C: pim_show_interfaces (pim_cmd_common.c:3395) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x15A86B: show_ip_pim_interface_magic (pim_cmd.c:3127) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x15A86B: show_ip_pim_interface (pim_cmd_clippy.c:324) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E672B2: cmd_execute_command_real.isra.2 (command.c:1005) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E696FE: cmd_execute_command (command.c:1064) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E698F1: cmd_execute (command.c:1227) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EBC814: vty_command (vty.c:530) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EBC9EF: vty_execute (vty.c:1295) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EBF1F7: vtysh_read (vty.c:2142) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4EB739B: thread_call (thread.c:1692) 2022-08-18 04:57:32,377 - ERROR: ==12100== by 0x4E85B17: frr_run (libfrr.c:1068) 2022-08-18 04:57:32,377 - ERROR: ==12100== Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-24pimd, pim6d: Using ttable for displaying "show ip|ipv6 pim jp-agg" CLISai Gomathi N
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-08-24pimd, pim6d: Using ttable for displaying "show ip|ipv6 pim channel" CLISai Gomathi N
Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-08-18Merge pull request #11830 from AbhishekNR/unused_varDonald Sharp
pimd, pim6d: Removing unused parameter
2022-08-17pimd, pim6d: Removing unused parameterAbhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-16pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim upstream-rpf" ↵Abhishek N R
command output. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-16pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim ↵Abhishek N R
upstream-join-desired" command output. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-14pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim upstream" command ↵Abhishek N R
output. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-14pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim secondary" ↵Abhishek N R
command output Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-14pimd, pim6d: Using ttable for displaying "show ip/ipv6 pim rpf" command output.Abhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-11Merge pull request #11778 from AbhishekNR/ttable_mrouteDonald Sharp
pimd, pim6d: Using ttable for displaying output of show mroute commands
2022-08-11pimd, pim6d: Using ttable for displaying "show ip/ipv6 mroute count" command ↵Abhishek N R
output. Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-10pimd, pim6d: Using ttable for displaying "show ip/ipv6 mroute" command output.Abhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-10pimd, pim6d: Using ttable for displaying "show ip/ipv6 multicast count" command.Abhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-08-08Merge pull request #11720 from SaiGomathiN/pimv6debugfixDonatas Abraitis
pim6d: Add 'show debugging [pimv6]' CLI and some fixes
2022-08-05Merge pull request #11636 from AbhishekNR/clear_cmdDonald Sharp
pim6d: Implementing "clear ipv6 pim interface traffic" command.
2022-08-05Merge pull request #11559 from patrasar/fix_clear_ipv6_mrouteDonald Sharp
pim6d: fix clear ipv6 mroute
2022-08-04Merge pull request #11716 from mobash-rasool/fixes2Donald Sharp
pimd, pim6d: Send register msg via reg socket, solve FHR/RP same node issue
2022-08-04pimd, pim6d: Using ttable for displayingSai Gomathi N
Using termtable for show ip|ipv6 pim interface for dynamic space alignments Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-08-04pimd, pim6d: Send register msg via register socketMobashshera Rasool
The problem here is when the same node is FHR as well as RP, then the node keeps on sending the register packet. Register-stop is not sent as well. This problem has occurred because the RP is the same node and there is no socket created on loopback interface, so the packet is never send out and never received back on the same node, so register recv could not be processed on the node and hence no register-stop is sent. Since register packets are unicast packets, its better to handle the send of register packet via a separate register socket. This fixes the problem mentioned above as well. Fixes: #11331 Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-08-03pim6d: fix clear ipv6 mrouteSarita Patra
Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-08-02pim6d: Change the show running commands for pimv6 debugsSai Gomathi N
Change the show running commands for bsm and vxlan pimv4 and pimv6 debug commands based on the address family. Including bsm and vxlan in no debug pimv6 debug. Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-08-01pim6d: Implementing "clear ipv6 pim interface traffic" command.Abhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-07-19pim6d: Implementing "clear ipv6 pim interfaces" command.Abhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-07-12pimd: Avoid unnecessary vrf lookupSarita Patra
In several places, we are getting the vrf structure using vrf_lookup_by_name(). Again we are passing vrf->vrf_id to pim_get_pim_instance() to get the pim_instance. The API pim_get_pim_instance() again get the VRF structure using vrf_lookup_by_id(). This is avoided in this PR. Signed-off-by: Sarita Patra <saritap@vmware.com>
2022-07-11pimd: Correct the order of show json for interface trafficMobashshera Rasool
"show ip pim interface traffic json" shows pruneTx first and then pruneRx stats where as "show ip pim interface <ifname> json" shows pruneRx first and then pruneTx stats. Although the values are right but the display looks odd. Making it same as other stats, first display Rx and then Tx. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-07-06pimd: Adjust rpf_addr in show commandssarita patra
Signed-off-by: sarita patra <saritap@vmware.com>
2022-06-30pimd, pim6d: Adding json support for show ipv6 nexthopSai Gomathi N
Moving the reusable code of pim_show_nexthop apis to common file pim_cmd_common.c file and adding the json support for show ipv6 pim nexthop Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-24Merge pull request #11242 from patrasar/pimv6_issue_11233Donald Sharp
pim6d: Fixing repeated group source field in show ipv6 mroute
2022-06-24pim6d: Fixing repeated group source field in show ipv6 mroutesarita patra
The command "show ip[v6] mroute" displaying group and source field for every OIL. Fix: Display group and source for the first OIL only. Signed-off-by: sarita patra <saritap@vmware.com>
2022-06-15Merge pull request #11272 from AbhishekNR/flag_removalDonald Sharp
pim6d: Removed PIM_IPV == 4 flag
2022-06-12pimd: Change to DEFPY and make the api commonMobashshera Rasool
For show ip pim interface traffic cli, doing the below changes 1. Changing DEFUN to DEFPY 2. Move the whole code to a common api and modify it so that can be reused for pimv6. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-06-12pim6d: Moving show apis to common fileMobashshera Rasool
Moving pim_show_interface_traffic and pim_show_interface_traffic_single to pim_cmd_common.c from pim_cmd.c to make it common to pimd and pim6d. Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
2022-06-12Merge pull request #11385 from AbhishekNR/show_cliDonald Sharp
pimd, pim6d: Moving reusable code to common api for show CLI's.
2022-06-12Merge pull request #11387 from SaiGomathiN/pimshowDonald Sharp
pimd, pim6d: Moving the reusable code to common api for PIM show CLIs
2022-06-09pim6d: Moving the reusable code of pim_show_join cliSai Gomathi N
Moving the common lines of pim_show_join_vrf and pim_show_join_vrf_all cli in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09pim6d: Moving reusable code to common api for "show mroute summary" commandAbhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09pim6d: Moving reusable code to common api for "show ip/ipv6 mroute count" ↵Abhishek N R
command Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09pim6d: Moving reusable code to common api for "show ip/ipv6 mroute" commandAbhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09pim6d: Moving the common lines of pim_show_nexthop_lookup cliSai Gomathi N
Moving the common lines of pim_show_nexthop_lookup cli in pim_cmd.c and pim6_cmd.c to pim_cmd_common.c file Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2022-06-09pim6d: Moving reusable code to common api for "show ip/ipv6 multicast count" ↵Abhishek N R
command Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09pim6d: Moving reusable code to common api for "show ip/ipv6 multicast" commandAbhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>
2022-06-09pim6d: Moving reusable code to common api for "show pim state" commandAbhishek N R
Signed-off-by: Abhishek N R <abnr@vmware.com>