| Age | Commit message (Collapse) | Author |
|---|
|
Add support to dump sr-te pcep session in json output.
> ubuntu2204# show sr-te pcep session
> PCE q
> PCE IP 192.0.2.40 port 4189
> PCC IP 192.0.2.10 port 4189
> PCC MSD 10
> Session Status UP
> Precedence 10, best candidate
> Confidence normal
> Timer: KeepAlive config 30, pce-negotiated 70
> Timer: DeadTimer config 120, pce-negotiated 120
> Timer: PcRequest 30
> Timer: SessionTimeout Interval 30
> Timer: Delegation Timeout 10
> No TCP MD5 Auth
> PCE SR Version draft07
> Next PcReq ID 5
> Next PLSP ID 2
> Connected for 171 seconds, since 2023-10-28 09:36:44 UTC
> PCC Capabilities: [PCC Initiated LSPs] [Stateful PCE] [SR TE PST]
> PCE Capabilities: [Stateful PCE] [SR TE PST]
> PCEP Message Statistics
> Sent Rcvd
> Message Open: 2 1
> Message KeepAlive: 1 6
> Message PcReq: 4 0
> Message PcRep: 0 0
> Message Notify: 4 0
> Message Error: 0 5
> Message Close: 0 0
> Message Report: 5 0
> Message Update: 0 1
> Message Initiate: 0 0
> Message StartTls: 0 0
> Message Erroneous: 0 0
> Total: 16 13
> PCEP Sessions => Configured 1 ; Connected 1
> ubuntu2204# show sr-te pcep session json
> {
> "pcepSessions":[
> {
> "pceName":"q",
> "pceAddress":"192.0.2.40",
> "pcePort":4189,
> "pccAddress":"192.0.2.10",
> "pccPort":4189,
> "pccMsd":10,
> "sessionStatus":"UP",
> "bestMultiPce":true,
> "precedence":10,
> "confidence":"normal",
> "keepaliveConfig":30,
> "deadTimerConfig":120,
> "pccPcepRequestTimerConfig":30,
> "sessionTimeoutIntervalSec":30,
> "delegationTimeout":10,
> "tcpMd5Authentication":false,
> "draft07":true,
> "draft16AndRfc8408":false,
> "nextPcRequestId":5,
> "nextPLspId":2,
> "sessionKeepalivePceNegotiatedSec":70,
> "sessionDeadTimerPceNegotiatedSec":120,
> "sessionConnectionDurationSec":177,
> "sessionConnectionStartTimeUTC":"2023-10-28 09:36:44",
> "pccCapabilities":" [PCC Initiated LSPs] [Stateful PCE] [SR TE PST]",
> "pceCapabilities":" [Stateful PCE] [SR TE PST]",
> "messageStatisticsReceived":{
> "messageOpen":1,
> "messageKeepalive":6,
> "messagePcReq":0,
> "messagePcRep":0,
> "messageNotify":0,
> "messageError":5,
> "messageClose":0,
> "messageReport":0,
> "messageUpdate":1,
> "messageInitiate":0,
> "messageStartTls":0,
> "messageErroneous":0,
> "total":13
> },
> "messageStatisticsSent":{
> "messageOpen":2,
> "messageKeepalive":1,
> "messagePcReq":4,
> "messagePcRep":0,
> "messageNotify":4,
> "messageError":0,
> "messageClose":0,
> "messageReport":5,
> "messageUpdate":0,
> "messageInitiate":0,
> "messageStartTls":0,
> "messageErrneous":0,
> "total":16
> }
> }
> ],
> "pcepSessionsConfigured":1,
> "pcepSessionsConnected":1
> }
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
|
|
The following message appears after starting pathd:
> root@ubuntu2204:~# vtysh
> 2023/10/31 05:59:10 [K2CCG-5Y7ZJ] Excessive docstring while parsing 'msd (1-32)'
> 2023/10/31 05:59:10 [W7ENN-K2SVA] ----------
> 2023/10/31 05:59:10 [WCW75-6TZPF] PCC maximum SID depth value
> 2023/10/31 05:59:10 [W7ENN-K2SVA] ----------
Remove the excessive doc string in the pcep msd command.
Fixes: d6d2527448ef ("pathd: fix 'no msd' command not possible under pcc node")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
|
|
It should be possible to reset the configured msd value,
and not mentioning the previous msd value.
> ubuntu2204(config-sr-te-pcep-pcc)# no msd
> % Command incomplete: no msd
> ubuntu2204(config-sr-te-pcep-pcc)#
Fix this by defining the msd parameter optional, and
separating the 'no msd' command from the 'msd' command.
Fixe: efba0985fcdd ("pathd: Add optional support for PCEP to pathd")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
|
|
The below running-configuration has extra spaces before the pce
port configuration:
> segment-routing
> traffic-engineering
> pce test
> address ip 192.0.2.2 port 1234
>
Fix this by keeping only one space.
> address ip 192.0.2.2 port 1234
Fixes: efba0985fcdd ("pathd: Add optional support for PCEP to pathd")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
|
|
Rework "debug pathd pcep [...]" command to support the following
configurations:
- configure one debugging log type at a time.
- deconfigure one debugging log type at a time.
- configure all debugging logs in one shot.
- deconfigure all debugging logs in one shot.
Signed-off-by: Farid Mihoub <farid.mihoub@6wind.com>
|
|
Add "no pcep" command in segment-routing/traffic-engineering context
to deconfigure the whole pcep configuration (pce-config, pce and pcc).
Signed-off-by: Farid Mihoub <farid.mihoub@6wind.com>
|
|
Add the "no msd" command to deconfigure pcc/msd node.
Signed-off-by: Farid Mihoub <farid.mihoub@6wind.com>
|
|
Reset the PCC peer connection to take into account new changes of the
PCE options.
Signed-off-by: Farid Mihoub <farid.mihoub@6wind.com>
|
|
Add "no" command for pcep pce/pce-config sub-commands, this will mainly
restart configured options to default values.
Signed-off-by: Farid Mihoub <farid.mihoub@6wind.com>
|
|
Done with a combination of regex'ing and banging my head against a wall.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
Rather than running selected source files through the preprocessor and a
bunch of perl regex'ing to get the list of all DEFUNs, use the data
collected in frr.xref.
This not only eliminates issues we've been having with preprocessor
failures due to nonexistent header files, but is also much faster.
Where extract.pl would take 5s, this now finishes in 0.2s. And since
this is a non-parallelizable build step towards the end of the build
(dependent on a lot of other things being done already), the speedup is
actually noticeable.
Also files containing CLI no longer need to be listed in `vtysh_scan`
since the .xref data covers everything. `#ifndef VTYSH_EXTRACT_PL`
checks are equally obsolete.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
Wrong: memset(&a, 0, sizeof(struct ...));
Good: memset(&a, 0, sizeof(a));
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
Just some "void" missing between empty braces.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
There is a possibility that the same line can be matched as a command in
some node and its parent node. In this case, when reading the config,
this line is always executed as a command of the child node.
For example, with the following config:
```
router ospf
network 193.168.0.0/16 area 0
!
mpls ldp
discovery hello interval 111
!
```
Line `mpls ldp` is processed as command `mpls ldp-sync` inside the
`router ospf` node. This leads to a complete loss of `mpls ldp` node
configuration.
To eliminate this issue and all possible similar issues, let's print an
explicit "exit" at the end of every node config.
This commit also changes indentation for a couple of existing exit
commands so that all existing commands are on the same level as their
corresponding node-entering commands.
Fixes #9206.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Instead of setting a config_write callback for each node, set a single
callback and print all config from there. It is necessary for the
following work on explicit "exit" command in every node.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
pce-config, pce and pcc node-entering commands in vtysh include no-form,
which is incorrect. Currently, when user passes a no-form command like
`no pcc`, vtysh enters the node while pathd deletes the node and this
leads to a desynchronization.
Regular and no-form commands should be defined separately to fix this.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Use localtime_r() instead of localtime() in pathd.
Signed-off-by: Mark Stapp <mjs.ietf@gmail.com>
|
|
... by referencing all autogenerated headers relative to the root
directory. (90% of the changes here is `version.h`.)
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
isisd, eigrpd, pathd: clean up & drop *_memory.[ch] files, make a whole bunch static
|
|
Ouch, MTYPE_PCEP is used in 81 places :(
Signed-off-by: David Lamparter <equinox@diac24.net>
|
|
Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
|
|
Signed-off-by: Brady Johnson <brady@voltanet.io>
Co-authored-by: Javier Garcia <javier.garcia@voltanet.io>
Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
|
|
Misc fixes (bgpd, pathd, tools)
|
|
on one hand, the default value for a peer preference was always being
displayed, and on the other there was some code in frr-reload.py which
was attempting to add a default value to match this behavior, and which
was incorrectly overriding a specified preference. Fix this by removing
this code and making pathd behave like other daemons in this respect,
i.e. not displaying the default value.
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
|
|
Show 'low' if a pce has disconnect or 'normal' . It's only a boolean so
it's like a token that mark the pce that has recenty disconnect.
Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
|
|
This new dynamic module makes pathd behave as a PCC for dynamic candidate path
using the external library pcpelib https://github.com/volta-networks/pceplib .
The candidate paths defined as dynamic will trigger computation requests to the
configured PCE, and the PCE response will be used to update the policy.
It supports multiple PCE. The one with smaller precedence will be elected
as the master PCE, and only if the connection repeatedly fails, the PCC will
switch to another PCE.
Example of configuration:
segment-routing
traffic-eng
pcep
pce-config CONF
source-address ip 10.10.10.10
sr-draft07
!
pce PCE1
config CONF
address ip 1.1.1.1
!
pce PCE2
config CONF
address ip 2.2.2.2
!
pcc
peer PCE1 precedence 10
peer PCE2 precedence 20
!
!
!
!
Co-authored-by: Brady Johnson <brady@voltanet.io>
Co-authored-by: Emanuele Di Pascale <emanuele@voltanet.io>
Co-authored-by: GalaxyGorilla <sascha@netdef.org>
Co-authored-by: Javier Garcia <javier.garcia@voltanet.io>
Co-authored-by: Renato Westphal <renato@opensourcerouting.org>
Co-authored-by: Sebastien Merle <sebastien@netdef.org>
Signed-off-by: Sebastien Merle <sebastien@netdef.org>
|
