| Age | Commit message (Collapse) | Author |
|---|
|
CLI for access/prefix list removal was using `nb_cli_apply_changes`
multiple times in the same command. It's fine for regular daemons but
not for mgmtd. Refactor the code to apply changes only once.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
nhrpd: unset noarp flag using a zapi message
|
|
lib: remove leaf-list xpath hack from northbound
|
|
Add a ZAPI message to control the setting of the IFF_NOARP flag.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
Currently, when editing a leaf-list, `nb_candidate_edit` expects to
receive it's xpath without a predicate and the value in a separate
argument, and then creates the full xpath. This hack is complicated,
because it depends on the operation and on the caller being a backend or
not. Instead, let's require to always include the predicate in a
leaf-list xpath. Update all the usages in the code accordingly.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Zebra neigh update
|
|
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
It's not needed anymore, all daemons always pass context.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
This is needed to be generic. Let's make it so.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
This does not need to be nhrp specific.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
add northbound support to distribute-list code.
|
|
bgpd: add VRF support to RPKI
|
|
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
Chopps/mgmtd northbound fixes
|
|
Previously each container created all it's decendents before descending into
the children and repeating the process.
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
If we're in the backend we already have the predicate added by mgmtd -- don't
add it again.
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
We don't want libyang logging when an schema path doesn't exist
since this is an acceptable outcome.
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
|
|
lib,vtysh: add per-daemon log file config
|
|
- initialize the necessary bit when creating if_link_params
- fix CLI description to mark extended as the default mode
- correctly set mode to extended when using the "no" form of the command
- handle the "show_defaults" parameter correctly in cli_show callback
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
There can't be an affinity map without a bit position.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
When affinity mode is "standard", bit position cannot be greater than
31. Add a "must" statement to the YANG model to validate this, and
remove our custom validation code that does the same.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
It allows us to remove the code that does the same thing manually.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Change the type of affinity leaf-list in frr-zebra to a leafref with
"require-instance" property set to true. This change tells libyang to
automatically check that affinity-map exists before usage and doesn't
allow it to be deleted if it's referenced. It allows us to remove all
the manual code that is doing the same thing.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Add support of RPKI commands in the VRF configure context.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
Add a config that specifies per-deamon log file names.
Move the handy generated list of daemon names from vtysh to lib;
edit the gitignore files to match.
Signed-off-by: Mark Stapp <mjs@labn.net>
|
|
mgmtd get-data request expansion
|
|
RESTCONF expects to receive the exact node as a result, not the whole
data tree.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
When creating an initial tree trunk for oper data walk, if the xpath
represents a leaf, the leaf is created with an incorrect empty value.
If it doesn't actually exist in daemon's oper data, its value is not
overwritten later and an empty value is returned in the result.
For example, when requesting
`/frr-interface:lib/interface[name='eth0']/description`, the result is:
```
{
"frr-interface:lib": {
"interface": [
{
"name": "eth0",
"description": ""
}
]
}
}
```
instead of an empty JSON that it should be.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Like in RESTCONF GET request and NETCONF get-data request, make it
possible to request state-only, config-only, or all data.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Currently it's the same as get-tree request for the backend, but it is
going to be expanded in the following commits.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
We should traverse all top-level siblings, not only the first one.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Technically changing a leaf from uint16 to uint32 is a NBC change; however,
increasing this to uint32 should not break anyone in reality.
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
** CID 1575595: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
lib: fix coverity issues
|
|
Add more northbound operation types
|
|
lib, mgmtd: rename ignore_cbs to ignore_cfg_cbs
|
|
Setting this variable to true makes NB ignore only configuration-related
callbacks. CLI-related callbacks are still loaded and executed, so
rename the variable to make it clearer.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
** CID 1575504: Insecure data handling (TAINTED_SCALAR) (maybe)
** CID 1575505: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
** CID 1575506: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
** CID 1575507: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Replace operation removes the current data node configuration and sets
the provided value. As current northbound code works only with one
xpath at a time, the operation only makes sense to clear the config of
a container without deleting it itself. However, the next step is to
allow passing JSON-encoded complex values to northbound operations which
will make replace operation much more useful.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Currently, there's a single operation type which doesn't return error
if the object doesn't exists. To be compatible with NETCONF/RESTCONF,
we should support differentiate between DELETE (fails when object
doesn't exist) and REMOVE (doesn't fail if the object doesn't exist).
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
|
Currently, there's no difference between CREATE and MODIFY operations.
To be compatible with NETCONF/RESTCONF, add new CREATE_EXCL operation
that throws an error if the configuration data already exists.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
|
