| Age | Commit message (Collapse) | Author |
|---|
|
Clean up code related to pbr_iptable->interface_name_list free. This is
a cosmetic change.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
We are obviously doing deleting on wrong object.
> Direct leak of 40 byte(s) in 1 object(s) allocated from:
> #0 0x7fcf718b4a57 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
> #1 0x7fcf7126f8dd in qcalloc lib/memory.c:105
> #2 0x7fcf7124401a in list_new lib/linklist.c:49
> #3 0x55771621d86d in pbr_iptable_alloc_intern zebra/zebra_pbr.c:1015
> #4 0x7fcf71217d79 in hash_get lib/hash.c:147
> #5 0x55771621dad3 in zebra_pbr_add_iptable zebra/zebra_pbr.c:1030
> #6 0x55771614d00c in zread_iptable zebra/zapi_msg.c:4131
> #7 0x55771614e586 in zserv_handle_commands zebra/zapi_msg.c:4424
> #8 0x5577162dae2c in zserv_process_messages zebra/zserv.c:521
> #9 0x7fcf7137798e in event_call lib/event.c:2011
> #10 0x7fcf71242ff1 in frr_run lib/libfrr.c:1216
> #11 0x5577160e4d6d in main zebra/main.c:540
> #12 0x7fcf70c29d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
>
> Indirect leak of 24 byte(s) in 1 object(s) allocated from:
> #0 0x7fcf718b4a57 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
> #1 0x7fcf7126f8dd in qcalloc lib/memory.c:105
> #2 0x7fcf71244129 in listnode_new lib/linklist.c:71
> #3 0x7fcf71244238 in listnode_add lib/linklist.c:92
> #4 0x55771621d938 in pbr_iptable_alloc_intern zebra/zebra_pbr.c:1019
> #5 0x7fcf71217d79 in hash_get lib/hash.c:147
> #6 0x55771621dad3 in zebra_pbr_add_iptable zebra/zebra_pbr.c:1030
> #7 0x55771614d00c in zread_iptable zebra/zapi_msg.c:4131
> #8 0x55771614e586 in zserv_handle_commands zebra/zapi_msg.c:4424
> #9 0x5577162dae2c in zserv_process_messages zebra/zserv.c:521
> #10 0x7fcf7137798e in event_call lib/event.c:2011
> #11 0x7fcf71242ff1 in frr_run lib/libfrr.c:1216
> #12 0x5577160e4d6d in main zebra/main.c:540
> #13 0x7fcf70c29d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
Fixes: f80ec7e3d6 ("zebra: handle iptable list of interfaces")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
Split up MTYPE_PBR_OBJ into dedicated MTYPE to clarify the memory
allocation and free.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
isisd: fix asla memory leak
|
|
babeld: Add MBZ and Reserved field checking
|
|
tests: Fix potential issues in mcast-tester.py
|
|
tools: Add pathspace option to generate_support_bundle
|
|
> ==713776==ERROR: LeakSanitizer: detected memory leaks
>
> Direct leak of 120 byte(s) in 1 object(s) allocated from:
> #0 0x7fdfcbeb4a57 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
> #1 0x7fdfcb86f8dd in qcalloc lib/memory.c:105
> #2 0x55ce707739b6 in isis_tlvs_find_alloc_asla isisd/isis_tlvs.c:8500
> #3 0x55ce7072fae0 in isis_link_params_update_asla isisd/isis_te.c:191
> #4 0x55ce70733881 in isis_link_params_update isisd/isis_te.c:499
> #5 0x55ce70693f2a in isis_circuit_up isisd/isis_circuit.c:776
> #6 0x55ce7069a120 in isis_csm_state_change isisd/isis_csm.c:135
> #7 0x55ce7068dd80 in isis_circuit_enable isisd/isis_circuit.c:79
> #8 0x55ce70699346 in isis_ifp_create isisd/isis_circuit.c:1618
> #9 0x7fdfcb81f47f in hook_call_if_real lib/if.c:55
> #10 0x7fdfcb82056e in if_new_via_zapi lib/if.c:188
> #11 0x7fdfcb9d17da in zclient_interface_add lib/zclient.c:2706
> #12 0x7fdfcb9df842 in zclient_read lib/zclient.c:4843
> #13 0x7fdfcb97798e in event_call lib/event.c:2011
> #14 0x7fdfcb842ff1 in frr_run lib/libfrr.c:1216
> #15 0x55ce7067cbf2 in main isisd/isis_main.c:360
> #16 0x7fdfcb229d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
>
> Indirect leak of 8 byte(s) in 1 object(s) allocated from:
> #0 0x7fdfcbeb4a57 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
> #1 0x7fdfcb86f8dd in qcalloc lib/memory.c:105
> #2 0x7fdfcb79a7b7 in admin_group_init lib/admin_group.c:186
> #3 0x55ce707739ca in isis_tlvs_find_alloc_asla isisd/isis_tlvs.c:8501
> #4 0x55ce7072fae0 in isis_link_params_update_asla isisd/isis_te.c:191
> #5 0x55ce70733881 in isis_link_params_update isisd/isis_te.c:499
> #6 0x55ce70693f2a in isis_circuit_up isisd/isis_circuit.c:776
> #7 0x55ce7069a120 in isis_csm_state_change isisd/isis_csm.c:135
> #8 0x55ce7068dd80 in isis_circuit_enable isisd/isis_circuit.c:79
> #9 0x55ce70699346 in isis_ifp_create isisd/isis_circuit.c:1618
> #10 0x7fdfcb81f47f in hook_call_if_real lib/if.c:55
> #11 0x7fdfcb82056e in if_new_via_zapi lib/if.c:188
> #12 0x7fdfcb9d17da in zclient_interface_add lib/zclient.c:2706
> #13 0x7fdfcb9df842 in zclient_read lib/zclient.c:4843
> #14 0x7fdfcb97798e in event_call lib/event.c:2011
> #15 0x7fdfcb842ff1 in frr_run lib/libfrr.c:1216
> #16 0x55ce7067cbf2 in main isisd/isis_main.c:360
> #17 0x7fdfcb229d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
PR: 95719
Fixes: 5749ac83a8 ("isisd: add ASLA support")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
bgpd: fix add prefix sent in 'show bgp neighbor'
|
|
bgpd: add usid behavior for bgp srv6 instructions
|
|
babeld: Add input validation for update TLV.
|
|
babeld: fix incorrect type assignment in parse_request_subtlv
|
|
Adding a `-N` pathspace option to the generate_support_bundle.py
to support FRR running in a non-default namespace with a prefix
on the config/socket options.
The same pathspace will be prepended to the output log files (if
specified)
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
|
|
bfdd: Fix demultiplexing to rely solely on Your Discriminator
|
|
bgpd: remove useless calls to afi2family
|
|
bgpd: Paths not deleted received from shutdown peer
|
|
Fix potential issues in mcast-tester.py
Signed-off-by: y-bharath14 <y.bharath@samsung.com>
|
|
The 'acceptedPrefixCounter' is available in 'show bgp neighbor json', but
there is no equivalent when using the non json output. Add it.
> # show bgp neighbor
> [..]
> Community attribute sent to this neighbor(all)
> 0 accepted prefixes, 1 sent prefixes
Fixes: 856ca177c4bb ("Added json formating support to show-...-neighbors-... bgp commands.")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
|
|
bgpd: On shutdown free up table for static routes
|
|
This fix add tests to verify routes/path are getting
deleted properly, when the advertising neighbor is shutdown
Signed-off-by: Soumya Roy <souroy@nvidia.com>
|
|
zebra: Fix shadow warning in irdp_packet.c
|
|
My compiler is complaining about irdp_sock
being a shadow variable.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
Issue:
In a scaled setup, (where number of nets > BGP_CLEARING_BATCH_MAX_DESTS
for walk_batch_table_helper), when peer is shutdown, it is seen some
of the paths are not deleted, which are received from that peer.
Fix:
This is due to, in clear_batch_rib_helper, once walk_batch_table_helper
returns after BGP_CLEARING_BATCH_MAX_DESTS is reached, we just break
from inner loop for the afi/safi for loops. So during walk for next
afi/safi that 'ret' state is overwritten with new state. Also the
resume context is overwritten. This causes to lose the start point
for next walk, some nets are skipped forever. So they are not marked
for deletion anymore. To fix this, we immediately return from current
run. This will have resume state to be stored correctly, and next walk
will start from there.
Testing:
32 ecmp paths were received from the shutdown peer
Before fix:
show bgp ipv6 2052:52:1:167::/64
BGP routing table entry for 2052:52:1:167::/64, version 495
Paths: (246 available, best #127, table default)
Not advertised to any peer
<snip>
4200165500 4200165002
2021:21:51:101::2(spine-5) from spine-5(2021:21:51:101::2) (6.0.0.17)
(fe80::202:ff:fe00:55) (prefer-global)
Origin incomplete, valid, external, multipath
Last update: Fri Apr 4 17:25:05 2025
4200165500 4200165002
2021:21:11:116::2(spine-1) from spine-1(2021:21:11:116::2) (0.0.0.0)
(fe80::202:ff:fe00:3d) (prefer-global)<<<<path not deleted
Origin incomplete, valid, external
Last update: Fri Apr 4 17:25:05 2025
4200165500 4200165002
2021:21:11:115::2(spine-1) from spine-1(2021:21:11:115::2) (0.0.0.0)
(fe80::202:ff:fe00:3d) (prefer-global)<<<<path not deleted
Origin incomplete, valid, external
Last update: Fri Apr 4 17:25:05 2025
<snip>
32 paths are supposed to be withdrawn:
root@leaf-1:mgmt:# vtysh -c "show bgp ipv6 2052:52:1:167::/64" | grep "prefer-global" | wc -l
256
root@leaf-1:mgmt# vtysh -c "show bgp ipv6 2052:52:1:167::/64" | grep "prefer-global" | wc -l
246<<should be 224, but showing 246, which is wrong
After fix:
32 paths are supposed to be withdrawn:
root@leaf-1:mgmt:# vtysh -c "show bgp ipv6 2052:52:1:167::/64" | grep "prefer-global" | wc -l
256
root@leaf-1:mgmt:# vtysh -c "show bgp ipv6 2052:52:1:167::/64" | grep "prefer-global" | wc -l
224<<<shows correctly
Signed-off-by: Soumya Roy <souroy@nvidia.com>
|
|
mgmtd: remove bogus "hedge" code which corrupted active candidate DS
|
|
Indirect leak of 56 byte(s) in 1 object(s) allocated from:
0 0x7fdaf6cb83b7 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:77
1 0x7fdaf683a480 in qcalloc lib/memory.c:106
2 0x7fdaf68dd706 in route_table_init_with_delegate lib/table.c:38
3 0x5649b22c05b0 in bgp_table_init bgpd/bgp_table.c:139
4 0x5649b2273da0 in bgp_static_set bgpd/bgp_route.c:7779
5 0x5649b21eba58 in vpnv4_network bgpd/bgp_mplsvpn.c:3244
6 0x7fdaf67b6d61 in cmd_execute_command_real lib/command.c:1003
7 0x7fdaf67b7080 in cmd_execute_command lib/command.c:1062
8 0x7fdaf67b75ac in cmd_execute lib/command.c:1228
9 0x7fdaf68ffb20 in vty_command lib/vty.c:626
10 0x7fdaf6900073 in vty_execute lib/vty.c:1389
11 0x7fdaf6903e24 in vtysh_read lib/vty.c:2408
12 0x7fdaf68f0222 in event_call lib/event.c:2019
13 0x7fdaf681b3c6 in frr_run lib/libfrr.c:1247
14 0x5649b211c903 in main bgpd/bgp_main.c:565
15 0x7fdaf630c249 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
Table was being created but never deleted. Let's delete it.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
Remove useless calls to afi2family(). str2prefix() always sets the
prefix family.
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
yang: Pyang errors in frr-bfdd.yang
|
|
Having just completed a code audit during RCA, the fact that we have 2
different argument orders for the related datastore copying functions
was unnecessary and super confusing.
Fix this code-maintenance/comprehension mistake and move the newer mgmtd
copy routines to use the same arg order as the pre-existing underlying
northbound copy functions (i.e., use `copy(dst, src)`)
Signed-off-by: Christian Hopps <chopps@labn.net>
|
|
|
|
bgpd: On shutdown free up memory leak found by topotest
|
|
Looks like there were a couple of SA warnings lurking; fix
them.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up -Wshadow warnings in unit-tests
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up -Wshadow warnings in these components
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up -Wshadow warnings in three daemons
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up -Wshadow in sharpd
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up -Wshadow warnings in bgp.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up -Wshadow warnings in pimd
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up variable-shadowing compiler warnings.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up -Wshadow compiler warnings.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up compiler warnings; convert a linklist macro
to an inline to resolve one; clean up a side-effect in isisd.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up compiler warnings.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various variable-shadow warnings from -Wshadow
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various variable-shadowing warnings from -Wshadow
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various variable-shadow warnings in mgmtd.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various variable-shadow warnings in ldpd.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various warnings from -Wshadow in eigrp.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various variable-shadow warnings in bfdd.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various "shadow" warnings in babeld.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various "shadow" warnings.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
|
Clean up various "shadow" warnings.
Signed-off-by: Mark Stapp <mjs@cisco.com>
|
