summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-27Merge pull request #5864 from kuldeepkash/route_mapDonatas Abraitis
tests: Optimizing route-map test cases
2020-02-26tests: Modified scripts to optimize execution time for route-map test suiteKuldeep Kashyap
1. Modified scripts to optimize execution time for route-map test suite 2. Removed unnecessary print statements from /lib/bgp.py Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2020-02-26Merge pull request #5866 from qlyoung/fix-ipaddr-issetMark Stapp
lib: fix ipaddr_isset
2020-02-26lib: fix ipaddr_issetQuentin Young
Meaning inverted by mistake Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-25Merge pull request #5783 from ton31337/fix/bad_formatting_bgpd_grRuss White
bgpd: Format properly `show bgp neighbors` for graceful restart stuff
2020-02-25Merge pull request #5270 from NaveenThanikachalam/rmapDonald Sharp
lib: Optimizing route-maps
2020-02-25Merge pull request #5771 from pguibert6WIND/show_route_table_protocolDonald Sharp
vty: add command to get route with table, vrf and protocol
2020-02-21Merge pull request #5838 from volta-networks/fix_isis_ifdownRenato Westphal
isisd: do not disable circuit on ifdown
2020-02-21Merge pull request #5844 from qlyoung/fix-zebra-gr-unnecessary-mallocDonatas Abraitis
Fix zebra gr unnecessary malloc
2020-02-20Merge pull request #5847 from mjstapp/fix_pim_sasQuentin Young
pimd: fix SA reports
2020-02-20pimd: fix SA reportsMark Stapp
Fix a couple of SA warnings introduced recently; replace some 'strcpy' calls. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-20Merge pull request #5842 from qlyoung/fix-test-then-xfree-againDonatas Abraitis
lib: do not test before XFREE
2020-02-20Merge pull request #5845 from TomasKorbar/masterDonald Sharp
Make frr able to be built by gcc 10
2020-02-20Merge pull request #5768 from donaldsharp/bgp_nexthopDonatas Abraitis
Bgp nexthop
2020-02-20Merge pull request #5831 from donaldsharp/small_test_speedupsDonatas Abraitis
Small test speedups
2020-02-20pimd: Make frr able to be built by gcc 10Tomas Korbar
- Add extern modifier to some declarations in header file and move qpim_all_pim_routers_addr definition to pimd/pimd.c `GCC now defaults to -fno-common. As a result, global variable accesses are more efficient on various targets. In C, global variables with multiple tentative definitions now result in linker errors.` Taken from https://gcc.gnu.org/gcc-10/changes.html Signed-off-by: Tomas Korbar <tkorbar@redhat.com>
2020-02-19Merge pull request #5840 from opensourcerouting/route-map-recurseDonald Sharp
lib: don't allow to recurse inside route-map node
2020-02-19zebra: remove null check before XFREE in GR codeQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-19zebra: reduce scope of XCALLOC for gr processingQuentin Young
Somewhat gnarly code flow here that might be leaking memory - can't tell if it's a test artifact or not, but in any case this reduces the situations in which we need to alloc a block. And we don't need to check XCALLOC for success... And we don't need to null check before XFREE... Or set XFREE'd pointers to NULL... Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-19lib: do not test before XFREEQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-19lib: don't allow to recurse inside route-map nodeRafael Zalamena
vtysh should handle going back up one level to try the command, there is no need to be able to recurse inside route-map. This also fixes a problem with northbound hitting the XPath queue limit of 8 nodes. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-02-19tests: Reduce rip[ng]-topo1 run timeDonald Sharp
Reduce rip topo1 run time from ~100 seconds down to ~45 seconds. 1) Reduce very very long sleeps 2) Modify rip timers to be more aggressive in sending data. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-19Merge pull request #5826 from mjstapp/fix_cli_pfx_docDonald Sharp
doc: correct ip prefix token mapping table
2020-02-19tests: bgp_multiview_topo1 was taking too longDonald Sharp
The bgp_multiview_topo1 test had two issues a) An abbundance of sleeps that are not necessary b) The convergence time was too short. The upshoot of this is that the test goes from 72 -> 33 seconds run time on my machine. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-19Merge pull request #5788 from karamalla0406/large_commDonatas Abraitis
bgpd: support 'show ip bgp large-community" on default vrf
2020-02-19Merge pull request #5834 from opensourcerouting/route-map-fix-crashDonald Sharp
lib: fix route-map coverity scan issue
2020-02-19Merge pull request #5836 from donaldsharp/bgp_collisionDonatas Abraitis
bgpd: Add a better breadcrumb for when bgp is missconfiged
2020-02-19Merge pull request #5837 from ↵Donatas Abraitis
qlyoung/fix-zapi-pbr-unsupported-ip-family-log-message-newline zebra: remove \n in zapi pbr family log msg
2020-02-19isisd: do not disable circuit on ifdownEmanuele Di Pascale
when zebra detects that an interface is gone, notify the circuit but do not disable it - the interface is still configured until it isn't. Without this fix, removing the interface in the kernel and then removing the circuit from the configuration would cause an assertion in isis_csm.c:78 Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2020-02-19zebra: remove \n in zapi pbr family log msgQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-02-19bgpd: Add a better breadcrumb for when bgp is missconfigedDonald Sharp
Currently During bgp open collision resolution if both the router-id's are the same, we correctly follow the RFC and close the connection. The problem is of course that there is no notification of the error in configuration to the end user other than a subtle open debug message. Explicitly call out the miss-configuration as an error message as that this miss-config took several hours of debugging to notice. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-19doc: correct ip prefix token mapping tableMark Stapp
Fix the table that shows the mapping between ip network cli tokens and the data struct that the cli handler will see. Optional network/subnet types appear as a pointer to an all-zeroes struct, not a NULL pointer. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-19Merge pull request #5802 from ton31337/feature/aggregate-address_origin_overrideDonald Sharp
bgpd: Allow overriding ORIGIN for aggregate-address
2020-02-19lib: fix route-map coverity scan issueRafael Zalamena
Use better TAILQ free idiom to avoid coverity scan warnings. This fixes the coverity scan issue 1491240 . Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-02-19Merge pull request #5830 from mjstapp/fix_rtadv_stubsDonald Sharp
zebra: fix missing rtadv stub functions
2020-02-19Merge pull request #5809 from donaldsharp/vrf_nameDonatas Abraitis
Print out vrf name as well as id
2020-02-19Merge pull request #5795 from donaldsharp/lua_dev_docDonatas Abraitis
doc: Add some basic how-to for lua and clean up some found issues
2020-02-18zebra: fix missing rtadv stub functionsMark Stapp
Add in a few missing stub route-advert functions; these are needed to build frr with v6 route adverts disabled. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-02-18Merge pull request #5823 from donaldsharp/irdp_whatMark Stapp
Irdp build and log fixes
2020-02-18Merge pull request #5651 from AnuradhaKaruppiah/evpn-pim-fixesPhilippe Guibert
EVPN-PIM: complete anycast (MLAG) VTEP support
2020-02-18Merge pull request #5813 from mjstapp/zapi_labels_use_nhDonald Sharp
*: encode zapi labels message using nexthops
2020-02-18zebra: Fix checksum calculation to not include old checksumDonald Sharp
As part of checksum calculation for a received packet we were comparing the checksum returned from in_cksum. Typically when we calculate the checksum the value stored in the checksum must be all 0's. Store the received checksum and then set the checksum to 0 and then compare. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-18zebra: Fix zlog_debug -> flog_err for error situations in IRDPDonald Sharp
In several places we would send debug messages for failure situations that really should be errors. Signed-off-by: Donald Sharpd <sharpd@cumulusnetworks.com>
2020-02-18zebra: SO_BROADCAST needs a uint32_t instead of a uint8_tDonald Sharp
Using SO_BROADCAST, in the linux kernel, requires a uint32_t to be passed in for all SOL_SOCKET calls. Modify code to use it. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-02-18lib: Optimizing route-maps - Part-4Naveen Thanikachalam
The commit includes the documentation for the newly introduced commands to enable/disable the optimization. Signed-off-by: NaveenThanikachalam <nthanikachal@vmware.com>
2020-02-18lib: Optimizing route-maps - Part-3Naveen Thanikachalam
* This commit implements the code style suggestions from Polychaeta. * This commit also introduces a CLI to toggle the optimization and, a hidden CLI to display the contents of the constructed prefix tree. Signed-off-by: NaveenThanikachalam <nthanikachal@vmware.com>
2020-02-18lib: Optimizing route-maps - Part-2Naveen Thanikachalam
This commit introduces the logic that computes the best-match route-map index for a given prefix. Signed-off-by: NaveenThanikachalam <nthanikachal@vmware.com>
2020-02-18lib: Optimizing route-maps - Part-1Naveen Thanikachalam
* This commit introduces the building blocks. A per-route-map prefix tree is introduced. This tree will consist of the prefixes defined within the prefix-lists that are added to the match clause of that route-map. Signed-off-by: NaveenThanikachalam <nthanikachal@vmware.com>
2020-02-17Merge pull request #5801 from donaldsharp/bgp_peer_sortSri Mohana Singamsetty
Bgp peer sort
2020-02-17Merge pull request #5790 from chiragshah6/mdevSri Mohana Singamsetty
bgpd: format fields to bgp evpn vni json cmds