summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-24Revert "bgpd: Show PfxSnt for `show bgp <afi> <safi>` command"revert-6277-feature/show_bgp_afi_safi_sndpfxDonald Sharp
2020-04-24Merge pull request #6274 from mjstapp/fix_lde_blocking_sleepOlivier Dugeon
ldpd: use a timer instead of sleeping in LM init
2020-04-23Merge pull request #6277 from ton31337/feature/show_bgp_afi_safi_sndpfxSri Mohana Singamsetty
bgpd: Show PfxSnt for `show bgp <afi> <safi>` command
2020-04-23Merge pull request #6262 from qlyoung/remove-sprintfDavid Lamparter
2020-04-23Merge pull request #6184 from kssoman/routeStephen Worley
bgpd: When static default route is present in RIB and advertised to p…
2020-04-23ldpd: use a timer instead of sleeping in LM initMark Stapp
Stop sleeping if synchronous label-manager zapi session has trouble during init: retry using a timer instead. Move initial label-block request to a point where the LM zapi session is known to be running. Remove the use of the daemon 'instance' - we're using the session_id to distinguish the LM zapi session. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-04-23Merge pull request #6278 from opensourcerouting/cpp-extern-blocksDonald Sharp
lib, zebra: add missing extern "C" {} blocks to new header files
2020-04-23tests: Adopt some tests to PfxSnt counterDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-04-23bgpd: Show PfxSnt for `show bgp <afi> <safi>` commandDonatas Abraitis
JSON output was already in, just printing in CLI as well. ``` root@exit1-debian-9:~# vtysh -c 'show bgp ipv4 summary' IPv4 Unicast Summary: BGP router identifier 10.10.10.1, local AS number 65001 vrf-id 0 BGP table version 100003 RIB entries 200005, using 37 MiB of memory Peers 1, using 21 KiB of memory ... MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt ... 64 157 0 0 0 00:01:18 0 100003 Total number of neighbors 1 ``` JSON: ``` root@exit1-debian-9:~# vtysh -c 'show bgp ipv4 summary json' \ | > jq '.ipv4Unicast.peers."192.168.0.2".pfxSnt' 100003 ``` Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-04-23Merge pull request #6025 from patrasar/rp-info-igmp-group-json-fixDonatas Abraitis
pimd: Modified rp-info json o/p
2020-04-22Merge pull request #6275 from donaldsharp/fix_frrLou Berger
yang: Convert to `FRRouting` for organization
2020-04-22lib, zebra: add missing extern "C" {} blocks to new header filesRenato Westphal
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-04-22bgpd: Configuring default-originate withdraws default routeSoman K S
Issue: Configuring default-originate when static default route is previously advertised results in withdrawal of the route. Fix : Delete the adj-out entry for the previously advertised static default route without sending explicit withdraw message. Signed-off-by: kssoman <somanks@gmail.com>
2020-04-22Merge pull request #6242 from pguibert6WIND/flowspec_nlri_too_bigQuentin Young
bgpd: handle fs nlri over 240 bytes
2020-04-22Merge pull request #6272 from opensourcerouting/duplicated-fpm-docQuentin Young
doc: remove duplicated command documentation
2020-04-22yang: Convert to `FRRouting` for organizationDonald Sharp
We should be using `FRRouting` as our organization. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-22Merge pull request #6265 from patrasar/pim-yangQuentin Young
yang: Defining yang files for pim
2020-04-22yang: Defining yang files for pimSarita Patra
Signed-off-by: Sarita Patra <saritap@vmware.com>
2020-04-22Merge pull request #5944 from donaldsharp/vrf_stoppageRuss White
Vrf stoppage
2020-04-22pimd: Added a new field "rpAddress" in "show ip pim rp-info jsonSarita Patra
Fix: Added a new field "rpAddress" in "show ip pim rp-info json" Before: "40.0.0.2":[ { "outboundInterface":"ens224", "group":"224.0.0.0\/4", "source":"Static" } After: "40.0.0.2":[ { "rpAddress":"40.0.0.2", "outboundInterface":"ens224", "group":"224.0.0.0\/4", "source":"Static" } Signed-off-by: Sarita Patra <saritap@vmware.com>
2020-04-22zebra: Prevent awful misconfiguration in vrf'sDonald Sharp
Currently the linux kernel allows you to specify the same table id -> multiple vrf's. While I am arguing with the kernel people about proper behavior here let's just remove this as a possiblity from happening and mark it a zebra stopable misconfiguration. (Effectively we are preventing a crash down the line as that all over FRR we assume it's a unique mapping not a many to one). Why fail hard? Because we hope to get the person who misconfigured it to actually notice immediately not hours or days down the line when shit hits the fan. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-22zebra: Expose vrf lookup by table id out of rt_netlink.cDonald Sharp
The function rt_netlink.c is using to lookup the vrf by passed in table id. I'm also going to pretend that this function is not so awful to run when we have a large number of routes incoming. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-22doc: improve FPM clear command docRafael Zalamena
Use the old description as it looks more complete than the current. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-04-22doc: remove duplicated command documentationRafael Zalamena
Fixes a documentation warning during compilation. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-04-22Merge pull request #6269 from donaldsharp/coverity_likes_coverityDonatas Abraitis
Coverity likes coverity
2020-04-22ospfd: Limit possible message read to our buffer sizeDonald Sharp
It's possible(but unlikely) that a read of data from the network will give us bogus data. Don't automatically just trust the data size from the network and limit the read to the size of the buffer we have in play. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-22zebra: Cleanup dead codeDonald Sharp
There are a couple of switch statements in netlink_route_info_encode in zebra_fpm_netlink.c that had logically dead code. We have a switch statement let's take actual advantage of it instead of doing gyrations to what we want. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-22Merge pull request #6268 from opensourcerouting/atomlist-cxx-compatDonald Sharp
lib: make atomlist code C++ compatible
2020-04-22bgpd: handle fs nlri over 240 bytesPhilippe Guibert
the nlri flowspec above 240 bytes size was not handled. Over 240 bytes, the length is 2 bytes length, and a calculation must be done to obtain the real length. This commit handles it appropriately. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2020-04-21Merge pull request #6191 from NaveenThanikachalam/ibgp_connectedDonatas Abraitis
bgpd: Enforce self-next-hop check in next-hop update.
2020-04-21Merge pull request #6126 from sarav511/watermarkDonald Sharp
pimd: Implement watermark warning for igmp group count and add igmp group count
2020-04-21lib/frrcu: make C++ compatibleDavid Lamparter
... by dropping seqlock.h from the header's includes; it's only needed in the C code in frrcu.c. Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-21lib/atomlist: make C++ compatibleDavid Lamparter
... by using `atomic_atomptr_t`. Other ideas seemed worse. Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-21Merge pull request #6267 from mjstapp/fix_ospf6_unlock_saQuentin Young
ospf6d: fix SA warnings
2020-04-21pimd, lib: suppress compiler warnings on snprintfQuentin Young
truncation warnings on old compilers Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-04-21Merge pull request #6253 from opensourcerouting/fpm-extraQuentin Young
zebra/fpm: fix shutdown and add more documentation
2020-04-21Merge pull request #6264 from opensourcerouting/doc-workflow-20200420Donald Sharp
doc: workflow updates
2020-04-21ospf6d: fix SA warningsMark Stapp
Clean up some SA warnings in use of ospf6_lsa_unlock() Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-04-21Merge pull request #6147 from opensourcerouting/ldpd-broken-lspsRuss White
ldpd: don't drop packets coming through a broken LSP
2020-04-21doc: add some Github workflow notesDavid Lamparter
Just writing down what seems to be established procedure. Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-21doc: document strcpy & sprintf banDavid Lamparter
Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-20bgpd, isis, tools: style fixenQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-04-20*: use appropriate buffer sizes, specifiersQuentin Young
- Fix 1 byte overflow when showing GR info in bgpd - Use PATH_MAX for path buffers - Use unsigned specifiers for uint16_t's in zebra pbr Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-04-20*: manually remove some more sprintfQuentin Young
Take care of some more complicated cases by hand Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-04-20*: sprintf -> snprintfQuentin Young
Replace sprintf with snprintf where straightforward to do so. - sprintf's into local scope buffers of known size are replaced with the equivalent snprintf call - snprintf's into local scope buffers of known size that use the buffer size expression now use sizeof(buffer) - sprintf(buf + strlen(buf), ...) replaced with snprintf() into temp buffer followed by strlcat Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-04-20tools: add more macros to cocci.hQuentin Young
Coccinelle needs to know about complicated macros to understand certain code paths, add some more macros there. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-04-20Merge pull request #6263 from opensourcerouting/zlog-coverity-20200420Quentin Young
lib/zlog: fix coverity warning
2020-04-20doc: remove mailing list patch submissionDavid Lamparter
Last patch sent in on the mailing list was in July 2018. If someone sends a patch we can still pick it up, but practiced reality is quite clearly PRs on github. Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-20lib/zlog: fix coverity warningDavid Lamparter
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2020-04-20Merge pull request #6261 from ton31337/fix/allow_nhlen_32Donald Sharp
bgpd: Do not discard an UPDATE if the global nexthop is set to ::