summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-14Revert "Rpki Encapsulation"revert-5015-rpki_vrf_encapsulationQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-07-14Merge pull request #6598 from mruprich/python-3.8Quentin Young
build: find all future minor versions of python3
2020-07-14Merge pull request #6721 from kuldeepkash/bgp_basic_functionalityMark Stapp
tests: [topojson] Increase BGP convergence wait time
2020-07-14Merge pull request #5015 from pguibert6WIND/rpki_vrf_encapsulationQuentin Young
Rpki Encapsulation
2020-07-14Merge pull request #6718 from opensourcerouting/bfd-profile-small-fixQuentin Young
bfdd: update detect multiplier on profile change
2020-07-14tests: [topojson] Increase BGP convergence wait timeKuldeep Kashyap
1. Increasing BGP convergence wait time to overcome Ubuntu 16.04 arm8 box, as bgp neighorship is taking more time in this particular testbed. 2. Debugged bgp-ecmp-topo2 failures and here also it seems to be bgp convergence issue, doing some enhancement in scripts to handle it Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2020-07-13Merge pull request #6649 from xThaid/dplane_batching2Rafael Zalamena
zebra: netlink cleanup
2020-07-13Merge pull request #6346 from ton31337/fix/bgp_hostname_nexthop_if_unchangedRafael Zalamena
bgpd: Show the real next-hop address in addition to hostname in `show…
2020-07-13Merge pull request #5301 from idryzhov/show-interfaceQuentin Young
[RFC] zebra: remove vrf parameter from "show interface ..." commands
2020-07-13Merge pull request #6704 from mjstapp/pthread_block_signalsQuentin Young
lib: block signals in child pthreads
2020-07-13zebra: cosmetic changes in the netlink codeJakub Urbańczyk
Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>
2020-07-13doc: Add some words about `bgp default show-[nexthop]-hostname`Donatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-07-13bgpd: Add "hostname" in JSON output for `show bgp` family outputsDonatas Abraitis
This adds hostname regardless if `bgp default show-hostname` enabled or not. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-07-13bgpd: Show the real next-hop address in addition to hostname in `show bgp`Donatas Abraitis
It's hard to cope with cases when next-hop is changed/unchanged or peers are non-direct. It would be better to show the hostname and nexthop IP address (both) under `show bgp` to quickly identify the source and the real next-hop of the route. If `bgp default show-nexthop-hostname` is toggled the output looks like: ``` spine1-debian-9# show bgp BGP table version is 1, local router ID is 2.2.2.2, vrf id 0 Default local pref 100, local AS 65002 Status codes: s suppressed, d damped, h history, * valid, > best, = multipath, i internal, r RIB-failure, S Stale, R Removed Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self Origin codes: i - IGP, e - EGP, ? - incomplete Network Next Hop Metric LocPrf Weight Path * 2a02:4780::/64 fe80::a00:27ff:fe09:f8a3(exit1-debian-9) 0 0 65001 ? spine1-debian-9# show ip bgp BGP table version is 5, local router ID is 2.2.2.2, vrf id 0 Default local pref 100, local AS 65002 Status codes: s suppressed, d damped, h history, * valid, > best, = multipath, i internal, r RIB-failure, S Stale, R Removed Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self Origin codes: i - IGP, e - EGP, ? - incomplete Network Next Hop Metric LocPrf Weight Path *> 10.255.255.0/24 192.168.0.1(exit1-debian-9) 0 0 65001 ? ``` Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-07-13bfdd: update detect multiplier on profile changeRafael Zalamena
Add missing profile update hook for detection multiplier change. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-07-13Merge pull request #6719 from opensourcerouting/fpm-force-nhg-fixDonald Sharp
zebra,fpm: fix force disable next hop groups
2020-07-10Merge pull request #6716 from sworleys/Connected-Match-IfindexMark Stapp
zebra: mark connected nh inactive if not matching ifindex
2020-07-10Merge pull request #6715 from volta-networks/fix_isis_circ_saDonald Sharp
isisd: fix Coverity warning
2020-07-10zebra: mark connected nh inactive if not matching ifindexStephen Worley
If we are asked to check if a nexthop is active and it matches a connected route but the ifindex on it does not match the interface with the connected route, mark as inactive. This is a bad nexthop. Before, we would skip this check and just assume any nexthop that matches on a connected route is valid and return here then fail during installation. This adds a check for the IPV*_ifindex nexthop case where the ifindex we have been sent doesn't match. Old: F>r 0.0.0.0/0 [200/0] via 20.0.0.2, test, weight 1, 00:00:27 r via 40.4.4.4, lo, weight 1, 00:00:27 New: F>* 0.0.0.0/0 [200/0] via 20.0.0.2, test, weight 1, 00:00:06 * via 40.4.4.4, lo inactive, weight 1, 00:00:06 Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
2020-07-10tests: Remove bgp_show_ip_bgp_fqdn testDonatas Abraitis
Not really relevant for now. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-07-10zebra,fpm: fix force disable next hop groupsRafael Zalamena
`force_nhg` is only settable when calling from `fpm`, so if the kernel was using next hop groups it would override our knob. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-07-10Merge pull request #6530 from mjstapp/backup_nhg_notifyDonald Sharp
lib, zebra: async notifications for backup routes and LSPs
2020-07-10isisd: fix Coverity warningEmanuele Di Pascale
no need to check cicuit->area, as all code paths leading there had already dereferenced it. Fixes CID 1496314 Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2020-07-10Merge pull request #6403 from NaveenThanikachalam/FRR_RMAP_FIXDonald Sharp
lib: Fix erroneous r-map behavior
2020-07-10Merge pull request #6713 from donaldsharp/pim_doc_fixDonatas Abraitis
pimd: Add some missing mesh-group pim cmds
2020-07-09Merge pull request #6702 from ↵Donald Sharp
ton31337/feature/bgp_show_only_established_sessions bgpd: Add command to show only established sessions
2020-07-09Merge pull request #6703 from mjstapp/fix_bgp_30_secsDonald Sharp
tests: print actual time spent waiting for bgp convergence
2020-07-09Merge pull request #6708 from mrpaulmanley/bugfix/bfd_frr-reloadDonald Sharp
Add BFD peer awareness to frr-reload.py and vtysh markfile
2020-07-09Merge pull request #6709 from mjstapp/fix_topo_ipaddrDonald Sharp
tests: use ipaddress module; tolerate missing support bundle file
2020-07-09pimd: Add some missing mesh-group pim cmdsDonald Sharp
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-07-09test: use ipaddress module instead of ipaddrMark Stapp
Use the standard ipaddress module instead of installing 'ipaddr', which may be deprecated now. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-07-09vtysh: properly exit BFD_PEER_NODE when marking filePaul Manley
vtysh needs to be aware of how to properly exit a bfd peer when subsequent commands only succeed in a higher context. https://github.com/FRRouting/frr/issues/6511#issuecomment-656166206 Signed-off-by: Paul Manley <paul.manley@wholefoods.com>
2020-07-09tools: create sub-context for bfd peersPaul Manley
add lines starting with 'peer' to the list of sub-contexts that are handled by frr-reload.py. https://github.com/FRRouting/frr/issues/6511#issuecomment-655163833 Signed-off-by: Paul Manley <paul.manley@wholefoods.com>
2020-07-09tests: don't fail topotests if bundle file not presentMark Stapp
Test for the existence of the support_bundle conf file before trying to access it. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-07-09lib: block signals in child pthreadsMark Stapp
Block signals in child/additional pthreads; frr daemons generally expect that only the main thread will handle signals. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-07-09tests: print actual time spent waiting for bgp convergenceMark Stapp
Stop printing hard-coded 30 seconds in a couple of places in bgp.py in the topojson infra - print the actual time spent waiting. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-07-09doc: Add 'show bgp summary established' commandDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-07-09bgpd: Add command to show only established sessionsDonatas Abraitis
``` exit1-debian-9# show bgp summary IPv4 Unicast Summary: BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0 BGP table version 8 RIB entries 15, using 2880 bytes of memory Peers 2, using 43 KiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt 192.168.0.2 4 200 10 6 0 0 0 00:00:35 8 8 2a02:4780::2 4 0 0 1 0 0 0 never Active 0 Total number of neighbors 2 exit1-debian-9# show bgp summary established IPv4 Unicast Summary: BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0 BGP table version 8 RIB entries 15, using 2880 bytes of memory Peers 2, using 43 KiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd PfxSnt 192.168.0.2 4 200 10 6 0 0 0 00:00:39 8 8 Total number of neighbors 2 exit1-debian-9# show bgp summary failed IPv4 Unicast Summary: BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0 BGP table version 8 RIB entries 15, using 2880 bytes of memory Peers 2, using 43 KiB of memory Neighbor EstdCnt DropCnt ResetTime Reason 2a02:4780::2 0 0 never Waiting for peer OPEN Total number of neighbors 2 exit1-debian-9# ``` Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-07-09build: find all future minor versions of python3Michal Ruprich
This way we can find every python from 3.8 further Signed-off-by: Michal Ruprich <michalruprich@gmail.com>
2020-07-08Merge pull request #6385 from GalaxyGorilla/bfd_igp_topotestRenato Westphal
isis: tests: Fast RIB recovery from BFD recognized link failures
2020-07-08Merge pull request #6697 from donaldsharp/ospf_router_id_orderingMark Stapp
ospfd: allow interfaces to come up in rare situation
2020-07-08ospfd: allow interfaces to come up in rare situationDonald Sharp
On startup of both zebra and ospfd. If ospfd has not received a valid router-id *but* has received interface data, interfaces will not be turned on in the state machine. When ospf finally receives a valid router-id it would never actually kick the state machine into action for those interfaces it has been configured for. Modify ospf on router id changes, *if* the old router id was INADDR_ANY *and* the interface is operative *and* the oi->state is ISM_Down, give it the old kick in the patooeys Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-07-08zebra: netlink cleanupJakub Urbańczyk
* Split zebra's netlink code into smaller functions to be more generic. Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>
2020-07-08Merge pull request #6693 from qlyoung/doc-value-initialization-practicesDonatas Abraitis
Document value initialization practices
2020-07-07Merge pull request #6690 from kuldeepkash/bgp_basic_functionalityDonald Sharp
tests: Generate support bundle/dump data on tests failures
2020-07-07Merge pull request #6692 from mjstapp/fix_sharp_gcc10Quentin Young
sharpd: use extern for globals
2020-07-07doc: remove trailing whitespaceQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-07-07doc: note preferences for value initializationQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-07-07zebra: clean up the code flow in lsp results processingMark Stapp
Clean up some awkward code in a couple of places where we're processing lsp results from the dataplane. Also add some more debugs in those paths. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-07-07zebra: include backup lsp nhlfes in 'active' checkMark Stapp
Check backup nhlfes/nexthops for 'active' status when checking an LSP. Also tweak the show command output for backup nhlfes slightly. Signed-off-by: Mark Stapp <mjs@voltanet.io>