summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-04-26Merge pull request #8540 from donaldsharp/kill_them_allRafael Zalamena
tests: Remove kill_mininet_router_process
2021-04-26Merge pull request #8555 from idryzhov/fix-bfd-testRafael Zalamena
tests: fix bfd-bgp-cbit-topo3 test
2021-04-25Merge pull request #8526 from donaldsharp/sysctl_docDonatas Abraitis
doc: Start talking about useful sysctl's for proper zebra operation
2021-04-25Merge pull request #8543 from volta-networks/fix_bgp_invalid_nexthopDonatas Abraitis
bgpd: fix invalid labeled nexthop check
2021-04-24tests: fix bfd-bgp-cbit-topo3 testIgor Ryzhov
This test is completely incorrect on test_bfd_loss_intermediate step. It shuts down the interface and then "waiting" for the BGP session to fail. But instead of the actual wait it compares the output of "show bfd peers" with the "up" state. As it does this comparison right after the interface shutdown, the BFD session has not yet failed and the comparison is always successful except very rare cases when the command takes a lot of time to execute (due to the heavy load on CI system I suppose). Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-04-24Merge pull request #8495 from opensourcerouting/ospfv3-bfd-reworkIgor Ryzhov
ospf6d: rework BFD integration and add BFD profiles support
2021-04-24Merge pull request #8462 from opensourcerouting/pim-bfd-refactorIgor Ryzhov
pimd: rework BFD integration and add profile support
2021-04-23Merge pull request #8539 from donaldsharp/isis_circuit_warningIgor Ryzhov
Isis circuit warning
2021-04-23isisd: Remove warnings and add some data to debugs for isis_csm.cDonald Sharp
When running isis and not running isis on all interfaces results in a bunch of warn messages to the log about circuit state changes. These warn messages also didn't bother to inform the end user what interface was causing the fun. Since the end operator cannot do anything with these warn messages and nor should they in the vast array of normal operations modify the code to use event debugging and turn the warns to debugs. Additionally add some information to clue the operator in on to what actual interface we are talking about. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-23topotests: test PIM BFD profile integrationRafael Zalamena
Test that PIM BFD profile integration works. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23doc: document new PIM BFD command variantRafael Zalamena
Tell user he can configure BFD profile for sessions created by PIM. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23pimd: support BFD profiles configurationRafael Zalamena
Allow users to pre configure BFD sessions with a profile. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23yang: add PIM BFD profile supportRafael Zalamena
Allow users to configure BFD profile for the peers in a interface. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23topotests: add new basic PIM topology testRafael Zalamena
Test for PIM (re)convergence and BFD usage. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23pimd: rework BFD integrationRafael Zalamena
Rewrite the BFD integration code to use the new library. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-23bgpd: fix invalid labeled nexthop checkEmanuele Di Pascale
the code processing an NHT update was only resetting the BGP_NEXTHOP_VALID flag, so labeled nexthops were considered valid even if there was no nexthop. Reset the flag in response to the update, and also make the isvalid_nexthop functions a little more robust by checking the number of nexthops. Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2021-04-22tests: Remove kill_mininet_router_processDonald Sharp
This function kills all processes that happen to have the same name to frr processes and it was only ever used in the setup. Setup should not be used to kill old runs. That should be a separate process. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-22isisd: Use enum for circuit stateDonald Sharp
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-22isisd: use an enum for circuit statesDonald Sharp
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-22lib: BFD session handling improvementRafael Zalamena
Don't uninstall sessions if the address, interface, VRF or TTL didn't change. Update the library documentation to make it clear to other developers. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22doc: OSPFv3 BFD profile documentationRafael Zalamena
Let user know he can use BFD profiles with OSPFv3. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22topotests: test OSPFv3 BFD profilesRafael Zalamena
See if the BFD sessions created by OSPFv3 are using the configured BFD profiles. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22ospf6d: add support for BFD profilesRafael Zalamena
Allow user to pre configure BFD sessions using profiles. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22topotests: converge OSPFv3 fasterRafael Zalamena
Tweak OSPFv3 interface configuration to converge faster. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22ospf6d: rework BFD integrationRafael Zalamena
Use the new BFD library to integrate with BFD. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22lib: fix possible crash on BFD notificationRafael Zalamena
Allow sessions to remove themselves from the notifications without risking crashes. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2021-04-22Merge pull request #8536 from idryzhov/bfd-enabledRafael Zalamena
lib: remove enabled flag for bfd sessions
2021-04-22lib: remove enabled flag for bfd sessionsIgor Ryzhov
Currently this flag is only helpful in an extremely rare situation when the BFD session registration was unsuccessful and after that zebra is restarted. Let's remove this flag to simplify the API. If we ever want to solve the problem of unsuccessful registration/deregistration, this can be done using internal flags, without API modification. Also add the error log to help user understand why the BFD session is not working. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-04-21Merge pull request #8528 from opensourcerouting/build-cleanup-20210421Donald Sharp
build: more cleaning
2021-04-21Merge pull request #8529 from donaldsharp/reload_is_notMark Stapp
Reload complaining about using `is not`
2021-04-21build: turn on automake warnings (& symlinks)David Lamparter
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21build: run autoupdateDavid Lamparter
AC_TRY_COMPILE is deprecated too. Also configure.ac isn't executable. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21build: remove deprecated AC_WORDS_BIGENDIANDavid Lamparter
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21build: improve AX_LUA_HEADERS for crosscompileDavid Lamparter
The preprocessor is something configure can invoke. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21build: use AC_CONFIG_AUX_DIRDavid Lamparter
aka the "put shit into a subdirectory" option Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21build: properly split CFLAGS from AC_CFLAGSDavid Lamparter
`CFLAGS` is a "user variable", not intended to be controlled by configure itself. Let's put all the "important" stuff in AC_CFLAGS and only leave debug/optimization controls in CFLAGS. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21build: make builddir include path consistentDavid Lamparter
... by referencing all autogenerated headers relative to the root directory. (90% of the changes here is `version.h`.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21tools: Cleanup frr-reload.py by running black on itDonald Sharp
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-21tools: Fix warning when running frr-reload.pyDonald Sharp
When I run frr-reload.py I am seeing this error: Apr 21 06:23:51 eva frrinit.sh[3776992]: /usr/lib/frr/frr-reload.py:1094: SyntaxWarning: "is not" with a literal. Did you mean "!="? Apr 21 06:23:51 eva frrinit.sh[3776992]: if line is not "exit-vrf": fix Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-21build: fix protobuf out-of-tree buildDavid Lamparter
Otherwise it aborts with "File does not reside within any path specified using --proto_path (or -I)" Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2021-04-21Merge pull request #8516 from patrasar/pim_register_suppress_time_crashIgor Ryzhov
2021-04-20doc: Start talking about useful sysctl's for proper zebra operationDonald Sharp
Add some color to useful sysctl's that are needed for FRR proper operation. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-04-20Merge pull request #8505 from mobash-rasool/ospfv3-max-pathMark Stapp
ospf6d: Do not delete external table when configure max-path
2021-04-20Merge pull request #8482 from wesleycoakley/docker-prefer-cmd-to-entrypointMark Stapp
docker: prefer CMD to ENTRYPOINT for flexibility
2021-04-20Merge pull request #8361 from rameshabhinay/change_1Russ White
bgpd: vrf route leaking related fixes
2021-04-20Merge pull request #8455 from achernavin22/ospf_nssa_after_redist2Russ White
ospfd: install Type-7 when NSSA area is configured after redistribution
2021-04-20Merge pull request #8456 from donaldsharp/idle_to_activeRuss White
bgpd: Address LL peer not NHT when receiving connection attempt
2021-04-20Merge pull request #8501 from ton31337/fix/replace_community_checkDonald Sharp
bgpd: Check for flag existense for community instead of `if not NULL`
2021-04-20Merge pull request #8373 from mjstapp/fix_ospf_timeval_dumpRuss White
ospfd: show seconds in timeval_dump
2021-04-20pimd: fix crash pim register-suppress-time commandSarita Patra
Signed-off-by: Sarita Patra <saritap@vmware.com>