summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-06Merge pull request #5623 from qlyoung/fix-zebra-rtadv-interval-overflowRenato Westphal
zebra: disallow negative rtadv intvl, fix overflow
2020-01-06Merge pull request #5625 from qlyoung/fix-zapi-ipset-name-nulltermRenato Westphal
zebra: ensure ipset name is null terminated
2020-01-06Merge pull request #5614 from qlyoung/fix-zebra-zapi-crashesRenato Westphal
Fix zebra zapi crashes
2020-01-06Merge pull request #5580 from mjstapp/zebra_nhg_debug_categoryRenato Westphal
zebra: add a debug category for nexthops
2020-01-06Merge pull request #5550 from manuhalo/fix_isis_def_levelRenato Westphal
isisd, yang: set default is-type to level-1-2
2020-01-06Merge pull request #5546 from mjstapp/fix_notify_nhtDonald Sharp
zebra: route changes via notify path should trigger nht
2020-01-06Merge pull request #5553 from slankdev/slankdev-fix-kernel-route-deletion-on-vrfDonald Sharp
zebra: fix kernel-route's deletion on vrf
2020-01-06Merge pull request #5621 from qlyoung/fix-zclient-excess-nexthop-decodeMark Stapp
lib: dont decode more nexthops than we can handle
2020-01-06Merge pull request #5626 from qlyoung/fix-zapi-pbr-fooMark Stapp
zebra: Fix zapi pbr foo, pseudowire ifname termination
2020-01-06Merge pull request #5622 from qlyoung/fix-iface-ifindex-compareMark Stapp
lib: fix ifindex comparison overflow
2020-01-06lib: dont decode more nexthops than we can handleQuentin Young
If someone provides us more nexthops than our configured multipath setting, drop the rest of them Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-06Merge pull request #5607 from ton31337/fix/deprecate_bgpTimerUpQuentin Young
bgpd: Time to deprecate bgpTimerUp
2020-01-06Merge pull request #5606 from ton31337/fix/docker_centos8_image_nameJafar Al-Gharaibeh
docker: Use proper container name when creating CentOS 8 container
2020-01-06Merge pull request #5632 from ton31337/fix/dont_use_pipesJafar Al-Gharaibeh
packaging: Redirect stderr to /dev/null in %post action (frr.spec.in)
2020-01-06Merge pull request #5545 from ton31337/feature/show_bgp_json_regexpJafar Al-Gharaibeh
bgpd: Print json output for show_ip_bgp_regexp_cmd
2020-01-06zebra: route changes via notify path trigger nht and mplsMark Stapp
Changes to a route via the dataplane notify path should trigger nht and mpls lsp processing. Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-01-06Merge pull request #5618 from qlyoung/fix-san-flags-additiveRafael Zalamena
configure.ac: make msan & ubsan flags additive
2020-01-06Merge pull request #5619 from qlyoung/fix-zebra-netlink-undefined-bitshiftMark Stapp
zebra: fix undefined bitshifts in netlink stuff
2020-01-06Merge pull request #5630 from slankdev/slankdev-bgpd-fix-large-rdDonatas Abraitis
bgpd: fix large route-distinguisher's format
2020-01-06bgpd: fix large route-distinguisher's formatHiroki Shirokura
This commit is about #5629 's issue. Before this commit, bgpd creates format string of bgp-route-distinguisher as int32, but correctly format is uint32. current bgpd's sh-run-cli generate int32 rd, so if user sets the rd as 1:4294967295(0x1:0xffffffff), sh-run cli generates 1: -1 as running-config. This commit fix that issue. Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
2020-01-05Merge pull request #5467 from pogojotz/alpine-linux-buildDonatas Abraitis
alpine: fix build on current 'edge' version of Alpine
2020-01-05Merge pull request #5601 from donaldsharp/pim_rbDonatas Abraitis
Pim rb
2020-01-05packaging: Redirect stderr to /dev/null in %post action (frr.spec.in)Donatas Abraitis
Solves: ``` /usr/bin/sed: couldn't write 40 items to stdout: Broken pipe /usr/bin/sed: couldn't write 40 items to stdout: Broken pipe /usr/bin/sed: couldn't write 40 items to stdout: Broken pipe /usr/bin/sed: couldn't write 40 items to stdout: Broken pipe /usr/bin/sed: couldn't write 40 items to stdout: Broken pipe /usr/bin/sed: couldn't write 40 items to stdout: Broken pipe /usr/bin/sed: couldn't write 40 items to stdout: Broken pipe ``` This happens because `grep -q` returns immediately after first match and closes the pipe while sed has more output to write. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-01-04zebra: fix undefined bitshifts in netlink stuffQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-03zebra: null terminate interface name from wireQuentin Young
We read an ifname from the wire but don't make sure its null terminated, fix it Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-03zebra: fix iptable memleak, fix free funcsQuentin Young
- Fix iptable freeing code to free malloc'd list - malloc iptable in zapi handler and use those functions to free it when done to fix a linked list memleak Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-03zebra: ensure ipset name is null terminatedQuentin Young
We copy a fixed length buffer from the wire but don't ensure it is null terminated. Then print it as a c-string. Lul. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-03zebra: disallow negative rtadv intvl, fix overflowQuentin Young
- Disallow RA interval < 0 - Fix integer overflow issue converting interval to seconds from milliseconds - Add missing "m" to "ms" Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-03lib: fix ifindex comparison overflowQuentin Young
Very small (negative!) ifindexes, when subtracted, can overflow. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-04bgpd: Time to deprecate bgpTimerUpDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-01-04docker: Use proper container name when creating CentOS 8 containerDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-01-04Merge pull request #5611 from qlyoung/fix-bgp-no-listen-docstringDonatas Abraitis
bgpd: fix too much no listen doc string
2020-01-03configure.ac: make msan & ubsan flags additiveQuentin Young
These were setting = SAN_FLAGS, we want to add to the variable. Note MSAN can't be used with any other sanitizer (except UBSan) but the compiler will complain about that if you use it wrong so we don't need to enforce it here. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-03Merge pull request #5604 from qlyoung/add-ubsan-optionRenato Westphal
configure.ac: add --enable-undefined-sanitizer
2020-01-03Merge pull request #5615 from ton31337/feature/supported_rfc_list_add_8212Quentin Young
doc: Add rfc8212 to supported RFCs list
2020-01-03zebra: check pbr rule msg for correct afiQuentin Young
further down we hash the src & dst ip, which asserts that the afi is one of the well known ones, given the field names i assume the correct afis here are af_inet[6] Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-03pimd: Do not warn for common occurrence in igmp codeDonald Sharp
Do not warn when we receive a multicast address that matches 224.0.0.0/24. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-01-03pimd: Convert the upstream_list and hash to a rb treeDonald Sharp
Convert the upstream_list and hash to a rb tree, Significant time was being spent in the listnode_add_sort. This reduces this time greatly. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-01-03pimd: Convert the channel_oil_list|hash to a rb_treeDonald Sharp
The channel_oil_list and hash are taking significant cpu at scale when adding to the sorted list. Replace with a RB_TREE. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-01-03doc: Add rfc8212 to supported RFCs listDonatas Abraitis
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-01-03zebra: use correct attr size for netlink encQuentin Young
a bool is not 4 bytes Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-02Merge pull request #5613 from srimohans/ietfQuentin Young
doc: Updating FRR supported RFC list
2020-01-02doc: Updating FRR supported RFC listSri Mohana Singamsetty
1. Added subsections for BGP, MPLS, ISIS, OSPF etc. 2. Updated RFCs for BGP, MPLS, OSPF. Signed-off-by: Sri Mohana Singamsetty <msingamsetty@vmware.com>
2020-01-02bgpd: fix too much no listen doc stringQuentin Young
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-01configure.ac: add --enable-undefined-sanitizerQuentin Young
For UBSan Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-01-01Merge pull request #5594 from ton31337/feature/rhel8_dockerDonald Sharp
docker: Create build for CentOS 8
2020-01-01Merge pull request #5593 from ton31337/feature/rhel8_rpmDonald Sharp
packaging: Add CentOS 8 support
2020-01-01Merge pull request #5602 from donaldsharp/ripng_redistributeDonatas Abraitis
Rip redistribute fixes
2019-12-31ripd: Fix redistribute/no redistribute rinse repeate commandsDonald Sharp
ripd was using zclient_redistribute for installation but not for removal. As such the lib/zclient.c was not properly tracking add/removal. I think it would be best to just let rip to track this instead of zclient. Fixes: #5599 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2019-12-31ripngd: Fix redistribute/no redistribute rinse repeat commandsDonald Sharp
ripngd was using zclient_redistribute for installation but not for removal. As such the lib/zclient.c was not properly tracking add/removal. I think it would be best to just let ripng to track this instead of zclient. Fixes: #5599 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>