| Age | Commit message (Collapse) | Author |
|---|
|
tools: add `GotoXref` vim script
|
|
opensourcerouting/fix/contribution_guid_squash_random_commits
Commits hygiene
|
|
tests: Check if route-map vpn import basic funtionality works fine
|
|
opensourcerouting/fix/ecommunity_ipv6_missing_token
bgpd: ecommunity_token_rt6 is not handled
|
|
pceplib: add <time.h> include for time_t
|
|
Fixes build on musl. Used for time_t in the header.
Bug: https://bugs.gentoo.org/862558
Signed-off-by: Sam James <sam@gentoo.org>
|
|
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
Not used at all, just drop it.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
babeld: Fix filtering against all interfaces
|
|
The first argument of `access_list_lookup` and `prefix_list_lookup`
should be `AFI_` constants instead of `AF_` constants.
Signed-off-by: Yuxiang Zhu <vfreex@gmail.com>
|
|
zebra: fix wrong conversion for evpn advertising
|
|
bgpd: Don't try to recursively hold peer io mutex
|
|
BGP was modified in a0b937de428e14e869b8541f0b7810113d619c2e
to grab the peer->io_mtx before validating the header to ensure
that the input Queue was not being modified by anyone else at that
moment in time. Unfortunately validate_header can detect a problem
and attempt to relock the mutex, which deadlocks. This deadlock in
the bgp_io pthread is the lone deadlock at first, eventually though
bgp attempts to write another packet to the peer( say when the
it's time to send the next packet ) and the main pthread of bgpd
becomes deadlocked and then the whole bgpd process is stuck at that
point in time leaving us dead in the water.
The point of locking the mutex earlier was to ensure that the input
Queue wasn't being modified by anyone else, (Say reading off it )
as that we wanted to ensure that we don't hold more packets then necessary.
Let's grab the mutex long enough to look at the input Q size, this
ensure that we have room and then we can validate_header and do the right
thing from there. We'll need to lock the mutex when we actually move it
into the input Q as well.
Fixes: #12725
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
lib, bgpd: Add ability to specify that some json output should not be…
|
|
Commit: 3cdb03fba7b40240fb38469a12b7b05a11043e09
changed the vty_json output to not be pretty printing.
The previous commit in the tree added vty_json_no_pretty
let's use that instead
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
Initial commit: 23b2a7ef524c9fe083b217c7f6ebaec0effc8f52
changed the json output of `show bgp <afi> <safi> json` to
not have pretty print because when under a situation where
there are a bunch of routes with a large scale ecmp show
output was taking forever and this commit cut 2 minutes out
of vtysh run time.
Subusequent commit: f4ec52f7cc99f709756d9030623a20c98a086125
changed this back.
When upgrading to latest version the long run time was noticed
due to testing. Let's add back this functionality such that
FRR can have reduced run times with vtysh when it's really
needed.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
opensourcerouting/fix/treat-as-withdraw_nlri_update
bgpd: Set attr to NULL when passing NLRI_UPDATE with treat-as-withdraw
|
|
Before this patch, we always passed `struct attr` for NLRI_UPDATE, but if we
have a situation with treat-as-withdraw (for example: malformed attribute, or
using a command like `neighbor path-attribute treat-as-withdraw`) the route
MUST be withdrawn form the BGP table.
Hence, we MUST pass attr as NULL, in this case we already have this check
under NLRI_ATTR_ARG() macro, just reuse it properly.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
vtysh: Remove shell access code
|
|
*: Drop deprecated incorrect JSON fields with wrong naming
|
|
*: more format string fixing
|
|
Schedule shell access for deprecation and removal in
a years time.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
I think this one predates the existence of asprintfrr.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
... missed some functions in the earlier commits :(
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
Let's make these unique IDs actually a bit useful.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
|
tests: zebra_rib remove a sleep
|
|
The function ecommunity_str2com_internal appears to want to handle
the ecommunity_token_rt6 enum but skips over it. Commit
9a659715dfcb6c0b1e3ef8004b6c9d14c55f2081 tried to add this but I really
don't see how this is going to behave correctly. Add the
ecommunity_token_rt6 case to the switch statement so it is handled
appropriately?
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
pimd: v6 intentionally turned off route-maps. Turn it on.
|
|
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
debian: synchronize/fold back debian changes
|
|
tests: Fix wrong tgen.stop_topology() calls which got skipped
|
|
build: consistently mkdir -p output for redirect
|
|
zebra: Send nht resolved entry up to concerned protocols in all cases
|
|
Calls were missing the () and caused the stop_topology() to be skipped
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
|
|
The test was sometimes failing around the sleep(4) for
waiting for the routes to be installed. Instead of blindly
sleeping let's check to see that the routes are actually
there in zebra and then continue on.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
build: `-Wformat-nonliteral -Wformat-security`
|
|
opensourcerouting/fix/reset_fqdn_capability_on_before_handling_open
bgpd: Vanish FQDN capability hostname/domainname before handling new BGP OPEN
|
|
tests: Topotests fix for deleting wrong pidfile
|
|
There existed the idea, from Volta, that a nexthop group would not have
the same nexthops installed -vs- what FRR actually sent down. The
dplane would notify you.
With the addition of 06525c4f99d4dcafdf448565f7e11bd70993697d
the code was put behind a bit of a wall controlled the usage
of it.
The flag ROUTE_ENTRY_USE_FIB_NHG flag was being used
to control which set was being sent up to concerned parties
in nexthop tracking. Put this flag behind the wall and
do not necessarily set it when we receive a data plane
notification about a route being installed or not.
Fixes: #12706
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
|
|
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
Run under Github Actions, and restrict commit messages, structure, with, etc.
Enforce using only our specified prefixes for commit messages. It reduces the
work release managers do when _crafting_ release notes.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
Deprecation cycle already passed.
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
|
|
bgpd: bgp_update and bgp_withdraw never return failures
|
|
Fixes killRouterDaemons() function which occasionally deleted the wrong
pidfile.
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
|
