summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
Diffstat (limited to 'tests')
-rw-r--r--tests/bgpd/test_aspath.c12
-rw-r--r--tests/topotests/lib/bgp.py2
-rw-r--r--tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py4
3 files changed, 7 insertions, 11 deletions
diff --git a/tests/bgpd/test_aspath.c b/tests/bgpd/test_aspath.c
index c2d39752ab..7288dc0869 100644
--- a/tests/bgpd/test_aspath.c
+++ b/tests/bgpd/test_aspath.c
@@ -1062,8 +1062,7 @@ static void parse_test(struct test_segment *t)
printf("\n");
- if (asp)
- aspath_unintern(&asp);
+ aspath_unintern(&asp);
}
/* prepend testing */
@@ -1117,8 +1116,7 @@ static void empty_prepend_test(struct test_segment *t)
printf(FAILED "!\n");
printf("\n");
- if (asp1)
- aspath_unintern(&asp1);
+ aspath_unintern(&asp1);
aspath_free(asp2);
}
@@ -1277,10 +1275,8 @@ static int handle_attr_test(struct aspath_tests *t)
}
out:
- if (attr.aspath)
- aspath_unintern(&attr.aspath);
- if (asp)
- aspath_unintern(&asp);
+ aspath_unintern(&attr.aspath);
+ aspath_unintern(&asp);
return failed - initfail;
}
diff --git a/tests/topotests/lib/bgp.py b/tests/topotests/lib/bgp.py
index 551483d718..34afa0d2c1 100644
--- a/tests/topotests/lib/bgp.py
+++ b/tests/topotests/lib/bgp.py
@@ -3677,7 +3677,7 @@ def verify_f_bit(tgen, topo, addr_type, input_dict, dut, peer, expected=True):
@retry(retry_timeout=10)
def verify_graceful_restart_timers(tgen, topo, addr_type, input_dict, dut, peer):
"""
- This API is to verify graceful restart timers, configured and recieved
+ This API is to verify graceful restart timers, configured and received
Parameters
----------
diff --git a/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py b/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py
index a8418d400d..4ab160b52e 100644
--- a/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py
+++ b/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py
@@ -501,7 +501,7 @@ def test_BSR_higher_prefer_ip_p0(request):
step("sleeping for 3 sec to leran new packet")
do_countdown(3)
- step("verify BSR1 is become prefered RP")
+ step("verify BSR1 has become preferred RP")
dut = "l1"
step("Verify if b1 chosen as BSR in f1")
@@ -521,7 +521,7 @@ def test_BSR_higher_prefer_ip_p0(request):
do_countdown(3)
f1_b2_eth1 = topo["routers"]["f1"]["links"]["b2"]["interface"]
shutdown_bringup_interface(tgen, "f1", "f1-b2-eth1", True)
- step("verify BSR2 is become prefered RP")
+ step("verify BSR2 has become preferred RP")
dut = "l1"
step("Send BSR packet from b1 and b2 to FHR")