1 files changed, 279 insertions, 287 deletions

diff --git a/bgpd/bgp_label.c b/bgpd/bgp_label.c
index 27533a5815..ad7411990e 100644
--- a/bgpd/bgp_label.c
+++ b/bgpd/bgp_label.c
@@ -41,309 +41,301 @@
 
 extern struct zclient *zclient;
 
-int
-bgp_parse_fec_update (void)
+int bgp_parse_fec_update(void)
 {
-  struct stream *s;
-  struct bgp_node *rn;
-  struct bgp *bgp;
-  struct bgp_table *table;
-  struct prefix p;
-  u_int32_t label;
-  afi_t afi;
-  safi_t safi;
-
-  s = zclient->ibuf;
-
-  memset(&p, 0, sizeof(struct prefix));
-  p.family = stream_getw(s);
-  p.prefixlen = stream_getc(s);
-  stream_get(&p.u.prefix, s, PSIZE(p.prefixlen));
-  label = stream_getl(s);
-
-  /* hack for the bgp instance & SAFI = have to send/receive it */
-  afi = family2afi(p.family);
-  safi = SAFI_UNICAST;
-  bgp = bgp_get_default();
-  if (!bgp)
-    {
-      zlog_debug("no default bgp instance");
-      return -1;
-    }
-
-  table = bgp->rib[afi][safi];
-  if (!table)
-    {
-      zlog_debug("no %u unicast table", p.family);
-      return -1;
-    }
-  rn = bgp_node_lookup(table, &p);
-  if (!rn)
-    {
-      zlog_debug("no node for the prefix");
-      return -1;
-    }
-
-  /* treat it as implicit withdraw - the label is invalid */
-  if (label == MPLS_INVALID_LABEL)
-    bgp_unset_valid_label(&rn->local_label);
-  else
-    {
-      label_ntop(label, 1, &rn->local_label);
-      bgp_set_valid_label(&rn->local_label);
-    }
-  SET_FLAG(rn->flags, BGP_NODE_LABEL_CHANGED);
-  bgp_unlock_node (rn);
-  bgp_process (bgp, rn, afi, safi);
-  return 1;
+	struct stream *s;
+	struct bgp_node *rn;
+	struct bgp *bgp;
+	struct bgp_table *table;
+	struct prefix p;
+	u_int32_t label;
+	afi_t afi;
+	safi_t safi;
+
+	s = zclient->ibuf;
+
+	memset(&p, 0, sizeof(struct prefix));
+	p.family = stream_getw(s);
+	p.prefixlen = stream_getc(s);
+	stream_get(&p.u.prefix, s, PSIZE(p.prefixlen));
+	label = stream_getl(s);
+
+	/* hack for the bgp instance & SAFI = have to send/receive it */
+	afi = family2afi(p.family);
+	safi = SAFI_UNICAST;
+	bgp = bgp_get_default();
+	if (!bgp) {
+		zlog_debug("no default bgp instance");
+		return -1;
+	}
+
+	table = bgp->rib[afi][safi];
+	if (!table) {
+		zlog_debug("no %u unicast table", p.family);
+		return -1;
+	}
+	rn = bgp_node_lookup(table, &p);
+	if (!rn) {
+		zlog_debug("no node for the prefix");
+		return -1;
+	}
+
+	/* treat it as implicit withdraw - the label is invalid */
+	if (label == MPLS_INVALID_LABEL)
+		bgp_unset_valid_label(&rn->local_label);
+	else {
+		label_ntop(label, 1, &rn->local_label);
+		bgp_set_valid_label(&rn->local_label);
+	}
+	SET_FLAG(rn->flags, BGP_NODE_LABEL_CHANGED);
+	bgp_unlock_node(rn);
+	bgp_process(bgp, rn, afi, safi);
+	return 1;
 }
 
-mpls_label_t
-bgp_adv_label (struct bgp_node *rn, struct bgp_info *ri, struct peer *to,
-	   afi_t afi, safi_t safi)
+mpls_label_t bgp_adv_label(struct bgp_node *rn, struct bgp_info *ri,
+			   struct peer *to, afi_t afi, safi_t safi)
 {
-  struct peer *from;
-  mpls_label_t remote_label;
-  int reflect;
+	struct peer *from;
+	mpls_label_t remote_label;
+	int reflect;
 
-  if (!rn || !ri || !to)
-    return MPLS_INVALID_LABEL;
+	if (!rn || !ri || !to)
+		return MPLS_INVALID_LABEL;
 
-  remote_label = ri->extra ? ri->extra->label : MPLS_INVALID_LABEL;
-  from = ri->peer;
-  reflect = ((from->sort == BGP_PEER_IBGP) && (to->sort == BGP_PEER_IBGP));
+	remote_label = ri->extra ? ri->extra->label : MPLS_INVALID_LABEL;
+	from = ri->peer;
+	reflect =
+		((from->sort == BGP_PEER_IBGP) && (to->sort == BGP_PEER_IBGP));
 
-  if (reflect && !CHECK_FLAG(to->af_flags[afi][safi],
-			     PEER_FLAG_FORCE_NEXTHOP_SELF))
-    return remote_label;
+	if (reflect
+	    && !CHECK_FLAG(to->af_flags[afi][safi],
+			   PEER_FLAG_FORCE_NEXTHOP_SELF))
+		return remote_label;
 
-  if (CHECK_FLAG(to->af_flags[afi][safi], PEER_FLAG_NEXTHOP_UNCHANGED))
-    return remote_label;
+	if (CHECK_FLAG(to->af_flags[afi][safi], PEER_FLAG_NEXTHOP_UNCHANGED))
+		return remote_label;
 
-  return rn->local_label;
+	return rn->local_label;
 }
 
-void
-bgp_reg_dereg_for_label (struct bgp_node *rn, struct bgp_info *ri,
-                         int reg)
+void bgp_reg_dereg_for_label(struct bgp_node *rn, struct bgp_info *ri, int reg)
 {
-  struct stream *s;
-  struct prefix *p;
-  int command;
-  u_int16_t flags = 0;
-  size_t flags_pos = 0;
-
-  /* Check socket. */
-  if (!zclient || zclient->sock < 0)
-    return;
-
-  p = &(rn->p);
-  s = zclient->obuf;
-  stream_reset (s);
-  command = (reg) ? ZEBRA_FEC_REGISTER : ZEBRA_FEC_UNREGISTER;
-  zclient_create_header (s, command, VRF_DEFAULT);
-  flags_pos = stream_get_endp (s); /* save position of 'flags' */
-  stream_putw(s, flags); /* initial flags */
-  stream_putw(s, PREFIX_FAMILY(p));
-  stream_put_prefix(s, p);
-  if (reg)
-    {
-      assert (ri);
-      if (ri->attr->flag & ATTR_FLAG_BIT (BGP_ATTR_PREFIX_SID))
-        {
-          if (ri->attr->label_index != BGP_INVALID_LABEL_INDEX)
-            {
-              flags |= ZEBRA_FEC_REGISTER_LABEL_INDEX;
-              stream_putl (s, ri->attr->label_index);
-            }
-        }
-      SET_FLAG (rn->flags, BGP_NODE_REGISTERED_FOR_LABEL);
-    }
-  else
-    UNSET_FLAG (rn->flags, BGP_NODE_REGISTERED_FOR_LABEL);
-
-  /* Set length and flags */
-  stream_putw_at (s, 0, stream_get_endp (s));
-  stream_putw_at (s, flags_pos, flags);
-
-  zclient_send_message(zclient);
+	struct stream *s;
+	struct prefix *p;
+	int command;
+	u_int16_t flags = 0;
+	size_t flags_pos = 0;
+
+	/* Check socket. */
+	if (!zclient || zclient->sock < 0)
+		return;
+
+	p = &(rn->p);
+	s = zclient->obuf;
+	stream_reset(s);
+	command = (reg) ? ZEBRA_FEC_REGISTER : ZEBRA_FEC_UNREGISTER;
+	zclient_create_header(s, command, VRF_DEFAULT);
+	flags_pos = stream_get_endp(s); /* save position of 'flags' */
+	stream_putw(s, flags);		/* initial flags */
+	stream_putw(s, PREFIX_FAMILY(p));
+	stream_put_prefix(s, p);
+	if (reg) {
+		assert(ri);
+		if (ri->attr->flag & ATTR_FLAG_BIT(BGP_ATTR_PREFIX_SID)) {
+			if (ri->attr->label_index != BGP_INVALID_LABEL_INDEX) {
+				flags |= ZEBRA_FEC_REGISTER_LABEL_INDEX;
+				stream_putl(s, ri->attr->label_index);
+			}
+		}
+		SET_FLAG(rn->flags, BGP_NODE_REGISTERED_FOR_LABEL);
+	} else
+		UNSET_FLAG(rn->flags, BGP_NODE_REGISTERED_FOR_LABEL);
+
+	/* Set length and flags */
+	stream_putw_at(s, 0, stream_get_endp(s));
+	stream_putw_at(s, flags_pos, flags);
+
+	zclient_send_message(zclient);
 }
 
-static int
-bgp_nlri_get_labels (struct peer *peer, u_char *pnt, u_char plen, mpls_label_t *label)
+static int bgp_nlri_get_labels(struct peer *peer, u_char *pnt, u_char plen,
+			       mpls_label_t *label)
 {
-  u_char *data = pnt;
-  u_char *lim = pnt + plen;
-  u_char llen = 0;
-  u_char label_depth = 0;
-
-  for (; data < lim; data += BGP_LABEL_BYTES)
-    {
-      memcpy(label, data, BGP_LABEL_BYTES);
-      llen += BGP_LABEL_BYTES;
-
-      bgp_set_valid_label(label);
-      label_depth += 1;
-
-      if (bgp_is_withdraw_label(label) || label_bos(label))
-        break;
-    }
-
-  /* If we RX multiple labels we will end up keeping only the last
-   * one. We do not yet support a label stack greater than 1. */
-  if (label_depth > 1)
-      zlog_warn("%s rcvd UPDATE with label stack %d deep",
-                peer->host, label_depth);
-
-  if (!(bgp_is_withdraw_label(label) || label_bos(label)))
-      zlog_warn("%s rcvd UPDATE with invalid label stack - no bottom of stack",
-                peer->host);
-
-  return llen;
+	u_char *data = pnt;
+	u_char *lim = pnt + plen;
+	u_char llen = 0;
+	u_char label_depth = 0;
+
+	for (; data < lim; data += BGP_LABEL_BYTES) {
+		memcpy(label, data, BGP_LABEL_BYTES);
+		llen += BGP_LABEL_BYTES;
+
+		bgp_set_valid_label(label);
+		label_depth += 1;
+
+		if (bgp_is_withdraw_label(label) || label_bos(label))
+			break;
+	}
+
+	/* If we RX multiple labels we will end up keeping only the last
+	 * one. We do not yet support a label stack greater than 1. */
+	if (label_depth > 1)
+		zlog_warn("%s rcvd UPDATE with label stack %d deep", peer->host,
+			  label_depth);
+
+	if (!(bgp_is_withdraw_label(label) || label_bos(label)))
+		zlog_warn(
+			"%s rcvd UPDATE with invalid label stack - no bottom of stack",
+			peer->host);
+
+	return llen;
 }
 
-int
-bgp_nlri_parse_label (struct peer *peer, struct attr *attr,
-                      struct bgp_nlri *packet)
+int bgp_nlri_parse_label(struct peer *peer, struct attr *attr,
+			 struct bgp_nlri *packet)
 {
-  u_char *pnt;
-  u_char *lim;
-  struct prefix p;
-  int psize = 0;
-  int prefixlen;
-  afi_t afi;
-  safi_t safi;
-  int addpath_encoded;
-  u_int32_t addpath_id;
-  mpls_label_t label = MPLS_INVALID_LABEL;
-  u_char llen;
-
-  /* Check peer status. */
-  if (peer->status != Established)
-    return 0;
-
-  pnt = packet->nlri;
-  lim = pnt + packet->length;
-  afi = packet->afi;
-  safi = packet->safi;
-  addpath_id = 0;
-
-  addpath_encoded = (CHECK_FLAG (peer->af_cap[afi][safi], PEER_CAP_ADDPATH_AF_RX_ADV) &&
-                     CHECK_FLAG (peer->af_cap[afi][safi], PEER_CAP_ADDPATH_AF_TX_RCV));
-
-  for (; pnt < lim; pnt += psize)
-    {
-      /* Clear prefix structure. */
-      memset (&p, 0, sizeof (struct prefix));
-      llen = 0;
-
-      if (addpath_encoded)
-        {
-
-          /* When packet overflow occurs return immediately. */
-          if (pnt + BGP_ADDPATH_ID_LEN > lim)
-            return -1;
-
-          addpath_id = ntohl(*((uint32_t*) pnt));
-          pnt += BGP_ADDPATH_ID_LEN;
-        }
-
-      /* Fetch prefix length. */
-      prefixlen = *pnt++;
-      p.family = afi2family (packet->afi);
-      psize = PSIZE (prefixlen);
-
-      /* sanity check against packet data */
-      if ((pnt + psize) > lim)
-        {
-          zlog_err ("%s [Error] Update packet error / L-U (prefix length %d exceeds packet size %u)",
-                    peer->host,
-                    prefixlen, (uint)(lim-pnt));
-          return -1;
-        }
-
-      /* Fill in the labels */
-      llen = bgp_nlri_get_labels(peer, pnt, psize, &label);
-      p.prefixlen = prefixlen - BSIZE(llen);
-
-      /* There needs to be at least one label */
-      if (prefixlen < 24)
-        {
-          zlog_err ("%s [Error] Update packet error"
-                    " (wrong label length %d)",
-                    peer->host, prefixlen);
-          bgp_notify_send (peer, BGP_NOTIFY_UPDATE_ERR,
-                           BGP_NOTIFY_UPDATE_INVAL_NETWORK);
-          return -1;
-        }
-
-      if ((afi == AFI_IP && p.prefixlen > 32)
-	  || (afi == AFI_IP6 && p.prefixlen > 128))
-	return -1;
-
-      /* Fetch prefix from NLRI packet */
-      memcpy (&p.u.prefix, pnt + llen, psize - llen);
-
-      /* Check address. */
-      if (afi == AFI_IP && safi == SAFI_LABELED_UNICAST)
-        {
-          if (IN_CLASSD (ntohl (p.u.prefix4.s_addr)))
-            {
-              /* From RFC4271 Section 6.3:
-               *
-               * If a prefix in the NLRI field is semantically incorrect
-               * (e.g., an unexpected multicast IP address), an error SHOULD
-               * be logged locally, and the prefix SHOULD be ignored.
-                */
-              zlog_err ("%s: IPv4 labeled-unicast NLRI is multicast address %s, ignoring",
-                        peer->host, inet_ntoa (p.u.prefix4));
-              continue;
-            }
-        }
-
-      /* Check address. */
-      if (afi == AFI_IP6 && safi == SAFI_LABELED_UNICAST)
-        {
-          if (IN6_IS_ADDR_LINKLOCAL (&p.u.prefix6))
-            {
-              char buf[BUFSIZ];
-
-              zlog_err ("%s: IPv6 labeled-unicast NLRI is link-local address %s, ignoring",
-                        peer->host, inet_ntop (AF_INET6, &p.u.prefix6, buf, BUFSIZ));
-
-              continue;
-            }
-
-          if (IN6_IS_ADDR_MULTICAST (&p.u.prefix6))
-            {
-              char buf[BUFSIZ];
-
-              zlog_err ("%s: IPv6 unicast NLRI is multicast address %s, ignoring",
-                        peer->host, inet_ntop (AF_INET6, &p.u.prefix6, buf, BUFSIZ));
-
-              continue;
-            }
-        }
-
-      if (attr)
-        {
-          bgp_update (peer, &p, addpath_id, attr, packet->afi, SAFI_UNICAST,
-                      ZEBRA_ROUTE_BGP, BGP_ROUTE_NORMAL, NULL, &label, 0, NULL);
-        }
-      else
-        {
-          bgp_withdraw (peer, &p, addpath_id, attr, packet->afi, SAFI_UNICAST,
-                        ZEBRA_ROUTE_BGP, BGP_ROUTE_NORMAL, NULL, &label, NULL);
-        }
-    }
-
-  /* Packet length consistency check. */
-  if (pnt != lim)
-    {
-      zlog_err ("%s [Error] Update packet error / L-U (%zu data remaining after parsing)",
-                peer->host, lim - pnt);
-      return -1;
-    }
-
-  return 0;
+	u_char *pnt;
+	u_char *lim;
+	struct prefix p;
+	int psize = 0;
+	int prefixlen;
+	afi_t afi;
+	safi_t safi;
+	int addpath_encoded;
+	u_int32_t addpath_id;
+	mpls_label_t label = MPLS_INVALID_LABEL;
+	u_char llen;
+
+	/* Check peer status. */
+	if (peer->status != Established)
+		return 0;
+
+	pnt = packet->nlri;
+	lim = pnt + packet->length;
+	afi = packet->afi;
+	safi = packet->safi;
+	addpath_id = 0;
+
+	addpath_encoded =
+		(CHECK_FLAG(peer->af_cap[afi][safi], PEER_CAP_ADDPATH_AF_RX_ADV)
+		 && CHECK_FLAG(peer->af_cap[afi][safi],
+			       PEER_CAP_ADDPATH_AF_TX_RCV));
+
+	for (; pnt < lim; pnt += psize) {
+		/* Clear prefix structure. */
+		memset(&p, 0, sizeof(struct prefix));
+		llen = 0;
+
+		if (addpath_encoded) {
+
+			/* When packet overflow occurs return immediately. */
+			if (pnt + BGP_ADDPATH_ID_LEN > lim)
+				return -1;
+
+			addpath_id = ntohl(*((uint32_t *)pnt));
+			pnt += BGP_ADDPATH_ID_LEN;
+		}
+
+		/* Fetch prefix length. */
+		prefixlen = *pnt++;
+		p.family = afi2family(packet->afi);
+		psize = PSIZE(prefixlen);
+
+		/* sanity check against packet data */
+		if ((pnt + psize) > lim) {
+			zlog_err(
+				"%s [Error] Update packet error / L-U (prefix length %d exceeds packet size %u)",
+				peer->host, prefixlen, (uint)(lim - pnt));
+			return -1;
+		}
+
+		/* Fill in the labels */
+		llen = bgp_nlri_get_labels(peer, pnt, psize, &label);
+		p.prefixlen = prefixlen - BSIZE(llen);
+
+		/* There needs to be at least one label */
+		if (prefixlen < 24) {
+			zlog_err(
+				"%s [Error] Update packet error"
+				" (wrong label length %d)",
+				peer->host, prefixlen);
+			bgp_notify_send(peer, BGP_NOTIFY_UPDATE_ERR,
+					BGP_NOTIFY_UPDATE_INVAL_NETWORK);
+			return -1;
+		}
+
+		if ((afi == AFI_IP && p.prefixlen > 32)
+		    || (afi == AFI_IP6 && p.prefixlen > 128))
+			return -1;
+
+		/* Fetch prefix from NLRI packet */
+		memcpy(&p.u.prefix, pnt + llen, psize - llen);
+
+		/* Check address. */
+		if (afi == AFI_IP && safi == SAFI_LABELED_UNICAST) {
+			if (IN_CLASSD(ntohl(p.u.prefix4.s_addr))) {
+				/* From RFC4271 Section 6.3:
+				 *
+				 * If a prefix in the NLRI field is semantically
+				 * incorrect
+				 * (e.g., an unexpected multicast IP address),
+				 * an error SHOULD
+				 * be logged locally, and the prefix SHOULD be
+				 * ignored.
+				  */
+				zlog_err(
+					"%s: IPv4 labeled-unicast NLRI is multicast address %s, ignoring",
+					peer->host, inet_ntoa(p.u.prefix4));
+				continue;
+			}
+		}
+
+		/* Check address. */
+		if (afi == AFI_IP6 && safi == SAFI_LABELED_UNICAST) {
+			if (IN6_IS_ADDR_LINKLOCAL(&p.u.prefix6)) {
+				char buf[BUFSIZ];
+
+				zlog_err(
+					"%s: IPv6 labeled-unicast NLRI is link-local address %s, ignoring",
+					peer->host,
+					inet_ntop(AF_INET6, &p.u.prefix6, buf,
+						  BUFSIZ));
+
+				continue;
+			}
+
+			if (IN6_IS_ADDR_MULTICAST(&p.u.prefix6)) {
+				char buf[BUFSIZ];
+
+				zlog_err(
+					"%s: IPv6 unicast NLRI is multicast address %s, ignoring",
+					peer->host,
+					inet_ntop(AF_INET6, &p.u.prefix6, buf,
+						  BUFSIZ));
+
+				continue;
+			}
+		}
+
+		if (attr) {
+			bgp_update(peer, &p, addpath_id, attr, packet->afi,
+				   SAFI_UNICAST, ZEBRA_ROUTE_BGP,
+				   BGP_ROUTE_NORMAL, NULL, &label, 0, NULL);
+		} else {
+			bgp_withdraw(peer, &p, addpath_id, attr, packet->afi,
+				     SAFI_UNICAST, ZEBRA_ROUTE_BGP,
+				     BGP_ROUTE_NORMAL, NULL, &label, NULL);
+		}
+	}
+
+	/* Packet length consistency check. */
+	if (pnt != lim) {
+		zlog_err(
+			"%s [Error] Update packet error / L-U (%zu data remaining after parsing)",
+			peer->host, lim - pnt);
+		return -1;
+	}
+
+	return 0;
 }