summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--bgpd/bgp_route.c4
-rw-r--r--bgpd/rfapi/rfapi_import.c2
-rw-r--r--doc/developer/include-compile.rst1
-rw-r--r--tests/topotests/bgp_disable_addpath_rx/r1/bgpd.conf2
-rw-r--r--tests/topotests/bgp_disable_addpath_rx/r2/bgpd.conf2
-rw-r--r--tests/topotests/bgp_disable_addpath_rx/r3/bgpd.conf2
-rw-r--r--tests/topotests/bgp_disable_addpath_rx/r4/bgpd.conf2
-rw-r--r--tests/topotests/munet/cli.py8
8 files changed, 10 insertions, 13 deletions
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 4e4dce84fe..2046f74182 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -1466,7 +1466,7 @@ int bgp_evpn_path_info_cmp(struct bgp *bgp, struct bgp_path_info *new,
struct bgp_path_info *exist, int *paths_eq)
{
enum bgp_path_selection_reason reason;
- char pfx_buf[PREFIX2STR_BUFFER];
+ char pfx_buf[PREFIX2STR_BUFFER] = {};
return bgp_path_info_cmp(bgp, new, exist, paths_eq, NULL, 0, pfx_buf,
AFI_L2VPN, SAFI_EVPN, &reason);
@@ -2653,7 +2653,7 @@ void bgp_best_selection(struct bgp *bgp, struct bgp_dest *dest,
struct bgp_path_info *nextpi = NULL;
int paths_eq, do_mpath, debug;
struct list mp_list;
- char pfx_buf[PREFIX2STR_BUFFER];
+ char pfx_buf[PREFIX2STR_BUFFER] = {};
char path_buf[PATH_ADDPATH_STR_BUFFER];
bgp_mp_list_init(&mp_list);
diff --git a/bgpd/rfapi/rfapi_import.c b/bgpd/rfapi/rfapi_import.c
index 4b8e07a9c4..27f7c88d7b 100644
--- a/bgpd/rfapi/rfapi_import.c
+++ b/bgpd/rfapi/rfapi_import.c
@@ -1939,7 +1939,7 @@ static void rfapiBgpInfoAttachSorted(struct agg_node *rn,
struct bgp *bgp;
struct bgp_path_info *prev;
struct bgp_path_info *next;
- char pfx_buf[PREFIX2STR_BUFFER];
+ char pfx_buf[PREFIX2STR_BUFFER] = {};
bgp = bgp_get_default(); /* assume 1 instance for now */
diff --git a/doc/developer/include-compile.rst b/doc/developer/include-compile.rst
index 513cac6179..b98d237e68 100644
--- a/doc/developer/include-compile.rst
+++ b/doc/developer/include-compile.rst
@@ -17,7 +17,6 @@ obtained by running ``./configure -h``. The options shown below are examples.
--localstatedir=/var/run/frr \
--sysconfdir=/etc/frr \
--with-moduledir=\${prefix}/lib/frr/modules \
- --with-libyang-pluginsdir=\${prefix}/lib/frr/libyang_plugins \
--enable-configfile-mask=0640 \
--enable-logfile-mask=0640 \
--enable-snmp=agentx \
diff --git a/tests/topotests/bgp_disable_addpath_rx/r1/bgpd.conf b/tests/topotests/bgp_disable_addpath_rx/r1/bgpd.conf
index af1353e0e0..44b009e9ca 100644
--- a/tests/topotests/bgp_disable_addpath_rx/r1/bgpd.conf
+++ b/tests/topotests/bgp_disable_addpath_rx/r1/bgpd.conf
@@ -1,6 +1,6 @@
!
router bgp 65001
- timers 3 10
+ timers bgp 3 10
no bgp ebgp-requires-policy
neighbor 192.168.1.2 remote-as external
neighbor 192.168.1.2 timers connect 5
diff --git a/tests/topotests/bgp_disable_addpath_rx/r2/bgpd.conf b/tests/topotests/bgp_disable_addpath_rx/r2/bgpd.conf
index db68e554d4..8274e3f96d 100644
--- a/tests/topotests/bgp_disable_addpath_rx/r2/bgpd.conf
+++ b/tests/topotests/bgp_disable_addpath_rx/r2/bgpd.conf
@@ -1,5 +1,5 @@
router bgp 65002
- timers 3 10
+ timers bgp 3 10
no bgp ebgp-requires-policy
neighbor 192.168.1.1 remote-as external
neighbor 192.168.1.1 timers connect 5
diff --git a/tests/topotests/bgp_disable_addpath_rx/r3/bgpd.conf b/tests/topotests/bgp_disable_addpath_rx/r3/bgpd.conf
index 3ac6a08e47..98eb2e1711 100644
--- a/tests/topotests/bgp_disable_addpath_rx/r3/bgpd.conf
+++ b/tests/topotests/bgp_disable_addpath_rx/r3/bgpd.conf
@@ -1,5 +1,5 @@
router bgp 65003
- timers 3 10
+ timers bgp 3 10
no bgp ebgp-requires-policy
neighbor 192.168.2.2 remote-as external
neighbor 192.168.2.2 timers connect 5
diff --git a/tests/topotests/bgp_disable_addpath_rx/r4/bgpd.conf b/tests/topotests/bgp_disable_addpath_rx/r4/bgpd.conf
index 8ab405fbd8..68245c4a21 100644
--- a/tests/topotests/bgp_disable_addpath_rx/r4/bgpd.conf
+++ b/tests/topotests/bgp_disable_addpath_rx/r4/bgpd.conf
@@ -1,5 +1,5 @@
router bgp 65004
- timers 3 10
+ timers bgp 3 10
no bgp ebgp-requires-policy
neighbor 192.168.2.2 remote-as external
neighbor 192.168.2.2 timers connect 5
diff --git a/tests/topotests/munet/cli.py b/tests/topotests/munet/cli.py
index f58ea99d67..f631073bb1 100644
--- a/tests/topotests/munet/cli.py
+++ b/tests/topotests/munet/cli.py
@@ -93,7 +93,7 @@ def spawn(unet, host, cmd, iow, ns_only):
elif master_fd in r:
o = os.read(master_fd, 10240)
if o:
- iow.write(o.decode("utf-8"))
+ iow.write(o.decode("utf-8", "ignore"))
iow.flush()
finally:
# restore tty settings back
@@ -281,7 +281,6 @@ async def async_input(prompt, histfile):
def make_help_str(unet):
-
w = sorted([x if x else "" for x in unet.cli_in_window_cmds])
ww = unet.cli_in_window_cmds
u = sorted([x if x else "" for x in unet.cli_run_cmds])
@@ -516,7 +515,6 @@ class Completer:
async def doline(
unet, line, outf, background=False, notty=False
): # pylint: disable=R0911
-
line = line.strip()
m = re.fullmatch(r"^(\S+)(?:\s+(.*))?$", line)
if not m:
@@ -670,7 +668,7 @@ async def cli_client(sockpath, prompt="munet> "):
rb = rb[: -len(ENDMARKER)]
# Write the output
- sys.stdout.write(rb.decode("utf-8"))
+ sys.stdout.write(rb.decode("utf-8", "ignore"))
async def local_cli(unet, outf, prompt, histfile, background):
@@ -729,7 +727,7 @@ async def cli_client_connected(unet, background, reader, writer):
self.writer = writer
def write(self, x):
- self.writer.write(x.encode("utf-8"))
+ self.writer.write(x.encode("utf-8", "ignore"))
def flush(self):
self.writer.flush()